From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E28C33C183 for ; Mon, 9 Mar 2026 19:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773085731; cv=none; b=TtOfxtCALccelw3oj0s/k37ZTwEwyAzZSP0a3fBosMvSmrXAtLRt6kpk1YLdzv4jzZtiIXDAcd3GDRLt2ZpBB7zSZ5U9ww52mmu6xbwgvoloZrV6DWYGynYRVNNJeP2M8DVDFAytUAVqA3VYvATdZHMcCk/5PuymsfD0eX/Kxco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773085731; c=relaxed/simple; bh=hLn046K7Bbtakbf/CSH1PdqAYCPfjzoSWSGucaaZ4zc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VrQKwLwnLQMsDOSAjqTv6HjCASQh3E9ifcQkitDlkT0IARes7N6taqQRWmE2rHQ9Wr4sN/a7J+D/etWJ5z6QlLjod6X3dJSmb+zaYIJBXPJU0ozXjp4t5yXMx8sylUzyNUAjVrDZtxVGzIZBeNTZZat5lwLklsCHfbMK5RI5MD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZEU2OqxK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZEU2OqxK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06832C2BC87; Mon, 9 Mar 2026 19:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773085730; bh=hLn046K7Bbtakbf/CSH1PdqAYCPfjzoSWSGucaaZ4zc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZEU2OqxKE4K4U2w0B0f0ZnSiumP9hTWhEYqMesO6/EeglKejq+0Fs3FlFQO1YYmag zx5jQOmymPt32QKibei5WQbnchlYAB6bGaDVr/0L+r3ixSUOjBo6HkHRO/2iM7pEAE X/wDSsYOZpiniiTg8LypoTl1ToihM37nGPn8hQBMmvwBiY/H/sgeGAH3Pg1HoMvNU3 3u0dWnoRjgxj0mxfPM7nUSzbxyW5CU9C2dD7bJ+ek0ukm/HnKkdKO6cpGK7Z6NNCQz p8G28iQ3UEGfOWFk1rXgaYzTg2hduLXtjgcCPbuNaWoq1s4KyJU+FWOr3y9qjjyGFr j8fIJW5b2a3yw== Date: Mon, 9 Mar 2026 20:48:47 +0100 From: Lorenzo Bianconi To: Andrew Lunn Cc: Matthias Brugger , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH] arm64: dts: airoha: en7581: Add switch node to to EN7581 SoC Message-ID: References: <20260309-airoha-7581-dsa-switch-v1-1-448530b7f91f@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="84AudNwnjjFunWL9" Content-Disposition: inline In-Reply-To: --84AudNwnjjFunWL9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > + gsw_phy1: ethernet-phy@1 { > > + compatible =3D "ethernet-phy-ieee802.3-c22"; > > + reg =3D <9>; >=20 > The @1 should match the reg value. So this is wrong. ack, I will fix it in v2. >=20 > > + phy-mode =3D "internal"; >=20 > phy-mode is actually a MAC property, not a PHY property. It is not > listed in > Documentation/devicetree/bindings/net/ethernet-phy.yaml. Which also > suggest this has not been tested using the DT validation tools. ack, right. I guess this just a leftover of a previous implementation, I wi= ll remove it in v2. Anyway I compiled the dts with the command below: $make CHECK_DTBS=3Dy W=3D1 airoha/en7581-evb.dtb Regards, Lorenzo >=20 > Andrew >=20 --84AudNwnjjFunWL9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCaa8kHwAKCRA6cBh0uS2t rGw+APoDgNAVNaQq61XtrlM++fJOEhoVovfOQwUr54rfo6BNcwD8DwS4HIbPsbVx sKWaXxv0PB5hdpZk63vRIclsFxBBVQs= =UIg7 -----END PGP SIGNATURE----- --84AudNwnjjFunWL9--