From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403B8C7618E for ; Wed, 26 Apr 2023 23:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242119AbjDZXdv (ORCPT ); Wed, 26 Apr 2023 19:33:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240783AbjDZXdt (ORCPT ); Wed, 26 Apr 2023 19:33:49 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 544E93C30 for ; Wed, 26 Apr 2023 16:33:45 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-953343581a4so1186288066b.3 for ; Wed, 26 Apr 2023 16:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682552024; x=1685144024; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mGxx/Wp7YoyInjx2MQFOjEqf+qzS2POXDbnN6s82MQc=; b=BZP42WZBirI8WBMnHioiAhe1YLztl8E9Aj3RsuOgx7KQ9ri18AeSRUp1Z937cjsuKu b1yUUQkTmPpdcgNBewYDBLj2LMUaZsmK+4mauPhbPUodoSjSaUyDabMcPkZI7x+2rUh1 DAXYLd8sHghRnknDbFguWwQboB9dRK1aM47pGXKNevV9UpgF8NdA4XO3yDDi+ozTL6ub rKBEn3xKxPSnNtY8sFACN35R81ip7mBbrcD0vhgWBf9kkvDnFhLtTo3ZSeQyA5PXsvno okBjIkLcNQrYEwsx+IZxkbHB6Kav6tMo+8DiI9WvOBQa9QTPc5Qc9bQ9GQLeKgTy5C7L GQSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682552024; x=1685144024; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mGxx/Wp7YoyInjx2MQFOjEqf+qzS2POXDbnN6s82MQc=; b=gC1OdAPNHOFzRzNijgnRVPY0hlniIgptba2WT0Uccyj8cXDBj4vI3FTah6LNM6wSko qDA408XsQh3t3dNxlPzwzqXc1Ou7qfC9w2Ux5q6iTSWHQR1GtVeuFuGipLAm0olRe5am Flxbuoz72XMZ2yTpvnk811XOmBHElTWr1i+0JEHMcyW2yP/yGpsYozOSgN6j2QjbEHiA cI3Z11FUjA8PW6DBxaYsXLHyuf+eYuuZzGosXAMe9t7UOJtwOt9XeRmwNReeZE571UBB MCz4hKDIr4iT3x1zKk/XQGTTeWCibUKdyEpAIFU7zZwAsU8XMygNLMDZj8EA4d1UZEss 514w== X-Gm-Message-State: AAQBX9dw/Ea3SI8d+hnj8Ud7p5vv5QeUH6NrouusdLBSTdK6jwU91Z8Y r6aGXR5iKJJoGvtV8PIPEGr4nw== X-Google-Smtp-Source: AKy350bsUIt5HhDZ4+MiMWS21VH6MLlhA2kcVi7lcpgPxKao8PuQpH2UDaSGMtwjcGNlQUBCF4/zvg== X-Received: by 2002:a17:907:96a1:b0:94e:d72b:d10c with SMTP id hd33-20020a17090796a100b0094ed72bd10cmr19180774ejc.40.1682552023729; Wed, 26 Apr 2023 16:33:43 -0700 (PDT) Received: from [172.23.2.152] ([195.167.132.10]) by smtp.gmail.com with ESMTPSA id h13-20020a170906718d00b0095386574c81sm8858234ejk.51.2023.04.26.16.33.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 16:33:43 -0700 (PDT) Message-ID: Date: Thu, 27 Apr 2023 00:33:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 6/7] arm64: dts: qcom: sc8280xp-crd: Add QMP to SuperSpeed graph Content-Language: en-US To: Bjorn Andersson , Bjorn Andersson , Johan Hovold Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230425034010.3789376-1-quic_bjorande@quicinc.com> <20230425034010.3789376-7-quic_bjorande@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230425034010.3789376-7-quic_bjorande@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/25/23 04:40, Bjorn Andersson wrote: > With support for the QMP combo phy to react to USB Type-C switch events, > introduce it as the next hop for the SuperSpeed lanes of the two USB > Type-C connectors, and connect the output of the DisplayPort controller > to the QMP combo phy. > > This allows the TCPM to perform orientation switching of both USB and > DisplayPort signals. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 28 ++++++++++++++++--- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 34 +++++++++++++++++++++++ > 2 files changed, 58 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index 547277924ea3..33c973661fa5 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -64,7 +64,7 @@ port@1 { > reg = <1>; > > pmic_glink_con0_ss: endpoint { > - remote-endpoint = <&mdss0_dp0_out>; > + remote-endpoint = <&usb_0_qmpphy_out>; > }; > }; > > @@ -99,7 +99,7 @@ port@1 { > reg = <1>; > > pmic_glink_con1_ss: endpoint { > - remote-endpoint = <&mdss0_dp1_out>; > + remote-endpoint = <&usb_1_qmpphy_out>; > }; > }; > > @@ -412,7 +412,7 @@ &mdss0_dp0 { > > &mdss0_dp0_out { > data-lanes = <0 1>; > - remote-endpoint = <&pmic_glink_con0_ss>; > + remote-endpoint = <&usb_0_qmpphy_dp_in>; > }; > > &mdss0_dp1 { > @@ -421,7 +421,7 @@ &mdss0_dp1 { > > &mdss0_dp1_out { > data-lanes = <0 1>; > - remote-endpoint = <&pmic_glink_con1_ss>; > + remote-endpoint = <&usb_1_qmpphy_dp_in>; > }; > > &mdss0_dp3 { > @@ -670,9 +670,19 @@ &usb_0_qmpphy { > vdda-phy-supply = <&vreg_l9d>; > vdda-pll-supply = <&vreg_l4d>; > > + orientation-switch; I believe this belongs in the SoC DTSI, as it's supported by the PHY block itself The rest seems to lgtm.. On a note, why did we end up placing pmic_glink in device DTs? It's already assumed that we're using the full Qualcomm stack as we use PAS for remoteprocs so I *think* we can always assume pmic_glink would be there! Konrad > + > status = "okay"; > }; > > +&usb_0_qmpphy_dp_in { > + remote-endpoint = <&mdss0_dp0_out>; > +}; > + > +&usb_0_qmpphy_out { > + remote-endpoint = <&pmic_glink_con0_ss>; > +}; > + > &usb_0_role_switch { > remote-endpoint = <&pmic_glink_con0_hs>; > }; > @@ -697,9 +707,19 @@ &usb_1_qmpphy { > vdda-phy-supply = <&vreg_l4b>; > vdda-pll-supply = <&vreg_l3b>; > > + orientation-switch; > + > status = "okay"; > }; > > +&usb_1_qmpphy_dp_in { > + remote-endpoint = <&mdss0_dp1_out>; > +}; > + > +&usb_1_qmpphy_out { > + remote-endpoint = <&pmic_glink_con1_ss>; > +}; > + > &usb_1_role_switch { > remote-endpoint = <&pmic_glink_con1_hs>; > }; > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 0e691bb0120c..1eb3a295e8fa 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -3006,6 +3006,23 @@ usb_0_qmpphy: phy@88eb000 { > #phy-cells = <1>; > > status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + usb_0_qmpphy_out: endpoint {}; > + }; > + > + port@1 { > + reg = <1>; > + > + usb_0_qmpphy_dp_in: endpoint {}; > + }; > + }; > }; > > usb_1_hsphy: phy@8902000 { > @@ -3042,6 +3059,23 @@ usb_1_qmpphy: phy@8903000 { > #phy-cells = <1>; > > status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + usb_1_qmpphy_out: endpoint {}; > + }; > + > + port@1 { > + reg = <1>; > + > + usb_1_qmpphy_dp_in: endpoint {}; > + }; > + }; > }; > > mdss1_dp0_phy: phy@8909a00 {