From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Cc: Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Hongliang Wang <wanghongliang@loongson.cn>
Subject: Re: [PATCH v5 4/7] LoongArch: dts: DeviceTree for Loongson-2K0500
Date: Tue, 19 Dec 2023 16:37:08 +0100 [thread overview]
Message-ID: <aa9cec3e-ee58-4d52-a8ec-d696e3ff70ca@linaro.org> (raw)
In-Reply-To: <303e56cb6e5f82623babe18b095069b330cd37da.1702862778.git.zhoubinbin@loongson.cn>
On 18/12/2023 02:52, Binbin Zhou wrote:
> Add DeviceTree file for Loongson-2K0500 processor, which integrates one
> 64-bit dual emission superscalar LA264 processor core.
>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> arch/loongarch/boot/dts/Makefile | 2 +
> .../boot/dts/loongson-2k0500-ref.dts | 89 ++++++
> arch/loongarch/boot/dts/loongson-2k0500.dtsi | 274 ++++++++++++++++++
> 3 files changed, 365 insertions(+)
> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> create mode 100644 arch/loongarch/boot/dts/loongson-2k0500.dtsi
>
> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile
> index 1e24cdb5180a..aa0b21d73d4e 100644
> --- a/arch/loongarch/boot/dts/Makefile
> +++ b/arch/loongarch/boot/dts/Makefile
> @@ -1,3 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> +dtb-$(CONFIG_MACH_LOONGSON64) = loongson-2k0500-ref.dtb
> +
> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .dtb.o, $(CONFIG_BUILTIN_DTB_NAME))
> diff --git a/arch/loongarch/boot/dts/loongson-2k0500-ref.dts b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> new file mode 100644
> index 000000000000..52483127a419
> --- /dev/null
> +++ b/arch/loongarch/boot/dts/loongson-2k0500-ref.dts
> @@ -0,0 +1,89 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2023 Loongson Technology Corporation Limited
> + */
> +
> +/dts-v1/;
> +
> +#include "loongson-2k0500.dtsi"
> +
> +/ {
> + compatible = "loongson,ls2k0500-ref", "loongson,ls2k0500";
> + model = "Loongson-2K0500 Reference Board";
> +
> + aliases {
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> + serial0 = &uart0;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + bootargs = "console=ttyS0,115200";
You received here comments already:
https://lore.kernel.org/all/3543cbf9-d259-8d0f-e78e-d8d5e3f501de@linaro.org/
Don't waste our time to re-review the same mistakes over and over again.
...
> +
> + i2c@1ff4a800 {
> + compatible = "loongson,ls2k-i2c";
> + reg = <0x0 0x1ff4a800 0x0 0x0800>;
> + interrupt-parent = <&eiointc>;
> + interrupts = <19>;
> + status = "disabled";
> + };
> +
> + pmc: power-management@1ff6c000 {
> + compatible = "loongson,ls2k0500-pmc", "syscon";
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Or you did not test your DTS on the hardware.
> + reg = <0x0 0x1ff6c000 0x0 0x58>;
> + interrupt-parent = <&eiointc>;
> + interrupts = <56>;
> + loongson,suspend-address = <0x0 0x1c000500>;
> +
> + syscon-reboot {
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-19 15:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 1:52 [PATCH v5 0/7] LoongArch: Add built-in dtb support Binbin Zhou
2023-12-18 1:52 ` [PATCH v5 1/7] dt-bindings: loongarch: Add CPU bindings for LoongArch Binbin Zhou
2023-12-18 1:52 ` [PATCH v5 2/7] dt-bindings: loongarch: Add Loongson SoC boards compatibles Binbin Zhou
2023-12-18 1:52 ` [PATCH v5 3/7] LoongArch: Allow device trees to be built into the kernel Binbin Zhou
2023-12-18 1:52 ` [PATCH v5 4/7] LoongArch: dts: DeviceTree for Loongson-2K0500 Binbin Zhou
2023-12-19 15:37 ` Krzysztof Kozlowski [this message]
2023-12-20 9:17 ` Binbin Zhou
2023-12-20 10:29 ` Krzysztof Kozlowski
2023-12-21 11:40 ` Binbin Zhou
2023-12-19 16:05 ` Conor Dooley
2023-12-20 9:45 ` Binbin Zhou
2023-12-18 1:52 ` [PATCH v5 5/7] LoongArch: dts: DeviceTree for Loongson-2K1000 Binbin Zhou
2023-12-19 15:37 ` Krzysztof Kozlowski
2023-12-19 16:18 ` Conor Dooley
2023-12-18 1:53 ` [PATCH v5 6/7] LoongArch: dts: DeviceTree for Loongson-2K2000 Binbin Zhou
2023-12-19 15:38 ` Krzysztof Kozlowski
2023-12-18 1:53 ` [PATCH v5 7/7] LoongArch: Parsing CPU-related information from DTS Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9cec3e-ee58-4d52-a8ec-d696e3ff70ca@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=loongarch@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).