From: "Nuno Sá" <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Andy Shevchenko <andy@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip
Date: Wed, 29 Nov 2023 09:56:17 +0100 [thread overview]
Message-ID: <aa9d45b7c7a21fa818f79d249536c461b2dcac9c.camel@gmail.com> (raw)
In-Reply-To: <d4a9bd79-1cb6-4da6-9380-bb8085866533@kernel.org>
On Wed, 2023-11-29 at 09:45 +0100, Krzysztof Kozlowski wrote:
> On 29/11/2023 09:35, Nuno Sá wrote:
> > On Tue, 2023-11-28 at 10:03 -0800, Guenter Roeck wrote:
> > > On 11/28/23 08:50, Krzysztof Kozlowski wrote:
> > > > On 27/11/2023 17:03, Andy Shevchenko wrote:
> > > > > On Mon, Nov 27, 2023 at 09:12:14AM +0100, Krzysztof Kozlowski wrote:
> > > > > > On 27/11/2023 09:10, Krzysztof Kozlowski wrote:
> > > > >
> > > > > ...
> > > > >
> > > > > > Wait, this was not even unusual test, just standard compile, which means
> > > > > > you did not do basic tests on your end. You must build your new driver
> > > > > > with W=1, smatch, sparse and coccinelle before sending upstream.
> > > > >
> > > > > Well, sparse is lagging in development, for the last year it's at least two
> > > > > times it broke kernel builds because of being not ready for the new stuff
> > > > > used
> > > > > in the kernel. Do we have anybody to sync this? I don't think so, hence
> > > > > requiring this from developer is doubtful. Otherwise I agree, that basic
> > > > > compilation with GCC/LLVM must be done.
> > > >
> > > > Sparse still detects several issues and handles lock annotations, so it
> > > > is useful. But if you disagree with that part, I still insist on Smatch
> > > > (which is actively developed and works great) and Coccinelle (also
> > > > actively developed).
> > > >
> > >
> > > Quite frankly, for my part I would be more than happy if people would read
> > > and follow Documentation/hwmon/submitting-patches.rst. Most submitters don't
> > > bother. That doesn't even mention building with W=1 (the much more optimistic
> > > me who wrote that document several years ago thought that would be obvious),
> > > much less running any source code analysis tools . Feel free to submit a patch
> > > to strengthen the wording there. If you do that, it would have to be more
> > > explicit
> > > then "run smatch" or "run coccinelle" because hardly anyone would know how
> > > to do that.
> > >
> >
> > IMO, submitting patches to linux is already not the most straightforward thing in
> > the
>
> True...
>
> > world. If we are now going to ask to run smatch, cocci, sparse and so on, we will
> > scare even more developers from the community... I mean, the bots are also in
> > place
>
> This is not related to Linux at all. When you develop any C or C++ code,
> you run these tools. Upstream or downstream, does not matter. Why would
> you not use automated, free and easy tools to detect errors in your
> code? It's just a matter of professional approach to your code.
>
That's true but still are too many things to remember for every single change/driver
one sends upstream. Yeah, I might just wrap b4 in a script to run more advanced
checks on my patches before 'send'.
> > to help with these kind of more advanced analysis, right?
>
> They do not come for free (someone is paying for them even if they are
> for free to you) and they have delays in responses.
>
Yeah, but actually thanks to you, I discovered I can have my private branches covered
by lkp (and I got the PR merged already) and I do not mind having 1/2 day delay for
sending patches. So maybe that will help me avoid these kind of mistakes.
- Nuno Sá
>
next prev parent reply other threads:[~2023-11-29 8:56 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 14:18 [PATCH v2 0/2] Add support for LTC4282 Nuno Sa via B4 Relay
2023-11-24 14:18 ` [PATCH v2 1/2] dt-bindings: hwmon: Add LTC4282 bindings Nuno Sa via B4 Relay
2023-11-25 11:56 ` Conor Dooley
2023-11-27 7:56 ` Nuno Sá
2023-11-27 17:33 ` Conor Dooley
2023-11-28 15:37 ` Rob Herring
2023-11-28 15:49 ` Nuno Sá
2023-11-24 14:18 ` [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip Nuno Sa via B4 Relay
2023-11-24 21:54 ` kernel test robot
2023-11-24 23:39 ` kernel test robot
2023-11-27 7:53 ` Nuno Sá
2023-11-27 8:10 ` Krzysztof Kozlowski
2023-11-27 8:12 ` Krzysztof Kozlowski
2023-11-27 8:44 ` Nuno Sá
2023-11-27 16:03 ` Andy Shevchenko
2023-11-28 16:50 ` Krzysztof Kozlowski
2023-11-28 17:01 ` Andy Shevchenko
2023-11-28 18:03 ` Guenter Roeck
2023-11-29 8:35 ` Nuno Sá
2023-11-29 8:45 ` Krzysztof Kozlowski
2023-11-29 8:56 ` Nuno Sá [this message]
2023-11-29 14:10 ` Linus Walleij
2023-11-29 14:13 ` Krzysztof Kozlowski
2023-11-29 14:29 ` Nuno Sá
2023-11-29 14:47 ` Guenter Roeck
2023-11-29 16:09 ` Nuno Sá
2023-11-27 10:20 ` kernel test robot
2023-11-29 14:49 ` Linus Walleij
2023-11-29 16:08 ` Nuno Sá
2023-11-29 16:18 ` Andy Shevchenko
2023-11-29 16:21 ` Nuno Sá
2023-11-29 17:07 ` Andy Shevchenko
2023-11-29 20:55 ` Linus Walleij
2023-11-30 10:20 ` Nuno Sá
2023-11-30 13:36 ` Andy Shevchenko
2023-11-30 14:39 ` Guenter Roeck
2023-11-30 15:20 ` Nuno Sá
2023-11-30 16:28 ` Guenter Roeck
2023-11-30 20:15 ` Linus Walleij
2023-12-01 12:34 ` Nuno Sá
2023-12-01 13:40 ` Linus Walleij
2023-12-01 15:24 ` Nuno Sá
2023-12-01 15:47 ` Andy Shevchenko
2023-12-01 16:04 ` Guenter Roeck
2023-12-01 16:24 ` Andy Shevchenko
2023-12-01 16:36 ` Guenter Roeck
2023-12-01 16:29 ` Nuno Sá
2023-12-01 16:46 ` Guenter Roeck
2023-12-02 9:42 ` Nuno Sá
2023-12-03 23:08 ` Linus Walleij
2023-12-04 8:20 ` Bartosz Golaszewski
2023-12-01 16:19 ` Nuno Sá
2023-12-01 16:23 ` Andy Shevchenko
2023-12-03 23:03 ` Linus Walleij
2023-12-04 8:53 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa9d45b7c7a21fa818f79d249536c461b2dcac9c.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=devnull+nuno.sa.analog.com@kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).