From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hja4Dj3K" Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E7F01707; Wed, 29 Nov 2023 00:56:20 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-54afd43c83cso6796955a12.0; Wed, 29 Nov 2023 00:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701248179; x=1701852979; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=UzC7u7XHPaOQqtUVRI8/zgc51khZ8nOUC/D9UTwFyWk=; b=Hja4Dj3KucQ5/88SDiGAEW9XWUECq2m1oaxqvra9RjH2QO795RaC9sVTuRJHUWKLAR H49Hrl4TqMdFO4WBilcl1rjPzD2WwOpntVK0gkEOxDxtwlwAMzVpLXcW5WkoeURZT87v 2Uz5jzvwO8IpOqYHxJLlZ4r55PA+v2doUAICLwXWuec6NyQI2mI0C3JeNuYl+FnPwhsb Oc2UlPwupg766KzdWATI6P1Qaw+LtFppCixXKN7GTIcEB8DCpdI0IsnV0qn/RIKsYOFx 3QeHTCQc8syEX/6XKBEqsZoGcLwGdBOCqmDPsJXcVKrglLMMfB8jcss9OVeRefs3GEA2 NO3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701248179; x=1701852979; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UzC7u7XHPaOQqtUVRI8/zgc51khZ8nOUC/D9UTwFyWk=; b=v4U0fmyRDtdlc6DMSjuhfMObJvRVn9jmJ+EybxPf/qk1+eViAAu/rQEDtNA1Adaa8Y G59l3dPCjl0hKSjcEtnhrTiysGpGzz55ibtw/tpG9P4nhjfu0Bc1FbaSUY5NIoU58wgl wvpY9DHigvim/DzFuED+vMO/XAlLzQibGXkmnpB2Vw2+/vH5wCA+Mhfo/V+AcVzzHtnK 2Hr6U23dqotg7juLkrToNT9fM66peuLbM5S/g8x87+ARBaOP2NPK5oscJRf6D4Slhmqp 2nJ6SEfp/WTVOTkcDnqxh5HcprDkrdu9vD9sJLroTlc3xMac/ZLZFm6MqUYsSkIbs9Dv ssgg== X-Gm-Message-State: AOJu0YySW5RhM3tLV8Aoszn3wlSHELuKD2MU4JItX5z+3QkAU46DsdEY 0N2HsSY7w0o5ktnDevzuIBU= X-Google-Smtp-Source: AGHT+IExjvaOkUK2FbCLNi1a2wfzeXF8TuA05XOy41Zpy+2YJf6EPwUMDERCJj1MJ0WGUTor4fDgQw== X-Received: by 2002:aa7:d805:0:b0:548:7a28:4df4 with SMTP id v5-20020aa7d805000000b005487a284df4mr10958769edq.15.1701248178697; Wed, 29 Nov 2023 00:56:18 -0800 (PST) Received: from ?IPv6:2001:a61:3456:4e01:6ae:b55a:bd1d:57fc? ([2001:a61:3456:4e01:6ae:b55a:bd1d:57fc]) by smtp.gmail.com with ESMTPSA id f11-20020a056402354b00b0054b59096da4sm3377724edd.13.2023.11.29.00.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 00:56:18 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip From: Nuno =?ISO-8859-1?Q?S=E1?= To: Krzysztof Kozlowski , Guenter Roeck , Andy Shevchenko Cc: kernel test robot , Nuno Sa via B4 Relay , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Jean Delvare , Rob Herring , Conor Dooley , Jonathan Corbet , Bartosz Golaszewski , Linus Walleij Date: Wed, 29 Nov 2023 09:56:17 +0100 In-Reply-To: References: <20231124-ltc4282-support-v2-2-952bf926f83c@analog.com> <202311250548.lUn3bm1A-lkp@intel.com> <76957975-56e7-489e-9c79-086b6c1ffe89@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2023-11-29 at 09:45 +0100, Krzysztof Kozlowski wrote: > On 29/11/2023 09:35, Nuno S=C3=A1 wrote: > > On Tue, 2023-11-28 at 10:03 -0800, Guenter Roeck wrote: > > > On 11/28/23 08:50, Krzysztof Kozlowski wrote: > > > > On 27/11/2023 17:03, Andy Shevchenko wrote: > > > > > On Mon, Nov 27, 2023 at 09:12:14AM +0100, Krzysztof Kozlowski wro= te: > > > > > > On 27/11/2023 09:10, Krzysztof Kozlowski wrote: > > > > >=20 > > > > > ... > > > > >=20 > > > > > > Wait, this was not even unusual test, just standard compile, wh= ich means > > > > > > you did not do basic tests on your end. You must build your new= driver > > > > > > with W=3D1, smatch, sparse and coccinelle before sending upstre= am. > > > > >=20 > > > > > Well, sparse is lagging in development, for the last year it's at= least two > > > > > times it broke kernel builds because of being not ready for the n= ew stuff > > > > > used > > > > > in the kernel. Do we have anybody to sync this? I don't think so,= hence > > > > > requiring this from developer is doubtful. Otherwise I agree, tha= t basic > > > > > compilation with GCC/LLVM must be done. > > > >=20 > > > > Sparse still detects several issues and handles lock annotations, s= o it > > > > is useful. But if you disagree with that part, I still insist on Sm= atch > > > > (which is actively developed and works great) and Coccinelle (also > > > > actively developed). > > > >=20 > > >=20 > > > Quite frankly, for my part I would be more than happy if people would= read > > > and follow Documentation/hwmon/submitting-patches.rst. Most submitter= s don't > > > bother. That doesn't even mention building with W=3D1 (the much more = optimistic > > > me who wrote that document several years ago thought that would be ob= vious), > > > much less running any source code analysis tools . Feel free to submi= t a patch > > > to strengthen the wording there. If you do that, it would have to be = more > > > explicit > > > then "run smatch" or "run coccinelle" because hardly anyone would kno= w how > > > to do that. > > >=20 > >=20 > > IMO, submitting patches to linux is already not the most straightforwar= d thing in > > the >=20 > True... >=20 > > world. If we are now going to ask to run smatch, cocci, sparse and so o= n, we will > > scare even more developers from the community... I mean, the bots are a= lso in > > place >=20 > This is not related to Linux at all. When you develop any C or C++ code, > you run these tools. Upstream or downstream, does not matter. Why would > you not use automated, free and easy tools to detect errors in your > code? It's just a matter of professional approach to your code. >=20 That's true but still are too many things to remember for every single chan= ge/driver one sends upstream. Yeah, I might just wrap b4 in a script to run more adva= nced checks on my patches before 'send'. > > to help with these kind of more advanced analysis, right? >=20 > They do not come for free (someone is paying for them even if they are > for free to you) and they have delays in responses. >=20 Yeah, but actually thanks to you, I discovered I can have my private branch= es covered by lkp (and I got the PR merged already) and I do not mind having 1/2 day d= elay for sending patches. So maybe that will help me avoid these kind of mistakes. - Nuno S=C3=A1 >=20