From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05D04410D00 for ; Mon, 2 Mar 2026 15:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772463918; cv=none; b=MnPd/lMwxEJqYBP6tS60RGIVNifbbalg0iM7HrJq8tFBUEgQxzHEhw+T4IHTxNyyOiFUgLF31SeUECs6iTxHOCc5vGgBEEsvA1fABwkihQDZxy7G2AwWT5U3nTv23cfkEvYEifF4ixavHOx8+XLYqA5u2beQdvt7VmMKWtdTaR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772463918; c=relaxed/simple; bh=f/zRpwRvcSPxPIVtLAeJTvEgGlEfU/E9fwUupa/pGtk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WQx4ReFbA8pGT4PRmk7g3TWbJrUnUN98m/fUElda7wx0jNPCVjagVPvShh0FPHR7NWgsyMHbeV+brw2d+wpGmPWnICbMV8xk0myJIGG34jhT3ynZdebC3uWnX4SKsStEyQIWxO0omYZ3xTm+uZEKm86/OJAheNRVSBicdVuGEDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EuqwgZjG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CYlyMCJ7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EuqwgZjG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CYlyMCJ7" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 622EltAs2048909 for ; Mon, 2 Mar 2026 15:05:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=D+Aknj82moTPuX8FsjTJUilr W2ttQjOLx9p2oQ6P6UY=; b=EuqwgZjGa83FW5Tf0uxbfGEv/U9IMlbvinoYq/He u11AYxxSiGQ4Piuu+4UfRAQVpVEdB2IhOKUXEFV3xPr36RYheoRF+VdQhFDC+zAE 5SE3Kn5hQd/EP8u9/1/kg4dBKJMRblRWReGMUgAhDNY2FfxFH1UVyqiPZ3yLDnXF WudZmODuu3P4myjOvlmFVs7RA0uYSsAyuCybi8nGPkvkRM0daODBRwVsPO4Hp0FT JTdPkWcPNKgpSP7BgPVaEzoc+9kQ5+CWMCiBwIk1l2prk5nVmXyQBS1oeKBovo60 P9Fz7xoee4V3JM5EGjYoQqmapohV//DFulOLOE44BSWNeA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cncmfr2ep-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 15:05:15 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-824a2df507eso15024172b3a.2 for ; Mon, 02 Mar 2026 07:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772463915; x=1773068715; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D+Aknj82moTPuX8FsjTJUilrW2ttQjOLx9p2oQ6P6UY=; b=CYlyMCJ7nmkYrYBufaPciG47CuJaUl9aa/wPqrCHhfgOZ2ICyG5l54iQ4Ys2IbwxaW +Ze3NKJfTwzQ4RhccHdWQy12wv5ekKOj+tV4APUZ02H4M1wAIRw4wtIMwnG/ETVhJb0r BT8PtvJfFMX7EUJulAnYzGDet0AOHo3PjMqlsdaUGOSbmOOq39b9xP/LjukUO43VFf1A DB4SZiIjYf5mDqD6g14datGMuW8MnPlpJEtRe0viCMRrhRIilVYMrCVvQu/cxl7NEXJb xn/fTQYq4OxusgH0Z09PcqcjoavDJeRSBwkbmRQa7wlXohr8QitcVnAoHcIRZp5MIyej /PDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772463915; x=1773068715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D+Aknj82moTPuX8FsjTJUilrW2ttQjOLx9p2oQ6P6UY=; b=AVbZ8Cfq6e95jHkZ/itxP4EeYEPh8lqsgE1nuVrx+PqGn1oSXRpywu40tMb2DvWpoQ cpFSmSJZZuabOM8yRb+pBECqHILxUeMkd4j5EB0wRpiQ1lGpXKQLezRXgDmrW9FsEyG7 b8I8THcTBQafsT2g37SG09nc7MZTUT79w1DcDmSoXvNELulMLd4CcXPCXs2Fuv7Bi08g Q+vYTCoqytLoMgHsH7UXIYLhk0BIYNUlhcSfAEmKYqdyu/hc1qNow8oj/8Y0i6PQvVT1 C/D2j1ieFqw+a6vBOOFOa8a2rUqn4+rWeldh18c3Mj1VcBh9vIeZXSgK3W/P/IwLNuib lMsQ== X-Forwarded-Encrypted: i=1; AJvYcCUjEJk0S14Eoc06tvicBeHs5t7qggBwmwdvhiLrANfX/I+9+WB5hRzg2yjBvHTyd8hvkWekO5e+j5OD@vger.kernel.org X-Gm-Message-State: AOJu0YyhaO9XrZqk6UfZovwRZZFWIrxkB5q1wTEHZ6l5te2KdKTu2S8d eirVLIh2GcibsTJ9C/c2H92vxeJnSluZDsJMV1iZkmgRqU8D5+1vGnZsM+QV2t4OllAoW3mW0zF hSjovoVg7vzOMxW1lINrn7dnfYHqxypOzdUxvE1QxDugOxtUrK4zOzTwvrK/CxN1D X-Gm-Gg: ATEYQzxNry3co3VPZHWySyDwms2JviPkNAk5B55A4CnTMZy8Hz1Ho38+zdU39Wz3vTP PLvhV1zgy7FIYLeuw/iKZpthRDAIYW8h0/PlDFruSP5+oqq6jNSItOPUVFFx5lR5DuY2xQlZEhw Arty5f57wEhbfYsL9q/6aMV/MFD7RMjIoP3cU92gBY6m5OpLXCFbOhzsJR7WguKzNBnqhJraXGG Rd3LK6ctwnzC19GDGqKmghK1shN9RQsZKtbaInQ1l41Q8DGmN8w05NvElFa4xuMJ/H5tsy1YsLU GRn1l9gccr15mm80KcTi+SZS/2muNOb2jOIJC3V+fpyLUN18S/pctwwgFheFUWtFdQVbI1D3wOI dc4Kdobv/7CdQyeYxUB7KB2gdMmnsuYwKiCKoBBWvskFQPeD/4k5sn0Q2 X-Received: by 2002:a05:6a00:9086:b0:81f:4ce8:d641 with SMTP id d2e1a72fcca58-8274d9d9b91mr13793390b3a.37.1772463914654; Mon, 02 Mar 2026 07:05:14 -0800 (PST) X-Received: by 2002:a05:6a00:9086:b0:81f:4ce8:d641 with SMTP id d2e1a72fcca58-8274d9d9b91mr13793304b3a.37.1772463913407; Mon, 02 Mar 2026 07:05:13 -0800 (PST) Received: from hu-mchunara-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d8805esm14087128b3a.16.2026.03.02.07.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 07:05:12 -0800 (PST) Date: Mon, 2 Mar 2026 20:35:06 +0530 From: Monish Chunara To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mani@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sarthak.garg@oss.qualcomm.com, pradeep.pragallapati@oss.qualcomm.com, nitin.rawat@oss.qualcomm.com Subject: Re: [PATCH 0/3] arm64: dts: qcom: monaco: Enable SDHCI storage support Message-ID: References: <20260227105055.2364348-1-monish.chunara@oss.qualcomm.com> <3insznroqfkpgdspe4wj3nrxgp4igeoyawr5udscpfi66m4kmc@brssmf6olu6g> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3insznroqfkpgdspe4wj3nrxgp4igeoyawr5udscpfi66m4kmc@brssmf6olu6g> X-Authority-Analysis: v=2.4 cv=Br+QAIX5 c=1 sm=1 tr=0 ts=69a5a72b cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=7VzX_CqY3rlGch63vwIA:9 a=CjuIK1q_8ugA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: BPhlwb1c39uV1dqCB5xbuGWljSFBL9xJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDEyNiBTYWx0ZWRfX8xHYT0juSh8d yQThAVtpLNwIFYLfIQdQlmdhCTdU92Luj9KVQYCVNmenIcZEAghY2X2QuSatAroSfXNvz4/TGQ1 lLueLaztDmxY0EJE/MrT6ysp/4XUfkI4JTWRQax+/k+TBA9h2mJRaJsXtg0Bjtzbdh2oE83Lhg9 89168rNXsBDmdspHxH09dxxHn5e/7xXP8GOfvmOgIvJPMtf0ZNbtbc0BKUOuFhEa0v9+t0QV0qK rAJyFha4Q3WxP2l/dKmWEAV1t1WYuSOXP0wJTqptAC9CaATbVX4aOndb1yTxdNDa/qOatDWPAFS rYtlwNOgCirBxAqb3Sr/hRzLMbzB2v/q8IhVzRnGLfdT9//ELb8t/nFLV5Spf4lzBaRNML5Z76j Kn3R6qE3UBQnT2Fi1y0AWPS4QLxLGKZpVamIxXfL4/R9ANMSSrDzWqhtndRhyNh28ef9w+Rcpr2 hIwgmAiZwAUACOewHLw== X-Proofpoint-GUID: BPhlwb1c39uV1dqCB5xbuGWljSFBL9xJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_03,2026-03-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020126 On Mon, Mar 02, 2026 at 04:47:41PM +0200, Dmitry Baryshkov wrote: > On Mon, Mar 02, 2026 at 08:07:23PM +0530, Monish Chunara wrote: > > On Fri, Feb 27, 2026 at 10:05:32PM +0200, Dmitry Baryshkov wrote: > > > On Fri, Feb 27, 2026 at 04:20:52PM +0530, Monish Chunara wrote: > > > > This series enables SDHCI storage support for both SD Card and eMMC on the > > > > Qualcomm Monaco EVK platform. > > > > > > > > The Monaco SoC shares the SDHCI controller between SD Card and eMMC use > > > > cases. Previously, the common SoC dtsi unconditionally enabled the > > > > 'supports-cqe' property. This causes regression for SD cards, resulting > > > > in timeouts and initialization failures during the probe sequence, as > > > > the driver attempts to enable Command Queueing (CQE) logic incompatible > > > > with the SD protocol. > > > > > > > > To resolve this and enable full storage support, this series: > > > > > > > > 1. Moves the 'supports-cqe' property out of the common SoC dtsi. It is > > > > now only enabled in the specific eMMC configuration where it is > > > > supported. > > > > 2. Adds a device tree overlay to enable SD Card support (SDR/DDR modes). > > > > 3. Adds a device tree overlay to enable eMMC support. This configuration > > > > also explicitly disables the UFS controller to prevent power leakage, > > > > as the VCC regulator is shared between the UFS and eMMC rails on this > > > > platform. > > > > > > > > Validated on Qualcomm Monaco EVK with both SD Card and eMMC modules. > > > > > > > > Monish Chunara (3): > > > > arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT > > > > arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay > > > > arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC via overlay > > > > > > You are adding two overlays. But what does it mean? Does EVK has no uSD > > > / eMMC at all, having both attachable via some kind of mezzanine? Is one > > > of them attachable? Or are both cases present onboard with the correct > > > one being selected by the DIP switch? > > > > > > > The monaco EVK has both storage devices present onboard and the desired one is > > selected via a DIP switch. The overlay selection logic would be based on a > > fitImage metadata entry that gets populated at UEFI level by determining the > > currently selected storage device (eMMC/SD) on the device. > > > > Hence, this approach becomes robust to enable the user for using either of the > > two mediums, without any additional requirement of reflashing any images. > > You are answering a different question :-) > > Let me formulate my question as a review comment: > - identify the default DIP switch position > - squash corresponding dtso into the dts > - leave only the default dts and non-default dtso to be applied by UEFI > if necessary. > Thanks for clarifying. Default switch position is on eMMC on Monaco EVK. But as mentioned in the other thread, there are a few boolean (flag) properties like 'no-sd', that conflicts with SD card use case and cannot be deleted in an overlay file as /delete-property/ cannot be used. Also cd-gpio and regulators used for SD card would be redundant for eMMC. And similarly 'no-mmc' added by default would be inappropriate for eMMC. This being the reason, two separate overlays were added. Regards, Monish