[PATCH v2] dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding

[PATCH v2] dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding

[Soham Metha]

The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in
commit aff0a1701b020c8e6b172f28828fd4f3e6eed41a
("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").

Update the reference to point to the new file.

Signed-off-by: Soham Metha <sohammetha01@gmail.com>
---
 .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
index 463a97c11eff..91f0a3b0c0b2 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
+++ b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
@@ -66,7 +66,7 @@ The following are the mandatory properties:
 - kick-gpios: 		Should specify the gpio device needed for the virtio IPC
 			stack. This will be used to interrupt the remote processor.
 			The gpio device to be used is as per the bindings in,
-			Documentation/devicetree/bindings/gpio/gpio-dsp-keystone.txt
+			Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml
 
 SoC-specific Required properties:
 ---------------------------------
-- 
2.34.1

Re: [PATCH v2] dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding

[Krzysztof Kozlowski]

On 03/12/2025 19:03, Soham Metha wrote:
> The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in
> commit aff0a1701b020c8e6b172f28828fd4f3e6eed41a

Did you actually read what I asked? I think you just sent it too fast to
be able to read entire multi-page document. If you read it, you would
see that abbrev is 12 characters/digits.

> ("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").
> 
> Update the reference to point to the new file.

This wasn't here before, no need to add obvious statements.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding

[Soham Metha]

Thank you for the feedback.

On 04/12/25 00:05, Krzysztof Kozlowski wrote:
> On 03/12/2025 19:03, Soham Metha wrote:
>> The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in
>> commit aff0a1701b020c8e6b172f28828fd4f3e6eed41a
> 
> Did you actually read what I asked? I think you just sent it too fast to
> be able to read entire multi-page document. If you read it, you would
> see that abbrev is 12 characters/digits.
> 

I did see the documentation mention that the abbreviation should use 
at least 12 characters, but I didn’t notice any upper limit mentioned 
in the text. Because of this wording, I assumed longer values were 
acceptable.

Should I send a v3 with a 12-character abbreviation?

>> ("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").
>>
>> Update the reference to point to the new file.
> 
> This wasn't here before, no need to add obvious statements.
> 
> Best regards,
> Krzysztof

--
Soham

Re: [PATCH v2] dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding

[Krzysztof Kozlowski]

On 03/12/2025 19:56, Soham Metha wrote:
> Thank you for the feedback.
> 
> On 04/12/25 00:05, Krzysztof Kozlowski wrote:
>> On 03/12/2025 19:03, Soham Metha wrote:
>>> The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in
>>> commit aff0a1701b020c8e6b172f28828fd4f3e6eed41a
>>
>> Did you actually read what I asked? I think you just sent it too fast to
>> be able to read entire multi-page document. If you read it, you would
>> see that abbrev is 12 characters/digits.
>>
> 
> I did see the documentation mention that the abbreviation should use 
> at least 12 characters, but I didn’t notice any upper limit mentioned 
> in the text. Because of this wording, I assumed longer values were 
> acceptable.
> 
> Should I send a v3 with a 12-character abbreviation?

No need, this is just a nit.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: remoteproc: Fix dead link to Keystone DSP GPIO binding

[Mathieu Poirier]

On Wed, Dec 03, 2025 at 11:33:37PM +0530, Soham Metha wrote:
> The old text binding 'gpio-dsp-keystone.txt' was replaced by a DT schema in
> commit aff0a1701b020c8e6b172f28828fd4f3e6eed41a
> ("dt-bindings: gpio: Convert ti,keystone-dsp-gpio to DT schema").
> 
> Update the reference to point to the new file.
> 
> Signed-off-by: Soham Metha <sohammetha01@gmail.com>
> ---
>  .../devicetree/bindings/remoteproc/ti,keystone-rproc.txt        | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied.

Thanks,
Mathieu
 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
> index 463a97c11eff..91f0a3b0c0b2 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt
> @@ -66,7 +66,7 @@ The following are the mandatory properties:
>  - kick-gpios: 		Should specify the gpio device needed for the virtio IPC
>  			stack. This will be used to interrupt the remote processor.
>  			The gpio device to be used is as per the bindings in,
> -			Documentation/devicetree/bindings/gpio/gpio-dsp-keystone.txt
> +			Documentation/devicetree/bindings/gpio/ti,keystone-dsp-gpio.yaml
>  
>  SoC-specific Required properties:
>  ---------------------------------
> -- 
> 2.34.1
>