From: "Verma, Achal" <a-verma1@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Achal Verma <a-verma1@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j7200: correct num-lanes requested for PCIe
Date: Tue, 16 May 2023 21:54:03 +0530 [thread overview]
Message-ID: <aad0e90c-bc5f-a6d0-3114-570d990cffbc@ti.com> (raw)
In-Reply-To: <20230516131323.3empqp5btdzfarjx@curliness>
On 5/16/2023 6:43 PM, Nishanth Menon wrote:
> On 11:52-20230516, Achal Verma wrote:
>> From: Matt Ranostay <mranostay@ti.com>
>>
>> J7200 has a limited 2x support for PCIe, and the properties should be
>> updated as such.
>>
>
> What commit does this fix?
This patch is a mistake.
J7200 PCIe has 4 lanes, and this patch should be dropped.
Regards,
Achal Verma
>
>> Signed-off-by: Matt Ranostay <mranostay@ti.com>
>> Signed-off-by: Achal Verma <a-verma1@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
>> index ef352e32f19d..5e62b431d6e8 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
>> @@ -729,7 +729,7 @@ pcie1_rc: pcie@2910000 {
>> device_type = "pci";
>> ti,syscon-pcie-ctrl = <&scm_conf 0x4074>;
>> max-link-speed = <3>;
>> - num-lanes = <4>;
>> + num-lanes = <2>;
>> power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
>> clocks = <&k3_clks 240 6>;
>> clock-names = "fck";
>> @@ -757,7 +757,7 @@ pcie1_ep: pcie-ep@2910000 {
>> interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
>> ti,syscon-pcie-ctrl = <&scm_conf 0x4074>;
>> max-link-speed = <3>;
>> - num-lanes = <4>;
>> + num-lanes = <2>;
>> power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
>> clocks = <&k3_clks 240 6>;
>> clock-names = "fck";
>> --
>> 2.25.1
>>
>
>
prev parent reply other threads:[~2023-05-16 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 6:22 [PATCH] arm64: dts: ti: k3-j7200: correct num-lanes requested for PCIe Achal Verma
2023-05-16 6:33 ` Siddharth Vadapalli
2023-05-16 9:01 ` Verma, Achal
2023-05-16 13:13 ` Nishanth Menon
2023-05-16 16:24 ` Verma, Achal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aad0e90c-bc5f-a6d0-3114-570d990cffbc@ti.com \
--to=a-verma1@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).