From: pheragu@codeaurora.org
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Manu Gautam <mgautam@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ckadabi@codeaurora.org, tsoni@codeaurora.org,
rnayak@codeaurora.org, bryanh@codeaurora.org,
psodagud@codeaurora.org,
Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
Subject: Re: [PATCH v2 2/2] Embedded USB Debugger (EUD) driver
Date: Tue, 11 Sep 2018 13:40:19 -0700 [thread overview]
Message-ID: <aade97184ee5027ac6e32fd742cfbc5a@codeaurora.org> (raw)
In-Reply-To: <20180905111800.GA30003@kroah.com>
On 2018-09-05 04:18, Greg KH wrote:
> On Wed, Sep 05, 2018 at 03:01:26PM +0530, Manu Gautam wrote:
>> Hi,
>>
>>
>> On 9/5/2018 3:04 AM, Prakruthi Deepak Heragu wrote:
>> > Add support for control peripheral of EUD (Embedded USB Debugger) to
>> > listen to events such as USB attach/detach, charger enable/disable, pet
>> > EUD to indicate software is functional.
>> >
>> > Signed-off-by: Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
>> > Signed-off-by: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
>> > ---
>> > drivers/soc/qcom/Kconfig | 12 ++
>> > drivers/soc/qcom/Makefile | 1 +
>> > drivers/soc/qcom/eud.c | 338 ++++++++++++++++++++++++++++++++++++++++++++++
>> > 3 files changed, 351 insertions(+)
>> > create mode 100644 drivers/soc/qcom/eud.c
>> >
>> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
>> [snip]
>> > +
>> > +#define EUD_ENABLE_CMD 1
>> > +#define EUD_DISABLE_CMD 0
>>
>> Why not use module param as boolean? I mean zero to disable and
>> non-zero to enable?
>
> Never use module parameters on new code, as it's really hard to ever
> change them. It also doesn't work for multiple devices of the same
> type.
>
If not for module_param, do you suggest we use sysfs? module_param also
provides a
facility to control these parameters through command line too. If we
can't use
module_param, do you expect us to use __setup(..) API?
> thanks,
>
> greg k-h
Regards,
Prakruthi Deepak Heragu
next prev parent reply other threads:[~2018-09-11 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 21:34 [PATCH v2 0/2] Add Embedded USB Debugger (EUD) driver Prakruthi Deepak Heragu
2018-09-04 21:34 ` [PATCH v2 1/2] dt-bindings: Documentation for qcom,eud Prakruthi Deepak Heragu
2018-09-25 19:25 ` Rob Herring
2019-12-27 13:00 ` Dwivedi, Avaneesh Kumar (avani)
2018-09-04 21:34 ` [PATCH v2 2/2] Embedded USB Debugger (EUD) driver Prakruthi Deepak Heragu
2018-09-05 9:31 ` Manu Gautam
2018-09-05 11:18 ` Greg KH
2018-09-11 20:40 ` pheragu [this message]
2018-09-12 6:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aade97184ee5027ac6e32fd742cfbc5a@codeaurora.org \
--to=pheragu@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=satyap@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).