* [PATCH v2] arm64: dts: qcom: Add definition for three LEDs.
@ 2023-11-10 2:06 Hui Liu via B4 Relay
2023-11-10 7:52 ` Krzysztof Kozlowski
2023-11-13 12:14 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Hui Liu via B4 Relay @ 2023-11-10 2:06 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_fenglinw,
quic_uchheda, kamalw, Hui Liu
From: Hui Liu <quic_huliu@quicinc.com>
Add definition for three LEDs to make sure they can
be enabled base on QCOM LPG LED driver.
Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
---
Changes in v2:
- Rephrased commit text and updated the nodes to board file.
- Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com
---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 2ff549f4dc7a..228e2aaeb861 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -7,6 +7,7 @@
#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
#include <dt-bindings/input/linux-event-codes.h>
+#include <dt-bindings/leds/common.h>
#include "sc7280.dtsi"
#include "pm7325.dtsi"
#include "pm8350c.dtsi"
@@ -365,6 +366,30 @@ vreg_bob: bob {
};
};
+&pm8350c_pwm {
+ status = "okay";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_RED>;
+ label = "red";
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_GREEN>;
+ label = "green";
+ };
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ label = "blue";
+ };
+};
+
&gpi_dma0 {
status = "okay";
};
---
base-commit: b9604be241587fb29c0f40450e53d0a37dc611b5
change-id: 20231108-qcom_leds-c3b0b7029008
Best regards,
--
Hui Liu <quic_huliu@quicinc.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: Add definition for three LEDs.
2023-11-10 2:06 [PATCH v2] arm64: dts: qcom: Add definition for three LEDs Hui Liu via B4 Relay
@ 2023-11-10 7:52 ` Krzysztof Kozlowski
2023-11-13 12:14 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-10 7:52 UTC (permalink / raw)
To: quic_huliu, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_fenglinw,
quic_uchheda, kamalw
On 10/11/2023 03:06, Hui Liu via B4 Relay wrote:
> From: Hui Liu <quic_huliu@quicinc.com>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
> ---
> Changes in v2:
> - Rephrased commit text and updated the nodes to board file.
> - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@quicinc.com
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 2ff549f4dc7a..228e2aaeb861 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -7,6 +7,7 @@
>
> #include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> #include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/leds/common.h>
> #include "sc7280.dtsi"
> #include "pm7325.dtsi"
> #include "pm8350c.dtsi"
> @@ -365,6 +366,30 @@ vreg_bob: bob {
> };
> };
>
> +&pm8350c_pwm {
> + status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_RED>;
> + label = "red";
Drop labels. You already have color, so you miss function.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: Add definition for three LEDs.
2023-11-10 2:06 [PATCH v2] arm64: dts: qcom: Add definition for three LEDs Hui Liu via B4 Relay
2023-11-10 7:52 ` Krzysztof Kozlowski
@ 2023-11-13 12:14 ` Konrad Dybcio
2023-12-19 6:05 ` hui liu
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2023-11-13 12:14 UTC (permalink / raw)
To: quic_huliu, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_fenglinw,
quic_uchheda, kamalw
On 10.11.2023 03:06, Hui Liu via B4 Relay wrote:
> From: Hui Liu <quic_huliu@quicinc.com>
>
> Add definition for three LEDs to make sure they can
> be enabled base on QCOM LPG LED driver.
>
> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
> ---
> Changes in v2:
> - Rephrased commit text and updated the nodes to board file.
The title should still include it, so:
arm64: dts: qcom: sc7280-idp: Add ...
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: Add definition for three LEDs.
2023-11-13 12:14 ` Konrad Dybcio
@ 2023-12-19 6:05 ` hui liu
0 siblings, 0 replies; 4+ messages in thread
From: hui liu @ 2023-12-19 6:05 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_fenglinw,
quic_uchheda, kamalw
On 11/13/2023 8:14 PM, Konrad Dybcio wrote:
> On 10.11.2023 03:06, Hui Liu via B4 Relay wrote:
>> From: Hui Liu <quic_huliu@quicinc.com>
>>
>> Add definition for three LEDs to make sure they can
>> be enabled base on QCOM LPG LED driver.
>>
>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
>> ---
>> Changes in v2:
>> - Rephrased commit text and updated the nodes to board file.
> The title should still include it, so:
>
> arm64: dts: qcom: sc7280-idp: Add ...
Added patch 3 to update the description.
> Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-19 6:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-10 2:06 [PATCH v2] arm64: dts: qcom: Add definition for three LEDs Hui Liu via B4 Relay
2023-11-10 7:52 ` Krzysztof Kozlowski
2023-11-13 12:14 ` Konrad Dybcio
2023-12-19 6:05 ` hui liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).