* [PATCH v2 0/2] *** IT6505 driver read dt properties ***
@ 2022-09-29 1:44 allen
2022-09-29 1:44 ` [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen
0 siblings, 1 reply; 6+ messages in thread
From: allen @ 2022-09-29 1:44 UTC (permalink / raw)
Cc: Allen Chen, Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:DRM DRIVERS, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, open list
From: allen chen <allen.chen@ite.com.tw>
This series let driver can read properties from dt to restrict dp output
bandwidth.
allen chen (2):
dt-bindings: it6505: add properties to restrict output bandwidth
drm/bridge: add it6505 driver to read data-lanes and
max-pixel-clock-khz from dt
.../bindings/display/bridge/ite,it6505.yaml | 10 ++++++
drivers/gpu/drm/bridge/ite-it6505.c | 35 +++++++++++++++++--
2 files changed, 42 insertions(+), 3 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth 2022-09-29 1:44 [PATCH v2 0/2] *** IT6505 driver read dt properties *** allen @ 2022-09-29 1:44 ` allen 2022-09-29 8:40 ` Neil Armstrong 2022-09-29 9:03 ` Krzysztof Kozlowski 0 siblings, 2 replies; 6+ messages in thread From: allen @ 2022-09-29 1:44 UTC (permalink / raw) Cc: Allen Chen, Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list From: allen chen <allen.chen@ite.com.tw> Add properties to restrict dp output data-lanes and clock. Signed-off-by: Pin-Yen Lin <treapking@chromium.org> Signed-off-by: Allen Chen <allen.chen@ite.com.tw> --- .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml index 833d11b2303a..62b9f2192202 100644 --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml @@ -52,6 +52,14 @@ properties: maxItems: 1 description: extcon specifier for the Power Delivery + data-lanes: + maxItems: 1 + description: restrict the dp output data-lanes with value of 1-4 + + max-pixel-clock-khz: + maxItems: 1 + description: restrict max pixel clock + port: $ref: /schemas/graph.yaml#/properties/port description: A port node pointing to DPI host port node @@ -84,6 +92,8 @@ examples: pwr18-supply = <&it6505_pp18_reg>; reset-gpios = <&pio 179 1>; extcon = <&usbc_extcon>; + data-lanes = <2>; + max-pixel-clock-khz = <150000>; port { it6505_in: endpoint { -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth 2022-09-29 1:44 ` [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen @ 2022-09-29 8:40 ` Neil Armstrong 2022-10-05 6:19 ` allen.chen 2022-09-29 9:03 ` Krzysztof Kozlowski 1 sibling, 1 reply; 6+ messages in thread From: Neil Armstrong @ 2022-09-29 8:40 UTC (permalink / raw) To: allen Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Kenneth Hung, Jernej Skrabec, Krzysztof Kozlowski, Jau-Chih Tseng, David Airlie, open list:DRM DRIVERS, Neil Armstrong, open list, Robert Foss, Pin-yen Lin, Hermes Wu, Rob Herring, Laurent Pinchart, Andrzej Hajda, Jonas Karlman Hi, On 29/09/2022 03:44, allen wrote: > From: allen chen <allen.chen@ite.com.tw> > > Add properties to restrict dp output data-lanes and clock. > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw> > --- > .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > index 833d11b2303a..62b9f2192202 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > @@ -52,6 +52,14 @@ properties: > maxItems: 1 > description: extcon specifier for the Power Delivery > > + data-lanes: > + maxItems: 1 > + description: restrict the dp output data-lanes with value of 1-4 Can't you use the data-lanes property in the first port endpoint ? Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > + > + max-pixel-clock-khz: > + maxItems: 1 > + description: restrict max pixel clock New vendor specific properties should have the ite, prefix. > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: A port node pointing to DPI host port node > @@ -84,6 +92,8 @@ examples: > pwr18-supply = <&it6505_pp18_reg>; > reset-gpios = <&pio 179 1>; > extcon = <&usbc_extcon>; > + data-lanes = <2>; > + max-pixel-clock-khz = <150000>; > > port { > it6505_in: endpoint { Thanks, Neil ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth 2022-09-29 8:40 ` Neil Armstrong @ 2022-10-05 6:19 ` allen.chen 2022-10-05 7:11 ` neil.armstrong 0 siblings, 1 reply; 6+ messages in thread From: allen.chen @ 2022-10-05 6:19 UTC (permalink / raw) To: neil.armstrong Cc: devicetree, Kenneth.Hung, jernej.skrabec, krzysztof.kozlowski+dt, Jau-Chih.Tseng, airlied, dri-devel, narmstrong, linux-kernel, robert.foss, treapking, Hermes.Wu, robh+dt, Laurent.pinchart, andrzej.hajda, jonas Hi data-lanes is output configuration. Maybe it is not suitable to put data-lanes in input endpoint. extcon doesn't have output endpoint, so I don't know where to put is better. -----Original Message----- From: Neil Armstrong <neil.armstrong@linaro.org> Sent: Thursday, September 29, 2022 4:40 PM To: Allen Chen (陳柏宇) <allen.chen@ite.com.tw> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Jernej Skrabec <jernej.skrabec@gmail.com>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; David Airlie <airlied@linux.ie>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; Neil Armstrong <narmstrong@baylibre.com>; open list <linux-kernel@vger.kernel.org>; Robert Foss <robert.foss@linaro.org>; Pin-yen Lin <treapking@chromium.org>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Rob Herring <robh+dt@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Andrzej Hajda <andrzej.hajda@intel.com>; Jonas Karlman <jonas@kwiboo.se> Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth Hi, On 29/09/2022 03:44, allen wrote: > From: allen chen <allen.chen@ite.com.tw> > > Add properties to restrict dp output data-lanes and clock. > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw> > --- > .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > index 833d11b2303a..62b9f2192202 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > @@ -52,6 +52,14 @@ properties: > maxItems: 1 > description: extcon specifier for the Power Delivery > > + data-lanes: > + maxItems: 1 > + description: restrict the dp output data-lanes with value of 1-4 Can't you use the data-lanes property in the first port endpoint ? Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > + > + max-pixel-clock-khz: > + maxItems: 1 > + description: restrict max pixel clock New vendor specific properties should have the ite, prefix. > + > port: > $ref: /schemas/graph.yaml#/properties/port > description: A port node pointing to DPI host port node @@ -84,6 > +92,8 @@ examples: > pwr18-supply = <&it6505_pp18_reg>; > reset-gpios = <&pio 179 1>; > extcon = <&usbc_extcon>; > + data-lanes = <2>; > + max-pixel-clock-khz = <150000>; > > port { > it6505_in: endpoint { Thanks, Neil ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth 2022-10-05 6:19 ` allen.chen @ 2022-10-05 7:11 ` neil.armstrong 0 siblings, 0 replies; 6+ messages in thread From: neil.armstrong @ 2022-10-05 7:11 UTC (permalink / raw) To: allen.chen Cc: devicetree, Kenneth.Hung, jernej.skrabec, krzysztof.kozlowski+dt, Jau-Chih.Tseng, airlied, dri-devel, narmstrong, linux-kernel, robert.foss, treapking, Hermes.Wu, robh+dt, Laurent.pinchart, andrzej.hajda, jonas On 05/10/2022 08:19, allen.chen@ite.com.tw wrote: > Hi > > data-lanes is output configuration. Maybe it is not suitable to put data-lanes in input endpoint. > extcon doesn't have output endpoint, so I don't know where to put is better. Ok it wasn't clear enough Then rename the property to something more specific like: ite,dp-output-data-lane-count Use the same naming scheme for the other property: ite,dp-output-max-pixel-clock-khz Neil > > -----Original Message----- > From: Neil Armstrong <neil.armstrong@linaro.org> > Sent: Thursday, September 29, 2022 4:40 PM > To: Allen Chen (陳柏宇) <allen.chen@ite.com.tw> > Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Jernej Skrabec <jernej.skrabec@gmail.com>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; David Airlie <airlied@linux.ie>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; Neil Armstrong <narmstrong@baylibre.com>; open list <linux-kernel@vger.kernel.org>; Robert Foss <robert.foss@linaro.org>; Pin-yen Lin <treapking@chromium.org>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Rob Herring <robh+dt@kernel.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Andrzej Hajda <andrzej.hajda@intel.com>; Jonas Karlman <jonas@kwiboo.se> > Subject: Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth > > Hi, > > On 29/09/2022 03:44, allen wrote: >> From: allen chen <allen.chen@ite.com.tw> >> >> Add properties to restrict dp output data-lanes and clock. >> >> Signed-off-by: Pin-Yen Lin <treapking@chromium.org> >> Signed-off-by: Allen Chen <allen.chen@ite.com.tw> >> --- >> .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> index 833d11b2303a..62b9f2192202 100644 >> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml >> @@ -52,6 +52,14 @@ properties: >> maxItems: 1 >> description: extcon specifier for the Power Delivery >> >> + data-lanes: >> + maxItems: 1 >> + description: restrict the dp output data-lanes with value of 1-4 > > Can't you use the data-lanes property in the first port endpoint ? > > Look at Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > >> + >> + max-pixel-clock-khz: >> + maxItems: 1 >> + description: restrict max pixel clock > > New vendor specific properties should have the ite, prefix. > >> + >> port: >> $ref: /schemas/graph.yaml#/properties/port >> description: A port node pointing to DPI host port node @@ -84,6 >> +92,8 @@ examples: >> pwr18-supply = <&it6505_pp18_reg>; >> reset-gpios = <&pio 179 1>; >> extcon = <&usbc_extcon>; >> + data-lanes = <2>; >> + max-pixel-clock-khz = <150000>; >> >> port { >> it6505_in: endpoint { > > Thanks, > Neil ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth 2022-09-29 1:44 ` [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen 2022-09-29 8:40 ` Neil Armstrong @ 2022-09-29 9:03 ` Krzysztof Kozlowski 1 sibling, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-09-29 9:03 UTC (permalink / raw) To: allen Cc: Jau-Chih Tseng, Kenneth Hung, Hermes Wu, Pin-yen Lin, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, open list:DRM DRIVERS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On 29/09/2022 03:44, allen wrote: > From: allen chen <allen.chen@ite.com.tw> > > Add properties to restrict dp output data-lanes and clock. > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw> > --- > .../devicetree/bindings/display/bridge/ite,it6505.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > index 833d11b2303a..62b9f2192202 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > @@ -52,6 +52,14 @@ properties: > maxItems: 1 > description: extcon specifier for the Power Delivery > > + data-lanes: > + maxItems: 1 > + description: restrict the dp output data-lanes with value of 1-4 Where is the definition of this property? > + > + max-pixel-clock-khz: > + maxItems: 1 > + description: restrict max pixel clock This looks wrong. You do not use proper unit suffix (https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml), no vendor prefix, no type and weird maxItems like it was array. Is it coming from any other schema? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-05 7:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-29 1:44 [PATCH v2 0/2] *** IT6505 driver read dt properties *** allen 2022-09-29 1:44 ` [PATCH v2 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen 2022-09-29 8:40 ` Neil Armstrong 2022-10-05 6:19 ` allen.chen 2022-10-05 7:11 ` neil.armstrong 2022-09-29 9:03 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).