From: Cory Keitz <ckeitz@amazon.com>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] i2c: qcom-cci: Add DT property for SCL clock stretching
Date: Thu, 5 Mar 2026 15:01:42 -0800 [thread overview]
Message-ID: <aaoGonc1zcTMKCgE@bcd074ae11bb> (raw)
In-Reply-To: <CAFEp6-3ZuSOW4apj2Ww2DJ5_5Gw-CDXV_9Qc2=wW-JLP8Vbatg@mail.gmail.com>
On Thu, Mar 05, 2026 at 04:16:31PM +0100, Loic Poulain wrote:
> I'm not convinced this kind of hardware behaviour belongs in
> devicetree. As far as I understand, clock stretching is part of the
> I2C specification, and slaves are allowed to use it whenever they need
> additional time. Masters are therefore expected to tolerate
> stretching. Given that, why not enable it unconditionally in the
> driver? Is there any downside to doing so?
Fair point. I wasn't sure of implications across the platforms, so my
preference was to make the change opt-in to preserve behavior for
existing systems. This is probably an overly-cautious approach though.
I'm happy to submit a v2 that forces it on, and remove the new DT
binding.
Cory
next prev parent reply other threads:[~2026-03-05 23:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 14:40 [PATCH 0/2] i2c: qcom-cci: Add DT property for SCL clock stretching Cory Keitz via B4 Relay
2026-03-05 14:40 ` [PATCH 1/2] dt-bindings: i2c: qcom-cci: Document qcom,scl-stretch-enable property Cory Keitz via B4 Relay
2026-03-05 15:18 ` Krzysztof Kozlowski
2026-03-05 23:04 ` Cory Keitz
2026-03-05 14:40 ` [PATCH 2/2] i2c: qcom-cci: Add DT property for SCL clock stretching Cory Keitz via B4 Relay
2026-03-05 15:16 ` [PATCH 0/2] " Loic Poulain
2026-03-05 23:01 ` Cory Keitz [this message]
2026-03-11 13:18 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaoGonc1zcTMKCgE@bcd074ae11bb \
--to=ckeitz@amazon.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox