* [PATCH v3 0/3] Add wiko-chuppito devictree
@ 2026-03-01 22:29 Paul Adam via B4 Relay
2026-03-01 22:29 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Paul Adam via B4 Relay @ 2026-03-01 22:29 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio
Cc: devicetree, linux-kernel, linux-arm-msm,
~postmarketos/upstreaming, phone-devel, Paul Adam,
Krzysztof Kozlowski
Add bindings vor Wiko SAS and wiko-chuppito
which are used in the devicetree.
Then introduce an initial device tree for Wiko PULP 4G.
Includes support for:
- UART
- USB (no OTG)
- Internal storage
- MicroSD
- Volume keys + Power button
- Touchscreen
- Backlight
- Accelerometer: Invensense MPU6880
- Magnetometer: Asahi Kasei AK09911
- Hall sensor: Rohm BU52021HFV
- Proximity sensor
- Vibrator
- Earpiece
- Microphone 1
- Headphones
- Wifi
- Bluetooth
- GPU
Signed-off-by: Paul Adam <adamp@posteo.de>
---
Changes in v3:
- add a short description of the device to the patch adding the binding
- removed unused backlight pinctrl state
- readd gpio prefix for some nodes, instead remove it from the labels
- add newline before status properties
- reorder nodes alphabetically
- rename rmi4 node to touchscreen
- Link to v2:
https://lore.kernel.org/r/20260221-wiko-chuppito-v2-0-6336b1b12389@posteo.de
Changes in v2:
- changed company website link to wiko.com (which is just the chinese
version, changing the language redirects to wikomobile.com)
- fix minor dts styling issues
- drop gpio prefix for some nodes
- confirmed stk3310 to be correct
- remove l6: regulator-always-on
- remove gcc node
- Link to v1:
https://lore.kernel.org/r/20260215-wiko-chuppito-v1-0-9ee6b89606a0@posteo.de
---
Paul Adam (3):
dt-bindings: vendor-prefixes: add WIKO SAS
dt-bindings: arm: qcom: add wiko,chuppito compatible string
arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts | 356 +++++++++++++++++++++
4 files changed, 360 insertions(+)
---
base-commit: cee73b1e840c154f64ace682cb477c1ae2e29cc4
change-id: 20260215-wiko-chuppito-ae8af4843e67
Best regards,
--
Paul Adam <adamp@posteo.de>
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/3] dt-bindings: vendor-prefixes: add WIKO SAS 2026-03-01 22:29 [PATCH v3 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay @ 2026-03-01 22:29 ` Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay 2 siblings, 0 replies; 9+ messages in thread From: Paul Adam via B4 Relay @ 2026-03-01 22:29 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Paul Adam, Krzysztof Kozlowski From: Paul Adam <adamp@posteo.de> Wiko is a french smartphone company: https://wiko.com Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Paul Adam <adamp@posteo.de> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index edbce100cae4..187089eef983 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1819,6 +1819,8 @@ patternProperties: description: Wi2Wi, Inc. "^widora,.*": description: Beijing Widora Technology Co., Ltd. + "^wiko,.*": + description: Wiko SAS "^wiligear,.*": description: Wiligear, Ltd. "^willsemi,.*": -- 2.53.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string 2026-03-01 22:29 [PATCH v3 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay @ 2026-03-01 22:29 ` Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay 2 siblings, 0 replies; 9+ messages in thread From: Paul Adam via B4 Relay @ 2026-03-01 22:29 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Paul Adam, Krzysztof Kozlowski From: Paul Adam <adamp@posteo.de> Add a compatible for Wiko PULP 4G, a phone from 2015. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Paul Adam <adamp@posteo.de> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index d48c625d3fc4..c9525b61f8ff 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -186,6 +186,7 @@ properties: - samsung,serranove - thwc,uf896 - thwc,ufi001c + - wiko,chuppito - wingtech,wt86518 - wingtech,wt86528 - wingtech,wt88047 -- 2.53.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree 2026-03-01 22:29 [PATCH v3 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay @ 2026-03-01 22:29 ` Paul Adam via B4 Relay 2026-03-02 11:08 ` Konrad Dybcio 2026-03-05 9:47 ` Stephan Gerhold 2 siblings, 2 replies; 9+ messages in thread From: Paul Adam via B4 Relay @ 2026-03-01 22:29 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Paul Adam From: Paul Adam <adamp@posteo.de> Add an initial device tree for Wiko PULP 4G. Includes support for: - UART - USB (no OTG) - Internal storage - MicroSD - Volume keys + Power button - Touchscreen - Backlight - Accelerometer: Invensense MPU6880 - Magnetometer: Asahi Kasei AK09911 - Hall sensor: Rohm BU52021HFV - Proximity sensor - Vibrator - Earpiece - Microphone 1 - Headphones - Wifi - Bluetooth - GPU Signed-off-by: Paul Adam <adamp@posteo.de> --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts | 356 +++++++++++++++++++++ 2 files changed, 357 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index f80b5d9cf1e8..5a3a9a823503 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-rossa.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-uf896.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-ufi001c.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8916-wiko-chuppito.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86518.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86528.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb diff --git a/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts new file mode 100644 index 000000000000..dd56e1baeb4b --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts @@ -0,0 +1,356 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include "msm8916-pm8916.dtsi" +#include "msm8916-modem-qdsp6.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/pinctrl/qcom,pmic-mpp.h> + +/ { + model = "Wiko Pulp 4G"; + compatible = "wiko,chuppito", "qcom,msm8916"; + chassis-type = "handset"; + + aliases { + mmc0 = &sdhc_1; /* eMMC */ + mmc1 = &sdhc_2; /* SD card */ + serial0 = &blsp_uart2; + }; + + chosen { + stdout-path = "serial0"; + }; + + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pm8916_pwm 0 100000>; + brightness-levels = <0 255>; + num-interpolated-steps = <255>; + default-brightness-level = <255>; + enable-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&button_backlight_default>; + pinctrl-names = "default"; + }; + + gpio-hall-sensor { + compatible = "gpio-keys"; + pinctrl-0 = <&gpio_hall_sensor_default>; + pinctrl-names = "default"; + label = "Hall Effect Sensor"; + + event-hall-sensor { + label = "Hall Effect Sensor"; + gpios = <&tlmm 117 GPIO_ACTIVE_LOW>; + linux,input-type = <EV_SW>; + linux,code = <SW_LID>; + linux,can-disable; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + pinctrl-0 = <&gpio_keys_default>; + pinctrl-names = "default"; + label = "Buttons"; + + button-volume-up { + label = "Volume up"; + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + }; + }; + + usb_id: usb-id { + compatible = "linux,extcon-usb-gpio"; + id-gpios = <&tlmm 110 GPIO_ACTIVE_HIGH>; + pinctrl-0 = <&usb_id_default>; + pinctrl-names = "default"; + }; +}; + +&blsp_i2c2 { + status = "okay"; + + magnetometer@c { + compatible = "asahi-kasei,ak09911"; + reg = <0x0c>; + vdd-supply = <&pm8916_l17>; + vid-supply = <&pm8916_l6>; + reset-gpios = <&tlmm 120 GPIO_ACTIVE_LOW>; + pinctrl-0 = <&mag_reset_default>; + pinctrl-1 = <&mag_reset_suspend>; + pinctrl-names = "default", "suspend"; + mount-matrix = "1", "0", "0", + "0", "1", "0", + "0", "0", "1"; + }; + + proximity@48 { + compatible = "sensortek,stk3310"; + reg = <0x48>; + interrupts-extended = <&tlmm 113 IRQ_TYPE_EDGE_FALLING>; + pinctrl-0 = <&proximity_int_default>; + pinctrl-1 = <&proximity_int_suspend>; + pinctrl-names = "default", "suspend"; + }; + + imu@68 { + compatible = "invensense,mpu6880"; + reg = <0x68>; + interrupts-extended = <&tlmm 115 IRQ_TYPE_EDGE_FALLING>; + vdd-supply = <&pm8916_l17>; + vddio-supply = <&pm8916_l6>; + pinctrl-0 = <&imu_int_default>; + pinctrl-1 = <&imu_int_suspend>; + pinctrl-names = "default", "suspend"; + mount-matrix = "0", "-1", "0", + "-1", "0", "0", + "0", "0", "-1"; + }; +}; + +&blsp_i2c5 { + status = "okay"; + + touchscreen@39 { + compatible = "syna,rmi4-i2c"; + reg = <0x39>; + interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>; + vdd-supply = <&pm8916_l17>; + vio-supply = <&pm8916_l6>; + pinctrl-0 = <&touchscreen_default>; + pinctrl-1 = <&touchscreen_suspend>; + pinctrl-names = "default", "suspend"; + #address-cells = <1>; + #size-cells = <0>; + syna,startup-delay-ms = <100>; + syna,reset-delay-ms = <160>; + + rmi4-f01@1 { + reg = <0x1>; + syna,nosleep-mode = <1>; + }; + + rmi4-f11@11 { + reg = <0x11>; + syna,sensor-type = <1>; + }; + }; +}; + +&blsp_uart2 { + status = "okay"; +}; + +&gpu { + status = "okay"; +}; + +&mdss { + status = "okay"; +}; + +&mpss_mem { + reg = <0x0 0x86800000 0x0 0x5600000>; +}; + +&pm8916_codec { + qcom,hphl-jack-type-normally-open; +}; + +&pm8916_mpps { + pwm_out: mpp4-state { + pins = "mpp4"; + function = "digital"; + power-source = <PM8916_MPP_VPH>; + output-low; + qcom,dtest = <1>; + }; +}; + +&pm8916_pwm { + pinctrl-0 = <&pwm_out>; + pinctrl-names = "default"; + + status = "okay"; +}; + +&pm8916_resin { + linux,code = <KEY_VOLUMEDOWN>; + + status = "okay"; +}; + +&pm8916_rpm_regulators { + pm8916_l17: l17 { + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <2850000>; + regulator-always-on; + }; +}; + +&pm8916_vib { + status = "okay"; +}; + +&sdhc_1 { + status = "okay"; +}; + +&sdhc_2 { + pinctrl-0 = <&sdc2_default>, <&sdc2_cd_default>; + pinctrl-1 = <&sdc2_sleep>, <&sdc2_cd_default>; + pinctrl-names = "default", "sleep"; + cd-gpios = <&tlmm 38 GPIO_ACTIVE_HIGH>; + + status = "okay"; +}; + +&sound { + audio-routing = "AMIC1", "MIC BIAS Internal1", + "AMIC2", "MIC BIAS Internal2", + "AMIC3", "MIC BIAS Internal1"; +}; + +&tlmm { + button_backlight_default: button-backlight-default-state { + pins = "gpio119"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + gpio_hall_sensor_default: gpio-hall-sensor-default-state { + pins = "gpio117"; + function = "gpio"; + drive-strength = <6>; + bias-pull-up; + }; + + gpio_keys_default: gpio-keys-default-state { + pins = "gpio107"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; + + imu_int_default: imu-int-default-state { + pins = "gpio115"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + imu_int_suspend: imu-int-suspend-state { + pins = "gpio115"; + function = "gpio"; + drive-strength = <2>; + }; + + mag_reset_default: mag-reset-default-state { + pins = "gpio120"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + mag_reset_suspend: mag-reset-suspend-state { + pins = "gpio120"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + + proximity_int_default: proximity-int-default-state { + pins = "gpio113"; + function = "gpio"; + drive-strength = <6>; + bias-pull-up; + }; + + proximity_int_suspend: proximity-int-suspend-state { + pins = "gpio113"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + + sdc2_cd_default: sdc2-cd-default-state { + pins = "gpio38"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + + touchscreen_default: touchscreen-default-state { + touchscreen-pins { + pins = "gpio13"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; + + reset-pins { + pins = "gpio12"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + }; + + touchscreen_suspend: touchscreen-suspend-state { + touchscreen-pins { + pins = "gpio13"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + + reset-pins { + pins = "gpio12"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + }; + + usb_id_default: usb-id-default-state { + pins = "gpio110"; + function = "gpio"; + drive-strength = <8>; + bias-pull-up; + }; +}; + +&usb { + extcon = <&usb_id>, <&usb_id>; + + status = "okay"; +}; + +&usb_hs_phy { + extcon = <&usb_id>; +}; + +&venus { + status = "okay"; +}; + +&venus_mem { + status = "okay"; +}; + +&wcnss { + status = "okay"; +}; + +&wcnss_iris { + compatible = "qcom,wcn3620"; +}; + +&wcnss_mem { + status = "okay"; +}; -- 2.53.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree 2026-03-01 22:29 ` [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay @ 2026-03-02 11:08 ` Konrad Dybcio 2026-03-04 22:14 ` Paul Adam 2026-03-05 9:47 ` Stephan Gerhold 1 sibling, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2026-03-02 11:08 UTC (permalink / raw) To: adamp, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel On 3/1/26 11:29 PM, Paul Adam via B4 Relay wrote: > From: Paul Adam <adamp@posteo.de> > > Add an initial device tree for Wiko PULP 4G. > Includes support for: > - UART > - USB (no OTG) > - Internal storage > - MicroSD > - Volume keys + Power button > - Touchscreen > - Backlight > - Accelerometer: Invensense MPU6880 > - Magnetometer: Asahi Kasei AK09911 > - Hall sensor: Rohm BU52021HFV > - Proximity sensor > - Vibrator > - Earpiece > - Microphone 1 > - Headphones > - Wifi > - Bluetooth > - GPU > > Signed-off-by: Paul Adam <adamp@posteo.de> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree 2026-03-02 11:08 ` Konrad Dybcio @ 2026-03-04 22:14 ` Paul Adam 2026-03-05 8:28 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Paul Adam @ 2026-03-04 22:14 UTC (permalink / raw) To: Konrad Dybcio Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel On 26/03/02 12:08, Konrad Dybcio wrote: > On 3/1/26 11:29 PM, Paul Adam via B4 Relay wrote: > > From: Paul Adam <adamp@posteo.de> > > > > Add an initial device tree for Wiko PULP 4G. > > Includes support for: > > - UART > > - USB (no OTG) > > - Internal storage > > - MicroSD > > - Volume keys + Power button > > - Touchscreen > > - Backlight > > - Accelerometer: Invensense MPU6880 > > - Magnetometer: Asahi Kasei AK09911 > > - Hall sensor: Rohm BU52021HFV > > - Proximity sensor > > - Vibrator > > - Earpiece > > - Microphone 1 > > - Headphones > > - Wifi > > - Bluetooth > > - GPU > > > > Signed-off-by: Paul Adam <adamp@posteo.de> > > --- > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > > Konrad Thanks for reviewing! I assume I resend this once more with your tag added? Also is there anything else I need to do, if I don't receive further suggestions? Paul ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree 2026-03-04 22:14 ` Paul Adam @ 2026-03-05 8:28 ` Konrad Dybcio 0 siblings, 0 replies; 9+ messages in thread From: Konrad Dybcio @ 2026-03-05 8:28 UTC (permalink / raw) To: Paul Adam Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel On 3/4/26 11:14 PM, Paul Adam wrote: > On 26/03/02 12:08, Konrad Dybcio wrote: >> On 3/1/26 11:29 PM, Paul Adam via B4 Relay wrote: >>> From: Paul Adam <adamp@posteo.de> >>> >>> Add an initial device tree for Wiko PULP 4G. >>> Includes support for: >>> - UART >>> - USB (no OTG) >>> - Internal storage >>> - MicroSD >>> - Volume keys + Power button >>> - Touchscreen >>> - Backlight >>> - Accelerometer: Invensense MPU6880 >>> - Magnetometer: Asahi Kasei AK09911 >>> - Hall sensor: Rohm BU52021HFV >>> - Proximity sensor >>> - Vibrator >>> - Earpiece >>> - Microphone 1 >>> - Headphones >>> - Wifi >>> - Bluetooth >>> - GPU >>> >>> Signed-off-by: Paul Adam <adamp@posteo.de> >>> --- >> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> >> Konrad > > Thanks for reviewing! > > I assume I resend this once more with your tag added? No need, the maintainer tooling (b4) grabs tags whilst applying > Also is there anything else I need to do, if I don't receive further > suggestions? Nope, just wait! Konrad ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree 2026-03-01 22:29 ` [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay 2026-03-02 11:08 ` Konrad Dybcio @ 2026-03-05 9:47 ` Stephan Gerhold 2026-03-07 17:20 ` Paul Adam 1 sibling, 1 reply; 9+ messages in thread From: Stephan Gerhold @ 2026-03-05 9:47 UTC (permalink / raw) To: adamp Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel On Sun, Mar 01, 2026 at 11:29:19PM +0100, Paul Adam via B4 Relay wrote: > From: Paul Adam <adamp@posteo.de> > > Add an initial device tree for Wiko PULP 4G. > Includes support for: > - UART > - USB (no OTG) > - Internal storage > - MicroSD > - Volume keys + Power button > - Touchscreen > - Backlight > - Accelerometer: Invensense MPU6880 > - Magnetometer: Asahi Kasei AK09911 > - Hall sensor: Rohm BU52021HFV > - Proximity sensor > - Vibrator > - Earpiece > - Microphone 1 > - Headphones > - Wifi > - Bluetooth > - GPU > > Signed-off-by: Paul Adam <adamp@posteo.de> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts | 356 +++++++++++++++++++++ > 2 files changed, 357 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index f80b5d9cf1e8..5a3a9a823503 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-rossa.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-uf896.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-thwc-ufi001c.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8916-wiko-chuppito.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86518.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt86528.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts > new file mode 100644 > index 000000000000..dd56e1baeb4b > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts > @@ -0,0 +1,356 @@ > [...] > +&blsp_i2c2 { > + status = "okay"; > + > + magnetometer@c { > + compatible = "asahi-kasei,ak09911"; > + reg = <0x0c>; > + vdd-supply = <&pm8916_l17>; > + vid-supply = <&pm8916_l6>; > + reset-gpios = <&tlmm 120 GPIO_ACTIVE_LOW>; > + pinctrl-0 = <&mag_reset_default>; > + pinctrl-1 = <&mag_reset_suspend>; > + pinctrl-names = "default", "suspend"; Did you mean "sleep" instead of "suspend" here? By default, there is "default", "init", "idle" and "sleep" [1], although drivers can request custom pinctrl states as well. Note that even with "sleep", the pinctrl state will be rarely used on Linux. Drivers need to explicitly call pinctrl_pm_select_sleep_state() to trigger these, but only few drivers do that [2]. From a quick look, I suspect that only the &sdhc_2 sleep pinctrl here is currently used on Linux. That doesn't mean that you can't add these pinctrl states (the DT is not supposed to be specific to one particular operating system), but it does mean that most of these are effectively untested right now. I would personally omit them. [1]: https://elixir.bootlin.com/linux/v7.0-rc1/source/include/linux/pinctrl/pinctrl-state.h#L36 [2]: https://elixir.bootlin.com/linux/v7.0-rc1/A/ident/pinctrl_pm_select_sleep_state > + mount-matrix = "1", "0", "0", > + "0", "1", "0", > + "0", "0", "1"; > + }; > + > + proximity@48 { > + compatible = "sensortek,stk3310"; > + reg = <0x48>; > + interrupts-extended = <&tlmm 113 IRQ_TYPE_EDGE_FALLING>; > + pinctrl-0 = <&proximity_int_default>; > + pinctrl-1 = <&proximity_int_suspend>; > + pinctrl-names = "default", "suspend"; Same here. > + }; > + > + imu@68 { > + compatible = "invensense,mpu6880"; > + reg = <0x68>; > + interrupts-extended = <&tlmm 115 IRQ_TYPE_EDGE_FALLING>; > + vdd-supply = <&pm8916_l17>; > + vddio-supply = <&pm8916_l6>; > + pinctrl-0 = <&imu_int_default>; > + pinctrl-1 = <&imu_int_suspend>; > + pinctrl-names = "default", "suspend"; And here. > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; > + > +&blsp_i2c5 { > + status = "okay"; > + > + touchscreen@39 { > + compatible = "syna,rmi4-i2c"; > + reg = <0x39>; > + interrupts-extended = <&tlmm 13 IRQ_TYPE_EDGE_FALLING>; > + vdd-supply = <&pm8916_l17>; > + vio-supply = <&pm8916_l6>; > + pinctrl-0 = <&touchscreen_default>; > + pinctrl-1 = <&touchscreen_suspend>; > + pinctrl-names = "default", "suspend"; And here. > + #address-cells = <1>; > + #size-cells = <0>; > + syna,startup-delay-ms = <100>; > + syna,reset-delay-ms = <160>; > + > + rmi4-f01@1 { > + reg = <0x1>; > + syna,nosleep-mode = <1>; > + }; > + > + rmi4-f11@11 { > + reg = <0x11>; > + syna,sensor-type = <1>; > + }; > + }; > +}; > + > [...] > +&pm8916_rpm_regulators { > + pm8916_l17: l17 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2850000>; > + regulator-always-on; Does this need to be always-on? > + }; > +}; > + > [...] > +&sdhc_2 { > + pinctrl-0 = <&sdc2_default>, <&sdc2_cd_default>; > + pinctrl-1 = <&sdc2_sleep>, <&sdc2_cd_default>; > + pinctrl-names = "default", "sleep"; This is OK, drivers/mmc/host/sdhci-msm.c selects the sleep state. > + cd-gpios = <&tlmm 38 GPIO_ACTIVE_HIGH>; > + > + status = "okay"; > +}; > [...] > +&tlmm { > [...] > + imu_int_default: imu-int-default-state { > + pins = "gpio115"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + imu_int_suspend: imu-int-suspend-state { > + pins = "gpio115"; > + function = "gpio"; > + drive-strength = <2>; > + }; imu_int_default has a bias, but imu_int_suspend does not, is this intended? I would just drop these "suspend" states, as I mentioned above. Thanks, Stephan ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree 2026-03-05 9:47 ` Stephan Gerhold @ 2026-03-07 17:20 ` Paul Adam 0 siblings, 0 replies; 9+ messages in thread From: Paul Adam @ 2026-03-07 17:20 UTC (permalink / raw) To: Stephan Gerhold Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, devicetree, linux-kernel, linux-arm-msm, ~postmarketos/upstreaming, phone-devel On 26/03/05 10:47, Stephan Gerhold wrote: > Did you mean "sleep" instead of "suspend" here? By default, there is > "default", "init", "idle" and "sleep" [1], although drivers can request > custom pinctrl states as well. > > Note that even with "sleep", the pinctrl state will be rarely used on > Linux. Drivers need to explicitly call pinctrl_pm_select_sleep_state() > to trigger these, but only few drivers do that [2]. From a quick look, > I suspect that only the &sdhc_2 sleep pinctrl here is currently used on > Linux. > > That doesn't mean that you can't add these pinctrl states (the DT is not > supposed to be specific to one particular operating system), but it does > mean that most of these are effectively untested right now. I would > personally omit them. > > [1]: https://elixir.bootlin.com/linux/v7.0-rc1/source/include/linux/pinctrl/pinctrl-state.h#L36 > [2]: https://elixir.bootlin.com/linux/v7.0-rc1/A/ident/pinctrl_pm_select_sleep_state Thanks, I will remove them. [...] > Does this need to be always-on? Still works without, will take it out. Paul ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-03-07 17:20 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-01 22:29 [PATCH v3 0/3] Add wiko-chuppito devictree Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: add WIKO SAS Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 2/3] dt-bindings: arm: qcom: add wiko,chuppito compatible string Paul Adam via B4 Relay 2026-03-01 22:29 ` [PATCH v3 3/3] arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Paul Adam via B4 Relay 2026-03-02 11:08 ` Konrad Dybcio 2026-03-04 22:14 ` Paul Adam 2026-03-05 8:28 ` Konrad Dybcio 2026-03-05 9:47 ` Stephan Gerhold 2026-03-07 17:20 ` Paul Adam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox