From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jain, Harsh (AECG-SSW)" <h.jain@amd.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Botcha, Mounika" <Mounika.Botcha@amd.com>,
"Savitala, Sarat Chand" <sarat.chand.savitala@amd.com>,
"Dhanawade, Mohan" <mohan.dhanawade@amd.com>,
"Simek, Michal" <michal.simek@amd.com>,
"smueller@chronox.de" <smueller@chronox.de>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: crypto: Add node for True Random Number Generator
Date: Thu, 24 Jul 2025 10:08:38 +0200 [thread overview]
Message-ID: <ab0294da-1ae3-434c-aa37-75532e538e56@linaro.org> (raw)
In-Reply-To: <DS0PR12MB9345EDA907BB0438C32EF12F975EA@DS0PR12MB9345.namprd12.prod.outlook.com>
On 24/07/2025 10:04, Jain, Harsh (AECG-SSW) wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Thursday, July 24, 2025 12:52 PM
>> To: Jain, Harsh (AECG-SSW) <h.jain@amd.com>; herbert@gondor.apana.org.au;
>> davem@davemloft.net; linux-crypto@vger.kernel.org; devicetree@vger.kernel.org;
>> Botcha, Mounika <Mounika.Botcha@amd.com>; Savitala, Sarat Chand
>> <sarat.chand.savitala@amd.com>; Dhanawade, Mohan
>> <mohan.dhanawade@amd.com>; Simek, Michal <michal.simek@amd.com>;
>> smueller@chronox.de; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Subject: Re: [PATCH v4 1/3] dt-bindings: crypto: Add node for True Random
>> Number Generator
>>
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> On 23/07/2025 20:21, Harsh Jain wrote:
>>> From: Mounika Botcha <mounika.botcha@amd.com>
>>>
>>> Add TRNG node compatible string and reg properities.
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Why did you placed my tag here?
>
> You shared Reviewed-by on v3. It’s the same patch. Isn't I am supposed to add it in subsequent patches if there is not change?
>
> https://lore.kernel.org/linux-crypto/20250617-rational-benign-woodpecker-6ee31a@kuoka/
And who sent the patch? Who received the tag? Why the tag is above
existing SoB chain?
>
>>
>>> Signed-off-by: Mounika Botcha <mounika.botcha@amd.com>
>>> Signed-off-by: Harsh Jain <h.jain@amd.com>
>>
>> Who received the tag? When was the patch prepared?
>
> Did I missed something here?
Yes, using standard tools for the job - b4 - or following the process
if you do not want to use the tools.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-24 8:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 18:21 [PATCH v4 0/3] crypto: Add Versal TRNG driver Harsh Jain
2025-07-23 18:21 ` [PATCH v4 1/3] dt-bindings: crypto: Add node for True Random Number Generator Harsh Jain
2025-07-24 7:21 ` Krzysztof Kozlowski
2025-07-24 8:04 ` Jain, Harsh (AECG-SSW)
2025-07-24 8:08 ` Krzysztof Kozlowski [this message]
2025-07-24 9:22 ` Jain, Harsh (AECG-SSW)
2025-07-23 18:21 ` [PATCH v4 2/3] crypto: xilinx: Add TRNG driver for Versal Harsh Jain
2025-07-23 18:21 ` [PATCH v4 3/3] crypto: drbg: Export CTR DRBG DF functions Harsh Jain
2025-08-16 8:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0294da-1ae3-434c-aa37-75532e538e56@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Mounika.Botcha@amd.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=h.jain@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mohan.dhanawade@amd.com \
--cc=robh@kernel.org \
--cc=sarat.chand.savitala@amd.com \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).