Re: [PATCH v1 8/8] arm64: dts: qcom: Add Microsoft Surface Pro 12in

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 5/11/26 4:40 PM, Harrison Vanderbyl wrote:
> Initial device tree for Microsoft Surface Pro 12in

[...]

> +	pmic-glink {
> +		compatible = "qcom,x1e80100-pmic-glink",
> +				 "qcom,sm8550-pmic-glink",
> +				 "qcom,pmic-glink";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> +					<&tlmm 123 GPIO_ACTIVE_HIGH>;

Please align the "s and <s


[...]

> +		va-dai-link {
> +			link-name = "VA Capture";
> +
> +			cpu {
> +				sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
> +			};
> +
> +			codec {
> +				sound-dai = <&lpass_vamacro 0>;
> +			};

'co'dec < 'cp'u

[...]

> +&mdss_dp3 {
> +	/delete-property/ #sound-dai-cells;
> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&edp0_hpd_default>;

Please make sure to keep this order, file-wide:

property-n
property-names

[...]

> +&ufs_mem_hc {
> +	status = "okay";

Let's keep status uniformly the last property, preceded by a \n

[...]

> +&usb_1_ss0 {
> +	status = "okay";
> +	dr_mode = "host";

You declared the Type-C ports as dual-role - does it work if you skip this bit?

Konrad