From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ayush Singh <ayushdevel1325@gmail.com>, greybus-dev@lists.linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, vaishnav@beagleboard.org,
jkridner@beagleboard.org, nm@ti.com,
krzysztof.kozlowski+dt@linaro.org, johan@kernel.org,
elder@kernel.org
Subject: Re: [PATCH v5 2/3] greybus: Add BeaglePlay Linux Driver
Date: Mon, 2 Oct 2023 15:51:22 +0200 [thread overview]
Message-ID: <ab06133b-10ee-4953-82ad-e6a6a2aaef9d@linaro.org> (raw)
In-Reply-To: <66fbd8d1-8b1a-50b5-c442-23847dc3d42f@gmail.com>
On 01/10/2023 20:13, Ayush Singh wrote:
>>>>> +};
>>>>> +MODULE_DEVICE_TABLE(of, gb_beagleplay_of_match);
>>>>> +
>>>>> +static struct serdev_device_driver gb_beagleplay_driver = {
>>>>> + .probe = gb_beagleplay_probe,
>>>>> + .remove = gb_beagleplay_remove,
>>>>> + .driver = {
>>>>> + .name = "gb_beagleplay",
>>>>> + .of_match_table = gb_beagleplay_of_match,
>>>> This is still wrongly aligned. Spaces after tab. Are you sure checkpatch
>>>> does not complain bout it?
>>> Again, it doesn't seem to for me. Am I missing some environment
>>> variables or options? Or maybe something wrong with my editor config
>>> (neovim)?
>> You have spaces after tab, so how can this be properly aligned?
>>
>> Best regards,
>> Krzysztof
>>
> So I just wanted to confirm, but I think spaces after tab are fine for
> alignment, right? I found this
> (https://www.mail-archive.com/kernelnewbies@kernelnewbies.org/msg13354.html)
> message in mailing list stating that it is fine.
Spaces after tab are fine *when needed* for proper alignment. You do not
have proper alignment here, so just drop them. Please open any other
existing driver (although not something old...).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-02 13:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 11:36 [PATCH v5 0/3] greybus: Add BeaglePlay Greybus Driver Ayush Singh
2023-09-24 11:36 ` [PATCH v5 1/3] dt-bindings: Add beagleplaycc1352 Ayush Singh
2023-09-24 12:00 ` Krzysztof Kozlowski
2023-09-24 12:22 ` Ayush Singh
2023-09-24 12:53 ` Krzysztof Kozlowski
2023-09-24 11:36 ` [PATCH v5 2/3] greybus: Add BeaglePlay Linux Driver Ayush Singh
2023-09-24 12:04 ` Krzysztof Kozlowski
2023-09-24 12:32 ` Ayush Singh
2023-09-24 12:55 ` Krzysztof Kozlowski
2023-09-24 13:08 ` Ayush Singh
2023-10-01 18:13 ` Ayush Singh
2023-10-02 13:51 ` Krzysztof Kozlowski [this message]
2023-09-24 11:36 ` [PATCH v5 3/3] dts: ti: k3-am625-beagleplay: Add beaglecc1352 Ayush Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab06133b-10ee-4953-82ad-e6a6a2aaef9d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ayushdevel1325@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jkridner@beagleboard.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=vaishnav@beagleboard.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).