From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>,
rafael@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, lukasz.luba@arm.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] dt-bindings: thermal: convert hisilicon-thermal.txt to dt-schema
Date: Fri, 14 Jun 2024 20:51:51 +0200 [thread overview]
Message-ID: <ab09447d-45be-4af9-9bf9-1debc9e5943c@gmail.com> (raw)
In-Reply-To: <afb7551e-404e-440b-92c5-6927c61417ab@kernel.org>
On 14/06/2024 10:49, Krzysztof Kozlowski wrote:
> On 14/06/2024 00:42, Abdulrasaq Lawani wrote:
>> Convert the hisilicon SoCs tsensor txt bindings to dt-schema
>>
>> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@gmail.com>
>> ---
>> Validated with dtschema and tested against `hi3660-hikey960.dts`
>>
>
>> + compatible = "hisilicon,tsensor";
>> + reg = <0x0 0xf7030700 0x0 0x1000>;
>
> Oh man... get this past your mentors first.
>
> 1. Messed indentation.
> 2. 0, unit address looks unnecessary.
>
Sorry Krzysztof, it seems that this conversion went "live" without a
preliminary review by the mentors. We will make sure that the first step
is not omitted for v2.
Best regards,
Javier Carrasco
prev parent reply other threads:[~2024-06-14 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 22:42 [PATCH] dt-bindings: thermal: convert hisilicon-thermal.txt to dt-schema Abdulrasaq Lawani
2024-06-14 8:49 ` Krzysztof Kozlowski
2024-06-14 18:51 ` Javier Carrasco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab09447d-45be-4af9-9bf9-1debc9e5943c@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=abdulrasaqolawani@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).