Re: [PATCH 1/5] soc/tegra: Update BPMP ABI header

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2549 bytes --]

On Fri, Mar 20, 2026 at 10:49:43AM +0100, Krzysztof Kozlowski wrote:
> On 20/03/2026 10:44, Krzysztof Kozlowski wrote:
> > On 20/03/2026 10:34, Thierry Reding wrote:
> >> On Thu, Mar 19, 2026 at 05:15:56PM +0100, Krzysztof Kozlowski wrote:
> >>> On 19/03/2026 17:01, Thierry Reding wrote:
> >>>> From: Thierry Reding <treding@nvidia.com>
> >>>>
> >>>> This update primarily adds various new commands and MRQs for Tegra264,
> >>>> but also contains a few new annotations and fixes.
> >>>>
> >>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
> >>>> ---
> >>>>  include/soc/tegra/bpmp-abi.h | 4565 +++++++++++++++++++++++++++-------
> >>>>  1 file changed, 3671 insertions(+), 894 deletions(-)
> >>>>
> >>>> diff --git a/include/soc/tegra/bpmp-abi.h b/include/soc/tegra/bpmp-abi.h
> >>>> index 39bb3f87e28d..6cf6442395f1 100644
> >>>> --- a/include/soc/tegra/bpmp-abi.h
> >>>> +++ b/include/soc/tegra/bpmp-abi.h
> >>>> @@ -1,6 +1,6 @@
> >>>> -/* SPDX-License-Identifier: GPL-2.0-only */
> >>>> +/* SPDX-License-Identifier: GPL-2.0 OR MIT */
> 
> I missed this part here - that's license change. This has like 10
> different authors, so you must be explicit about it in commit msg and
> you must get their acks.

I'm not a lawyer, but any non-NVIDIA contributions to this file were a
license header changes by Thomas and typofixes by a random assortment of
people. I don't think any of those changes qualify as copyrightable or
licensable.

> >>>>  /*
> >>>> - * Copyright (c) 2014-2022, NVIDIA CORPORATION.  All rights reserved.
> >>>> + * SPDX-FileCopyrightText: Copyright (c) 2014-2025, NVIDIA CORPORATION.  All rights reserved.
> >>>
> >>> You just replaced correct syntax with discouraged (as in not welcomed
> >>> upstream) SPDX tag.
> >>
> >> Fair enough, I'm dropping the tag. I didn't know it was actively
> >> discouraged and I don't see this documented anywhere. I suppose I should
> > 
> > I am trying to get it somehow documented as permissive, v4 is waiting
> > for some time.
> > 
> 
> ... feel free to encourage/review my change to get the tag officially
> supported.

I've never thought about it much, but now that I have I almost prefer
the variant without the tag. I guess if there were a usecase where
people wanted to extract the copyright from kernel sources for some
reason it might make some sense, though given the state of the kernel
that would require an awful lot of churn and it'd probably be easier
to just extract the data using regular expressions.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]