From: Jishnu Prakash <jprakash@codeaurora.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
smohanad@codeaurora.org, kgunda@codeaurora.org,
aghayal@codeaurora.org, Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-arm-msm@vger.kernel.org,
linux-iio <linux-iio@vger.kernel.org>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V4 5/5] iio: adc: Clean up ADC code common to PMIC5 and PMIC7
Date: Fri, 22 May 2020 17:29:13 +0530 [thread overview]
Message-ID: <ab1d038c-5ad0-4c3b-0537-6e6512432de3@codeaurora.org> (raw)
In-Reply-To: <CAHp75Vf-bFfrZ7uCOnXuzT+p+itkcmkE61=ezZzN8yDFQHABdw@mail.gmail.com>
Hi Andy,
On 5/13/2020 3:21 PM, Andy Shevchenko wrote:
> On Wed, May 13, 2020 at 12:24 PM Jishnu Prakash <jprakash@codeaurora.org> wrote:
>> This commit includes the following changes:
>> Add a common function used for read_raw callback for
>> both PMIC5 and PMIC7 ADCs.
>> Add exit function for ADC.
>> Add info_property under adc_data to more efficiently
>> distinguish PMIC5 and PMIC7 ADCs.
> Something happened to the editor settings. We have lines up to 72
> (recommended) characters.
In this case, I just meant to put each change on a different line. I'll
fix it in the next post.
>
> ...
>
>> @@ -512,6 +518,7 @@ static int adc5_read_raw(struct iio_dev *indio_dev,
>> &adc5_prescale_ratios[prop->prescale],
>> adc->data,
>> adc_code_volt, val);
>> +
>> if (ret)
>> return ret;
>>
> Unrelated.
I'll remove it in the next post.
>
prev parent reply other threads:[~2020-05-22 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 9:22 [PATCH V4 0/5] iio: adc: Add support for QCOM SPMI PMIC7 ADC Jishnu Prakash
2020-05-13 9:22 ` [PATCH V4 1/5] iio: adc: Convert the QCOM SPMI ADC bindings to .yaml format Jishnu Prakash
2020-05-18 7:25 ` Linus Walleij
2020-05-13 9:22 ` [PATCH V4 2/5] iio: adc: Add PMIC7 ADC bindings Jishnu Prakash
2020-05-13 9:22 ` [PATCH V4 3/5] iio: adc: Add support for PMIC7 ADC Jishnu Prakash
2020-05-13 9:48 ` Andy Shevchenko
2020-05-22 11:58 ` Jishnu Prakash
2020-05-22 15:31 ` Andy Shevchenko
2020-05-13 9:22 ` [PATCH V4 4/5] iio: adc: Update error checks and debug prints Jishnu Prakash
2020-05-13 9:49 ` Andy Shevchenko
2020-05-22 11:58 ` Jishnu Prakash
2020-05-13 9:22 ` [PATCH V4 5/5] iio: adc: Clean up ADC code common to PMIC5 and PMIC7 Jishnu Prakash
2020-05-13 9:51 ` Andy Shevchenko
2020-05-22 11:59 ` Jishnu Prakash [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab1d038c-5ad0-4c3b-0537-6e6512432de3@codeaurora.org \
--to=jprakash@codeaurora.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=aghayal@codeaurora.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=andy.shevchenko@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kgunda@codeaurora.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=pmeerw@pmeerw.net \
--cc=smohanad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).