From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F31E12594 for ; Thu, 28 Mar 2024 09:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711616876; cv=none; b=Q4PRZcPpYzn/me9H/Bc0waJ9FY6XYgaCe1yESSDs++QhawDQ8Z7XLdP++4GJiBgzOCAUUuShL0lCGzeX0VbTVTmqTVyNPTS+mA5qfIxguzJAnVPhVazPHIr6BeH2hUCJrIdDlvKEufrZR6eOHyqANxTdKKe52mNWDFN8zirNZRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711616876; c=relaxed/simple; bh=r07Cs5KLVKu0tASlS5/D4hIpCN56cfKcWsy0e5UUZQk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=a/gy/+VadDlcwu0Bhw4r54tPSrpzEBwkJwWbrAomednVPJlTi5TfnArilpMSFil0Ez/62hf4SuoiSQhDsybD7PQQujT/NfydiGYs9N8BauW4U3s7tW3PLu1TaEwLcMez/oHGWZt7hh1iXIT6gLJcaxrzS4+MEwgsSUQiAcVLcms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=chZdz0rP; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="chZdz0rP" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2d23114b19dso9203571fa.3 for ; Thu, 28 Mar 2024 02:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711616873; x=1712221673; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=yKXwHmc4cXcL+3XlaHJcygoE0sPqn2G65Y8JY5URJDs=; b=chZdz0rPXJUzdYHUXGX1+Tn54hZrjswXrlrLcfzv40119yQ693s8sTA84l1I0fEsRo cajI5SNFlgxDdD7Bif4X8MKJq60AqXYEAMn8yDCxM4exhqmaHOWA9S8ysK9lzXXW72s+ jKz3qn5LTjXJJqqvRWmHd3pzrrwdYSUMoRkeQ3r9ZOEsUOz2yOiJrIGbNkZ38DIwupC8 WjXo5xY+HVS5DTg117m7XBqnn6tFvBqR0yvkR0r/izJvmRI9Ak1Jr01v4jRXV3RjFgik +f7Qj+K8Wb24U98Y50bEE+NJ2Kjb9u/uMXMaDiee4DSz/oBQs2l5Qef2//mzbDKtpeHm F/Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711616873; x=1712221673; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yKXwHmc4cXcL+3XlaHJcygoE0sPqn2G65Y8JY5URJDs=; b=cjxATvqODWnKLXmWfsIPSjycFnx7MJWBY+1YHKrvIf0L7hEVSu14RfxUSKqvM73Kr/ GfIA4C1s1kZ0vz12rZrNAm0BHKfHAGUHzg7O1iC3JX9HEvFIRGc1AaGQ1fUJqMEjtwXF M2qIBVPRozKJSpK5BAHVId8U/PxoqgVKKI8p8EisAAHQwfK6EoV8pG8LHpSESYWwqmeT oNRhMxYsl2RgpdoTaMRm/QaC6mz8W1rbYfvs3hcRLjomuHBCgAwb2ajIV/KUOZBtRcI5 5EYh6MQ9+HHT+zinl2ueoMVcqxuX8CiaXma5vjUS39JTrwrxabAzD/v0ABppp72IDq1Z V0XQ== X-Forwarded-Encrypted: i=1; AJvYcCUuuJzHAorX1N/u/B6rXcpI9fULiJ62E0UqTrj7vFMcjpZplzutw5pTLTBlolCWd+FZNzl3os7KybEKcnXhELYY6D0VGLPEOVfsmA== X-Gm-Message-State: AOJu0Yx68GcJJrOpBsj89tEJN5Id/H9c5DiFuAaC+7auekV5VzfOB9f1 tA1VTtvmbgMliGpaUau/AfZj4CHsTogMlHgEXfVfahiH9N3rf5TJTDi1890+ELY= X-Google-Smtp-Source: AGHT+IFan8kG+r3iVU6A8LgXX5xHcdF5eGLJCwQMzUJRaJjaVzQi8QQwkp8heq/oAlpdTtpsfmu/wg== X-Received: by 2002:a2e:a40e:0:b0:2d6:ec7b:b69b with SMTP id p14-20020a2ea40e000000b002d6ec7bb69bmr1228173ljn.7.1711616873130; Thu, 28 Mar 2024 02:07:53 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:6306:1c7a:72c2:892a? ([2a01:e0a:982:cbb0:6306:1c7a:72c2:892a]) by smtp.gmail.com with ESMTPSA id hg6-20020a05600c538600b004148ff6ef54sm1622433wmb.29.2024.03.28.02.07.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 02:07:52 -0700 (PDT) Message-ID: Date: Thu, 28 Mar 2024 10:07:51 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH RESEND v6 0/5] spmi: pmic-arb: Add support for multiple buses To: Abel Vesa , Stephen Boyd , Matthias Brugger , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , AngeloGioacchino Del Regno , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Srini Kandagatla , Johan Hovold , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org References: <20240326-spmi-multi-master-support-v6-0-1c87d8306c5b@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240326-spmi-multi-master-support-v6-0-1c87d8306c5b@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Abel, On 26/03/2024 17:28, Abel Vesa wrote: > This RFC prepares for and adds support for 2 buses, which is supported > in HW starting with version 7. Until now, none of the currently > supported platforms in upstream have used the second bus. The X1E80100 > platform, on the other hand, needs the second bus for the USB2.0 to work > as there are 3 SMB2360 PMICs which provide eUSB2 repeaters and they are > all found on the second bus. @Dmitry, @Konrad, @Bjorn, could you apply those patches and test an devices you have to make sure there's no regression ? > > Signed-off-by: Abel Vesa > --- > Changes in v6: > - Changed the compatible to platform specific (X1E80100) along with the > schema. Fixed the spmi buses unit addresses and added the empty ranges > property. Added missing properties to the spmi buses and the > "unevaluatedProperties: false". > - Deprecated the "qcom,bus-id" in the legacy schema. > - Changed the driver to check for legacy compatible first > - Link to v5: https://lore.kernel.org/r/20240221-spmi-multi-master-support-v5-0-3255ca413a0b@linaro.org > > Changes in v5: > - Dropped the RFC as there aren't any concerns about the approach anymore > - Dropped the unused dev and res variables from pmic_arb_get_obsrvr_chnls_v2 > - Link to v4: https://lore.kernel.org/r/20240220-spmi-multi-master-support-v4-0-dc813c878ba8@linaro.org > > Changes in v4: > - Fixed comment above pmic_arb_init_apid_v7 by dropping the extra "bus" word > - Swicthed to devm_platform_ioremap_resource_byname for obsrvr and chnls. > The core remains with platform_get_resource_byname as we need the core size. > - Dropped comment from probe related to the need of platform_get_resource_byname > as it not true anymore. > - Dropped the qcom,bus-id optional property. > - Link to v3: https://lore.kernel.org/r/20240214-spmi-multi-master-support-v3-0-0bae0ef04faf@linaro.org > > Changes in v3: > - Split the change into 3 separate patches. First 2 patches are moving > apid init and core resources into version specific ops. Third one is > adding the support for 2 buses and dedicated compatible. > - Added separate bindings patch > - Link to v2: https://lore.kernel.org/r/20240213-spmi-multi-master-support-v2-1-b3b102326906@linaro.org > > Changes in v2: > - Reworked it so that it registers a spmi controller for each bus > rather than relying on the generic framework to pass on the bus > (master) id. > - Link to v1: https://lore.kernel.org/r/20240207-spmi-multi-master-support-v1-0-ce57f301c7fd@linaro.org > > --- > Abel Vesa (5): > dt-bindings: spmi: Add X1E80100 SPMI PMIC ARB schema > dt-bindings: spmi: Deprecate qcom,bus-id Forgot to add, but please fix this in a v7: > spmi: pmic-arb: Make the APID init a version operation drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:243: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:257: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' > spmi: pmic-arb: Make core resources acquiring a version operation drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:180: warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb' drivers/spmi/spmi-pmic-arb.c:222: warning: Function parameter or struct member 'get_core_resources' not described in 'pmic_arb_ver_ops' drivers/spmi/spmi-pmic-arb.c:244: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data' drivers/spmi/spmi-pmic-arb.c:258: warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data' > spmi: pmic-arb: Add multi bus support > > .../bindings/spmi/qcom,spmi-pmic-arb.yaml | 1 + > .../bindings/spmi/qcom,x1e80100-spmi-pmic-arb.yaml | 136 +++ > drivers/spmi/spmi-pmic-arb.c | 948 +++++++++++++-------- > 3 files changed, 715 insertions(+), 370 deletions(-) > --- > base-commit: 4893c639cc3659cefaa675bf1e59f4e7571afb5c > change-id: 20240207-spmi-multi-master-support-832a704b779b > > Best regards, Thanks, Neil