Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Add watchdog node

[Komal Bajaj <komal.bajaj@oss.qualcomm.com>]

On 9/29/2026 4:09 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt: incorrect node ordering in sm8750.dtsi
> --
>
> commit 807aba78b66c219c014d5a42b4b7964dbeb6b207
> Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>
> arm64: dts: qcom: sm8750: Add watchdog node
>      
> This commit adds a device tree node for the watchdog on the SM8750 SoC.
>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> index 8ed5fa4d24fcd..53125e5dc4cca 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> @@ -6006,6 +6006,13 @@ cpucp_mbox: mailbox@16430000 {
>>   			#mbox-cells = <1>;
>>   		};
>>   
>> +		watchdog@16410000 {
>> +			compatible = "qcom,apss-wdt-sm8750", "qcom,kpss-wdt";
>> +			reg = <0x0 0x16410000 0x0 0x1000>;
>> +			clocks = <&sleep_clk>;
>> +			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
>> +		};
>> +
> [Severity: Low]
> Does this placement break the ascending unit-address order convention for
> Device Tree files?
>
> The new watchdog@16410000 node is being placed immediately after the
> mailbox@16430000 node. Should this node be moved above the mailbox node to
> keep the children sorted numerically by their unit address?

I missed that. I will fix the node ordering in next version.

Thanks
Komal

>
>>   		apps_rsc: rsc@16500000 {
>>   			compatible = "qcom,rpmh-rsc";
>>   			reg = <0x0 0x16500000 0x0 0x10000>,