From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Kyle Hsieh <kylehsieh1995@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Beguin" <liambeguin@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio: adc: ltc2309: add support for ltc2305
Date: Wed, 11 Mar 2026 09:10:52 +0200 [thread overview]
Message-ID: <abEVfIKYZSl-AnL8@ashevche-desk.local> (raw)
In-Reply-To: <20260311-add_ltc2305_driver-v4-2-bc350d347f33@gmail.com>
On Wed, Mar 11, 2026 at 09:43:02AM +0800, Kyle Hsieh wrote:
> Add support for the 2-channel LTC2305 ADC in the existing LTC2309 driver.
> The LTC2305 and LTC2309 share similar features: both are 12-bit,
> low-noise, low-power SAR ADCs with an I2C interface.
> The main difference is the number of channels: LTC2305 has 2 channels,
> while LTC2309 has 8 channels.
...
> /* Order matches expected channel address, See datasheet Table 1. */
This comment now confusing, it should be kept at the initial enum, but the
better idea is...
> +enum ltc2305_channels {
> + LTC2305_CH0_CH1 = 0x0,
> + LTC2305_CH1_CH0 = 0x4,
> + LTC2305_CH0 = 0x8,
> + LTC2305_CH1 = 0xc,
> +};
> +
> enum ltc2309_channels {
> LTC2309_CH0_CH1 = 0,
> LTC2309_CH2_CH3,
...to assign proper values (in necessary order) explicitly and adjust comment.
Then add this patch on top.
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-11 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 1:43 [PATCH v4 0/2] iio: adc: ltc2309: add support driver for ltc2305 Kyle Hsieh
2026-03-11 1:43 ` [PATCH v4 1/2] dt-bindings: adc: ltc2497: add support " Kyle Hsieh
2026-03-11 1:43 ` [PATCH v4 2/2] iio: adc: ltc2309: " Kyle Hsieh
2026-03-11 7:10 ` Andy Shevchenko [this message]
2026-03-25 2:00 ` Kyle Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abEVfIKYZSl-AnL8@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kylehsieh1995@gmail.com \
--cc=lars@metafoo.de \
--cc=liambeguin@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox