From: Zichar Zhang <zichar.zhang@cixtech.com>
To: Linus Walleij <linusw@kernel.org>
Cc: brgl@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, peter.chen@cixtech.com,
fugang.duan@cixtech.com, jank@cadence.com,
cix-kernel-upstream@cixtech.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: gpio: cdns: add clock-names property
Date: Wed, 11 Mar 2026 20:08:36 +0800 [thread overview]
Message-ID: <abFbRA33DtDdZ2j+@ZicharPC> (raw)
In-Reply-To: <CAD++jLkueX=qU3OY3z=ANA9pd_irWjdf_Czc6RSctzr0MBftQQ@mail.gmail.com>
On Fri, Mar 06, 2026 at 11:10:35AM +0100, Linus Walleij wrote:
> [You don't often get email from linusw@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL
>
> Hi Zichar,
>
> On Fri, Mar 6, 2026 at 10:32 AM Zichar Zhang <zichar.zhang@cixtech.com> wrote:
>
> > + clock-names:
> > + description:
> > + Optional name for the GPIO controller input clock.
> > + minItems: 1
> > + maxItems: 1
>
> I think clock-names: true should suffice, but the binding maintainers
> can say how
> they want it.
>
> I would suggest to also add:
>
> gpio-ranges:
> minItems: 1
> maxItems: 32
>
> At this point even if you're not using it FTM. This will make it
> possible to later
> map the GPIOs to the pin controller and control pin configuration from the
> GPIO subsystem.
Thanks. Given that cdns,gpio.yaml already defines "ngpios", would it make
sense to use it for the "gpio-ranges" definition?
Best regards,
Zichar Zhang
next prev parent reply other threads:[~2026-03-11 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 9:32 [PATCH 1/2] dt-bindings: gpio: cdns: add clock-names property Zichar Zhang
2026-03-06 9:32 ` [PATCH 2/2] arm64: dts: cix: add FCH(S0)/S5 GPIO controllers for sky1 Zichar Zhang
2026-03-06 10:06 ` Linus Walleij
2026-03-07 15:22 ` Krzysztof Kozlowski
2026-03-11 12:38 ` Zichar Zhang
2026-03-06 10:10 ` [PATCH 1/2] dt-bindings: gpio: cdns: add clock-names property Linus Walleij
2026-03-07 15:20 ` Krzysztof Kozlowski
2026-03-11 12:08 ` Zichar Zhang [this message]
2026-03-11 13:05 ` Linus Walleij
2026-03-07 15:19 ` Krzysztof Kozlowski
2026-03-11 12:11 ` Zichar Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abFbRA33DtDdZ2j+@ZicharPC \
--to=zichar.zhang@cixtech.com \
--cc=brgl@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=jank@cadence.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox