From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 767BF2BEC23 for ; Fri, 13 Mar 2026 13:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773407328; cv=none; b=uIvfcHLvdLsXGldIJES3uDQoZ101UCiEjSnayca1G/C6ReegMoIQCpTsK3m4ZNeOPRZ90RDR5WjeHSAeI1Db5nxFRPO29rqZNm8IrT0D1oc5LhptdNsg5ZZ6lprFEQyLU1QNg/bXLwrR9drNWo9TRUJOCLfy/1iBJ4cDWIRubNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773407328; c=relaxed/simple; bh=u6fNhVctrPACDy4XOiqVlTIlf9qL+scNI2RcrzDPK/E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KFpxKyx68EHHn2dtkUv+lwJ91tW8JCVj84lNjNuv9cizFS2VsfvFtTX3V2cpfur92ra1JGIp1Y0PQW64n2osWOa58O/i1Q+O+7FH1hs/o32EwAhPconORH0MFJMRVGr0jJByoSYgEm6wa5w/QGItGQGCrjrfbiROiw544jeIQtI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w12FW-0000Yb-A6; Fri, 13 Mar 2026 14:08:18 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w12FU-0005E9-2r; Fri, 13 Mar 2026 14:08:16 +0100 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1w12FU-0000000HESI-3Dew; Fri, 13 Mar 2026 14:08:16 +0100 Date: Fri, 13 Mar 2026 14:08:16 +0100 From: Oleksij Rempel To: Tommaso Merciai Cc: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Peter Rosin , Linus Walleij , kernel@pengutronix.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-gpio@vger.kernel.org, David Jander , biju.das.jz@bp.renesas.com, tomm.merciai@gmail.com Subject: Re: [PATCH v3 4/7] gpio: gpiolib: fix allocation order in hierarchical IRQ domains Message-ID: References: <20260309134920.1918294-1-o.rempel@pengutronix.de> <20260309134920.1918294-5-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Hi Tommaso, On Fri, Mar 13, 2026 at 11:42:34AM +0100, Tommaso Merciai wrote: > Hi Oleksij, > Thanks for your patch. > > I'm working on DSI support for RZ/G3E > > from this morning rebasing on top of next-20260312 I'm seeing > the following: > I found out the the issue is related to the interrupt of the adv7535 > bridge: > > adv7535: hdmi1@3d { > compatible = "adi,adv7535"; > ... > ... > interrupts-extended = <&pinctrl RZG3E_GPIO(L, 4) IRQ_TYPE_EDGE_FALLING>; > > RZ/G3E is using: > - drivers/pinctrl/renesas/pinctrl-rzg2l.c > > Reverting this patch fix the issue. > (git revert a23463beb3d5) Thank you for the feedback! If I understand the problem correctly, the adv7535 is asserting its IRQ line early during probe, which creates an irq storm due to a missing handler. My patch moved irq_domain_set_info() after the parent allocation. When the parent allocates the IRQ, the pending hardware interrupt fires immediately. Because the child descriptor isn't fully configured yet, it routes to handle_bad_irq. This fails to acknowledge the hardware interrupt, locking up the CPU and causing the RCU stall. I hope splitting the irq_domain_set_info() should fix the regression. Can you please test if this change resolve the RCU stalls on your setup: diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 13dd97344b26..376daeddbbbb 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1628,6 +1628,9 @@ static int gpiochip_hierarchy_irq_domain_alloc(struct irq_domain *d, } gpiochip_dbg(gc, "found parent hwirq %u\n", parent_hwirq); + irq_set_handler(irq, girq->handler); + irq_set_handler_data(irq, gc); + /* This parent only handles asserted level IRQs */ ret = girq->populate_parent_alloc_arg(gc, &gpio_parent_fwspec, parent_hwirq, parent_type); @@ -1655,13 +1658,7 @@ static int gpiochip_hierarchy_irq_domain_alloc(struct irq_domain *d, * We set handle_bad_irq because the .set_type() should * always be invoked and set the right type of handler. */ - irq_domain_set_info(d, - irq, - hwirq, - gc->irq.chip, - gc, - girq->handler, - NULL, NULL); + irq_domain_set_hwirq_and_chip(d, irq, hwirq, gc->irq.chip, gc); irq_set_probe(irq); return 0; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |