* [PATCH 1/3] ARM: dts: exynos: add smb347 charger to p4note
@ 2022-02-02 16:34 Martin Jücker
2022-02-02 16:34 ` [PATCH 2/3] ARM: dts: exynos: add simple battery " Martin Jücker
2022-02-02 16:34 ` [PATCH 3/3] ARM: defconfig: add smb347 charger driver for p4note Martin Jücker
0 siblings, 2 replies; 5+ messages in thread
From: Martin Jücker @ 2022-02-02 16:34 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Russell King,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Martin Jücker
Add device tree entry to support the Summit SMB347 charger which is
built into the p4note devices.
Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
---
arch/arm/boot/dts/exynos4412-p4note.dtsi | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
index b386a9b8e188..63459db653ea 100644
--- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
@@ -16,6 +16,7 @@
#include <dt-bindings/input/linux-event-codes.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/pinctrl/samsung.h>
+#include <dt-bindings/power/summit,smb347-charger.h>
/ {
compatible = "samsung,p4note", "samsung,exynos4412", "samsung,exynos4";
@@ -182,6 +183,27 @@ stmpe_adc {
};
};
};
+
+ i2c-gpio-4 {
+ compatible = "i2c-gpio";
+ sda-gpios = <&gpm2 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ scl-gpios = <&gpm2 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+
+ i2c-gpio,delay-us = <2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ charger@6 {
+ compatible = "summit,smb347";
+ reg = <0x6>;
+ summit,enable-usb-charging;
+ summit,enable-charge-control = <SMB3XX_CHG_ENABLE_SW>;
+ summit,fast-voltage-threshold-microvolt = <2600000>;
+ summit,chip-temperature-threshold-celsius = <130>;
+ summit,usb-current-limit-microamp = <1800000>;
+ };
+ };
+
};
&adc {
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] ARM: dts: exynos: add simple battery to p4note
2022-02-02 16:34 [PATCH 1/3] ARM: dts: exynos: add smb347 charger to p4note Martin Jücker
@ 2022-02-02 16:34 ` Martin Jücker
2022-02-03 15:36 ` Krzysztof Kozlowski
2022-02-02 16:34 ` [PATCH 3/3] ARM: defconfig: add smb347 charger driver for p4note Martin Jücker
1 sibling, 1 reply; 5+ messages in thread
From: Martin Jücker @ 2022-02-02 16:34 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Russell King,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Martin Jücker
Add a simple battery node to the p4note device tree to set the missing
values for the charger to work properly.
Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
---
arch/arm/boot/dts/exynos4412-p4note.dtsi | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
index 63459db653ea..fcd75cceb877 100644
--- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
@@ -115,6 +115,17 @@ wlan_pwrseq: sdhci3-pwrseq {
clock-names = "ext_clock";
};
+ battery_cell: battery-cell {
+ compatible = "simple-battery";
+ device-chemistry = "lithium-ion";
+ constant-charge-current-max-microamp = <2200000>;
+ precharge-current-microamp = <250000>;
+ charge-term-current-microamp = <250000>;
+ constant-charge-voltage-max-microvolt = <4200000>;
+
+ power-supplies = <&power_supply>;
+ };
+
i2c-gpio-1 {
compatible = "i2c-gpio";
sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
@@ -193,7 +204,7 @@ i2c-gpio-4 {
#address-cells = <1>;
#size-cells = <0>;
- charger@6 {
+ power_supply: charger@6 {
compatible = "summit,smb347";
reg = <0x6>;
summit,enable-usb-charging;
@@ -201,6 +212,8 @@ charger@6 {
summit,fast-voltage-threshold-microvolt = <2600000>;
summit,chip-temperature-threshold-celsius = <130>;
summit,usb-current-limit-microamp = <1800000>;
+
+ monitored-battery = <&battery_cell>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] ARM: dts: exynos: add simple battery to p4note
2022-02-02 16:34 ` [PATCH 2/3] ARM: dts: exynos: add simple battery " Martin Jücker
@ 2022-02-03 15:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-03 15:36 UTC (permalink / raw)
To: Martin Jücker, Rob Herring, Alim Akhtar, Russell King,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 02/02/2022 17:34, Martin Jücker wrote:
> Add a simple battery node to the p4note device tree to set the missing
> values for the charger to work properly.
>
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
> arch/arm/boot/dts/exynos4412-p4note.dtsi | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> index 63459db653ea..fcd75cceb877 100644
> --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> @@ -115,6 +115,17 @@ wlan_pwrseq: sdhci3-pwrseq {
> clock-names = "ext_clock";
> };
>
> + battery_cell: battery-cell {
> + compatible = "simple-battery";
> + device-chemistry = "lithium-ion";
> + constant-charge-current-max-microamp = <2200000>;
> + precharge-current-microamp = <250000>;
> + charge-term-current-microamp = <250000>;
> + constant-charge-voltage-max-microvolt = <4200000>;
> +
> + power-supplies = <&power_supply>;
> + };
> +
> i2c-gpio-1 {
> compatible = "i2c-gpio";
> sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> @@ -193,7 +204,7 @@ i2c-gpio-4 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - charger@6 {
> + power_supply: charger@6 {
Squash this change with the previous patch. No need to add a line and
immediately change it in next patch.
> compatible = "summit,smb347";
> reg = <0x6>;
> summit,enable-usb-charging;
> @@ -201,6 +212,8 @@ charger@6 {
> summit,fast-voltage-threshold-microvolt = <2600000>;
> summit,chip-temperature-threshold-celsius = <130>;
> summit,usb-current-limit-microamp = <1800000>;
> +
> + monitored-battery = <&battery_cell>;
> };
> };
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] ARM: defconfig: add smb347 charger driver for p4note
2022-02-02 16:34 [PATCH 1/3] ARM: dts: exynos: add smb347 charger to p4note Martin Jücker
2022-02-02 16:34 ` [PATCH 2/3] ARM: dts: exynos: add simple battery " Martin Jücker
@ 2022-02-02 16:34 ` Martin Jücker
2022-02-03 15:38 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Martin Jücker @ 2022-02-02 16:34 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Russell King,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Martin Jücker
The Summit SMB347 charger has been added to the p4note device tree,
enable the driver in exynos and multi_v7 defconfigs.
Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
---
arch/arm/configs/exynos_defconfig | 1 +
arch/arm/configs/multi_v7_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index c58877cfdc9d..9d3191de96b6 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -159,6 +159,7 @@ CONFIG_CHARGER_MAX14577=y
CONFIG_CHARGER_MAX77693=y
CONFIG_CHARGER_MAX8997=y
CONFIG_CHARGER_MAX8998=y
+CONFIG_CHARGER_SMB347=y
CONFIG_CHARGER_TPS65090=y
CONFIG_SENSORS_LM90=y
CONFIG_SENSORS_NTC_THERMISTOR=y
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 1c2c3e9f0e05..bfbcb57e2083 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -510,6 +510,7 @@ CONFIG_CHARGER_MAX14577=m
CONFIG_CHARGER_MAX77693=m
CONFIG_CHARGER_MAX8997=m
CONFIG_CHARGER_MAX8998=m
+CONFIG_CHARGER_SMB347=m
CONFIG_CHARGER_TPS65090=y
CONFIG_SENSORS_ARM_SCMI=y
CONFIG_SENSORS_ASPEED=m
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] ARM: defconfig: add smb347 charger driver for p4note
2022-02-02 16:34 ` [PATCH 3/3] ARM: defconfig: add smb347 charger driver for p4note Martin Jücker
@ 2022-02-03 15:38 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-03 15:38 UTC (permalink / raw)
To: Martin Jücker, Rob Herring, Alim Akhtar, Russell King,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On 02/02/2022 17:34, Martin Jücker wrote:
> The Summit SMB347 charger has been added to the p4note device tree,
> enable the driver in exynos and multi_v7 defconfigs.
These commits go via different paths and are loosely related, so the
moment this is applied, the SMB347 charger is not yet in P4Note DTS.
Just write that SMB347 is being used by P4Note family of devices, e.g.
Samsung Galaxy Note 10.1 (GT-N8010/N8013).
>
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
> arch/arm/configs/exynos_defconfig | 1 +
> arch/arm/configs/multi_v7_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index c58877cfdc9d..9d3191de96b6 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -159,6 +159,7 @@ CONFIG_CHARGER_MAX14577=y
> CONFIG_CHARGER_MAX77693=y
> CONFIG_CHARGER_MAX8997=y
> CONFIG_CHARGER_MAX8998=y
> +CONFIG_CHARGER_SMB347=y
> CONFIG_CHARGER_TPS65090=y
> CONFIG_SENSORS_LM90=y
> CONFIG_SENSORS_NTC_THERMISTOR=y
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 1c2c3e9f0e05..bfbcb57e2083 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -510,6 +510,7 @@ CONFIG_CHARGER_MAX14577=m
> CONFIG_CHARGER_MAX77693=m
> CONFIG_CHARGER_MAX8997=m
> CONFIG_CHARGER_MAX8998=m
> +CONFIG_CHARGER_SMB347=m
> CONFIG_CHARGER_TPS65090=y
> CONFIG_SENSORS_ARM_SCMI=y
> CONFIG_SENSORS_ASPEED=m
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-03 15:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-02 16:34 [PATCH 1/3] ARM: dts: exynos: add smb347 charger to p4note Martin Jücker
2022-02-02 16:34 ` [PATCH 2/3] ARM: dts: exynos: add simple battery " Martin Jücker
2022-02-03 15:36 ` Krzysztof Kozlowski
2022-02-02 16:34 ` [PATCH 3/3] ARM: defconfig: add smb347 charger driver for p4note Martin Jücker
2022-02-03 15:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).