From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDFF2C433DF for ; Sun, 17 May 2020 21:30:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 852E9207F5 for ; Sun, 17 May 2020 21:30:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbgEQVa4 (ORCPT ); Sun, 17 May 2020 17:30:56 -0400 Received: from foss.arm.com ([217.140.110.172]:58082 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726458AbgEQVaz (ORCPT ); Sun, 17 May 2020 17:30:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EF6E31B; Sun, 17 May 2020 14:30:55 -0700 (PDT) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 230D43F52E; Sun, 17 May 2020 14:30:54 -0700 (PDT) Subject: Re: [PATCH v1 8/9] arm64: dts: actions: Add MMC controller support for S700 To: Amit Tomer Cc: =?UTF-8?Q?Andreas_F=c3=a4rber?= , Manivannan Sadhasivam , Rob Herring , cristian.ciocaltea@gmail.com, linux-arm-kernel , linux-actions@lists.infradead.org, devicetree@vger.kernel.org References: <1589472657-3930-1-git-send-email-amittomer25@gmail.com> <1589472657-3930-9-git-send-email-amittomer25@gmail.com> <2cd3cdaf-826e-9d12-9fd4-9f7e2a517ecd@arm.com> From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Organization: ARM Ltd. Message-ID: Date: Sun, 17 May 2020 22:30:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/05/2020 18:12, Amit Tomer wrote: >> I don't understand what this has to do with the driver, but I asked >> above to also change the binding, allowing this compatible string >> combination. > if we add these two strings "actions,s700-mmc", "actions,owl-mmc" to dts file > and leave the driver as it. Wouldn't this be mismatch(as driver only > has "actions,owl-mmc" > and DTS has two strings). > > Shouldn't that be concerned about ? I recommend reading the DT spec, chapter 2.3.1 "compatible": https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf Cheers, Andre