From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741E2C3DA6E for ; Fri, 23 Dec 2022 12:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236120AbiLWMB2 (ORCPT ); Fri, 23 Dec 2022 07:01:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236180AbiLWMBG (ORCPT ); Fri, 23 Dec 2022 07:01:06 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D921E4496A for ; Fri, 23 Dec 2022 04:00:21 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id z26so6835882lfu.8 for ; Fri, 23 Dec 2022 04:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+nI2AU4o1rjXUcHSb6ceGhhVZddIcB3diHI1Vs6E0sA=; b=wYiUKAFBZEUkbsZwdujqm4J1yb5X29oD24XfGz46xCp9h/qSU+voasAkOmhjpuEjO6 FlW9kE47xCidQdI/Y8Xt7fjpCk/BE8T4vb1Apm+0RW+2vz2k1BppYFsxldOXc8eiyUXq pzanpdYdUmYZUuhLt4KqyeGQXVF9TmtNMqAAXBMZSkkajwEEWoBP1EoLLUZtBq/dZkIy A1X1ii9m6dGEsIVHkCP2mztVBzuhE9xtSgUzsz4ePsKFua3K9xbtgKaKYSWt5hOTw8sZ R1nusnDS0zWTDmpd8qaSwagx+HkpfKZP4HYWS0Zjyc/WQ5YqfhoPcBMprsU+oPAfzlwl qZiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+nI2AU4o1rjXUcHSb6ceGhhVZddIcB3diHI1Vs6E0sA=; b=Y/Kh4XV6UodF4WXy0XuE7AQzBoTwxcc7TCtlhovQOv9dsqNR/z0CUV6tWa4kWqnc8B kyx2x8JQ4IqAXo4jbBOf8ge77P3o4TFEH8Tdk5mjOLgmooC98dnNTRPvFuEr/XkI0V5O QKJW7KjG6o0bBH/nGmrvyX6DvVfrE9TDhrZ5ZFokPudKGekUD2mQGTWzOKVF2Iw5Aonb 54Vn7+QDbz3kDWEIIXmHIbiBsKXGIq1GGzIJQMy0tjT5XzP3H3i0VErJfNGWltYforlU WaNywvxtisEMviiQ7NGh3j9f/HHxUljEcBNTyr/KDzAELypM41XgiXWgbNAuShcmJy8P 4itQ== X-Gm-Message-State: AFqh2kq9HYX2OPX9miMSruDoMg5xp68TJRlBvqdswh3edcgsR7pXvqof G/PTl1INL6NYgP7mbEyhqmcLqA== X-Google-Smtp-Source: AMrXdXug02SHrEVae3snmuyspNlzmnJVxG+7NJO2UAAxHzVtSBinSDncn8yFVh+3wYWsf/EjFHsiBA== X-Received: by 2002:a05:6512:2508:b0:4b5:9b8f:cc82 with SMTP id be8-20020a056512250800b004b59b8fcc82mr2838920lfb.0.1671796820161; Fri, 23 Dec 2022 04:00:20 -0800 (PST) Received: from [192.168.1.101] (abyl184.neoplus.adsl.tpnet.pl. [83.9.31.184]) by smtp.gmail.com with ESMTPSA id w12-20020a05651234cc00b0047f7722b73csm497112lfr.142.2022.12.23.04.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Dec 2022 04:00:19 -0800 (PST) Message-ID: Date: Fri, 23 Dec 2022 13:00:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 3/5] arm64: dts: qcom: sm6125-seine: Provide regulators to SDHCI 1 Content-Language: en-US To: Marijn Suijten , phone-devel@vger.kernel.org, Bjorn Andersson Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221222203636.250190-1-marijn.suijten@somainline.org> <20221222203636.250190-4-marijn.suijten@somainline.org> From: Konrad Dybcio In-Reply-To: <20221222203636.250190-4-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22.12.2022 21:36, Marijn Suijten wrote: > While SDHCI 1 appears to work out of the box, we cannot rely on the > bootloader-enabled regulators nor expect them to remain enabled (e.g. > when finally dropping pd_ignore_unused). Unrelated, unused-yet-enabled (as far as Linux is concerned, anyway, it doesn't know the state of smd rpm regulators unless you add regulator-boot-on) regulators get swept by "regulator cleanup". Provide it the necessary l24 > and l11 regulators now that PM6125 regulators have been made available > on this board. > > As usual regulator voltages are decreased to the maximum voted by the > downstream driver for safety. No other hardware feeds off of these > regulators anyway (except UFS, which isn't used on the seine board in > favour of a DV6DMB eMMC card connected to SDHCI 1). > > Signed-off-by: Marijn Suijten > --- Reviewed-by: Konrad Dybcio Konrad > .../boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts > index 15b43cff210b..eaddbe522695 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts > +++ b/arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dts > @@ -348,7 +348,8 @@ pm6125_l10: l10 { > > pm6125_l11: l11 { > regulator-min-microvolt = <1800000>; > - regulator-max-microvolt = <1952000>; > + regulator-max-microvolt = <1800000>; > + regulator-allow-set-load; > }; > > pm6125_l12: l12 { > @@ -413,7 +414,8 @@ pm6125_l23: l23 { > > pm6125_l24: l24 { > regulator-min-microvolt = <2944000>; > - regulator-max-microvolt = <3304000>; > + regulator-max-microvolt = <2950000>; > + regulator-allow-set-load; > }; > }; > }; > @@ -437,6 +439,8 @@ sd-cd-pins { > }; > > &sdhc_1 { > + vmmc-supply = <&pm6125_l24>; > + vqmmc-supply = <&pm6125_l11>; > status = "okay"; > }; >