* [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-17 18:14 ` Nikita Travkin
2023-06-17 17:15 ` [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI Krzysztof Kozlowski
` (14 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
liteon,ltr559 light sensor takes VDDIO, not VIO, supply:
msm8916-longcheer-l8150.dtb: light-sensor@23: 'vio-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
Fixes: 3016af34ef8d ("arm64: dts: qcom: msm8916-longcheer-l8150: Add light and proximity sensor")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
index 97262b8519b3..3892ad4f639a 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
@@ -165,7 +165,7 @@ light-sensor@23 {
pinctrl-0 = <&light_int_default>;
vdd-supply = <&pm8916_l17>;
- vio-supply = <&pm8916_l6>;
+ vddio-supply = <&pm8916_l6>;
};
gyroscope@68 {
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply
2023-06-17 17:15 ` [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply Krzysztof Kozlowski
@ 2023-06-17 18:14 ` Nikita Travkin
0 siblings, 0 replies; 34+ messages in thread
From: Nikita Travkin @ 2023-06-17 18:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Stephan Gerhold, linux-arm-msm, devicetree, linux-kernel
Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> liteon,ltr559 light sensor takes VDDIO, not VIO, supply:
>
> msm8916-longcheer-l8150.dtb: light-sensor@23: 'vio-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Fixes: 3016af34ef8d ("arm64: dts: qcom: msm8916-longcheer-l8150: Add light and proximity sensor")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Oops, thanks for noticing!
Reviewed-by: Nikita Travkin <nikita@trvn.ru>
> ---
> arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> index 97262b8519b3..3892ad4f639a 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts
> @@ -165,7 +165,7 @@ light-sensor@23 {
> pinctrl-0 = <&light_int_default>;
>
> vdd-supply = <&pm8916_l17>;
> - vio-supply = <&pm8916_l6>;
> + vddio-supply = <&pm8916_l6>;
> };
>
> gyroscope@68 {
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:12 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C Krzysztof Kozlowski
` (13 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
I2C and SPI controller bindings do not allow label property:
apq8016-sbc.dtb: spi@78b7000: Unevaluated properties are not allowed ('label' was unexpected)
apq8016-sbc.dtb: i2c@78b6000: Unevaluated properties are not allowed ('label' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index f3d65a606194..e0993e32ee38 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -172,15 +172,13 @@ led@6 {
};
&blsp_i2c2 {
- /* On Low speed expansion */
+ /* On Low speed expansion: LS-I2C0 */
status = "okay";
- label = "LS-I2C0";
};
&blsp_i2c4 {
- /* On High speed expansion */
+ /* On High speed expansion: HS-I2C2 */
status = "okay";
- label = "HS-I2C2";
adv_bridge: bridge@39 {
status = "okay";
@@ -228,21 +226,18 @@ adv7533_out: endpoint {
};
&blsp_i2c6 {
- /* On Low speed expansion */
+ /* On Low speed expansion: LS-I2C1 */
status = "okay";
- label = "LS-I2C1";
};
&blsp_spi3 {
- /* On High speed expansion */
+ /* On High speed expansion: HS-SPI1 */
status = "okay";
- label = "HS-SPI1";
};
&blsp_spi5 {
- /* On Low speed expansion */
+ /* On Low speed expansion: LS-SPI0 */
status = "okay";
- label = "LS-SPI0";
};
&blsp_uart1 {
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI
2023-06-17 17:15 ` [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI Krzysztof Kozlowski
@ 2023-06-19 13:12 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C and SPI controller bindings do not allow label property:
>
> apq8016-sbc.dtb: spi@78b7000: Unevaluated properties are not allowed ('label' was unexpected)
> apq8016-sbc.dtb: i2c@78b6000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index f3d65a606194..e0993e32ee38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -172,15 +172,13 @@ led@6 {
> };
>
> &blsp_i2c2 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C0 */
> status = "okay";
> - label = "LS-I2C0";
> };
>
> &blsp_i2c4 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-I2C2 */
> status = "okay";
> - label = "HS-I2C2";
>
> adv_bridge: bridge@39 {
> status = "okay";
> @@ -228,21 +226,18 @@ adv7533_out: endpoint {
> };
>
> &blsp_i2c6 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-I2C1 */
> status = "okay";
> - label = "LS-I2C1";
> };
>
> &blsp_spi3 {
> - /* On High speed expansion */
> + /* On High speed expansion: HS-SPI1 */
> status = "okay";
> - label = "HS-SPI1";
> };
>
> &blsp_spi5 {
> - /* On Low speed expansion */
> + /* On Low speed expansion: LS-SPI0 */
> status = "okay";
> - label = "LS-SPI0";
> };
>
> &blsp_uart1 {
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply Krzysztof Kozlowski
2023-06-17 17:15 ` [PATCH 03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:12 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties Krzysztof Kozlowski
` (12 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
I2C controller bindings do not allow label property:
apq8096-db820c.dtb: i2c@7577000: Unevaluated properties are not allowed ('label' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
index 537547b97459..002cf5806d83 100644
--- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
+++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
@@ -138,8 +138,7 @@ wlan_en: wlan-en-1-8v {
};
&blsp1_i2c3 {
- /* On Low speed expansion */
- label = "LS-I2C0";
+ /* On Low speed expansion: LS-I2C0 */
status = "okay";
};
@@ -168,14 +167,12 @@ &adsp_pil {
};
&blsp2_i2c1 {
- /* On High speed expansion */
- label = "HS-I2C2";
+ /* On High speed expansion: HS-I2C2 */
status = "okay";
};
&blsp2_i2c1 {
- /* On Low speed expansion */
- label = "LS-I2C1";
+ /* On Low speed expansion: LS-I2C1 */
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C
2023-06-17 17:15 ` [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C Krzysztof Kozlowski
@ 2023-06-19 13:12 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C controller bindings do not allow label property:
>
> apq8096-db820c.dtb: i2c@7577000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> index 537547b97459..002cf5806d83 100644
> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
> @@ -138,8 +138,7 @@ wlan_en: wlan-en-1-8v {
> };
>
> &blsp1_i2c3 {
> - /* On Low speed expansion */
> - label = "LS-I2C0";
> + /* On Low speed expansion: LS-I2C0 */
> status = "okay";
> };
>
> @@ -168,14 +167,12 @@ &adsp_pil {
> };
>
> &blsp2_i2c1 {
> - /* On High speed expansion */
> - label = "HS-I2C2";
> + /* On High speed expansion: HS-I2C2 */
> status = "okay";
> };
>
> &blsp2_i2c1 {
> - /* On Low speed expansion */
> - label = "LS-I2C1";
> + /* On Low speed expansion: LS-I2C1 */
> status = "okay";
> };
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:12 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C Krzysztof Kozlowski
` (11 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
The children of qcom,smp2p do not need address/size-cells:
msm8939-sony-xperia-kanuti-tulip.dtb: smp2p-hexagon: slave-kernel: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
index 895cafc11480..05d8abbbc840 100644
--- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
@@ -386,8 +386,6 @@ hexagon_smp2p_in: slave-kernel {
interrupt-controller;
#interrupt-cells = <2>;
- #address-cells = <0>;
- #size-cells = <0>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties
2023-06-17 17:15 ` [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties Krzysztof Kozlowski
@ 2023-06-19 13:12 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:12 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> The children of qcom,smp2p do not need address/size-cells:
>
> msm8939-sony-xperia-kanuti-tulip.dtb: smp2p-hexagon: slave-kernel: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8939.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> index 895cafc11480..05d8abbbc840 100644
> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
> @@ -386,8 +386,6 @@ hexagon_smp2p_in: slave-kernel {
>
> interrupt-controller;
> #interrupt-cells = <2>;
> - #address-cells = <0>;
> - #size-cells = <0>;
> };
> };
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:13 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names Krzysztof Kozlowski
` (10 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
I2C controller bindings do not allow label property:
msm8996-xiaomi-gemini.dtb: i2c@75b6000: Unevaluated properties are not allowed ('label' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 47f55c7311e9..8c2d6e9e851b 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -187,7 +187,6 @@ &adsp_pil {
&blsp2_i2c2 {
status = "okay";
- label = "NFC_I2C";
clock-frequency = <400000>;
nfc: pn548@28 {
@@ -208,7 +207,6 @@ nfc: pn548@28 {
&blsp2_i2c3 {
status = "okay";
- label = "TYPEC_I2C";
typec: tusb320l@47 {
compatible = "ti,tusb320l";
@@ -220,7 +218,7 @@ typec: tusb320l@47 {
&blsp2_i2c6 {
status = "okay";
- label = "MSM_TS_I2C";
+ /* MSM_TS */
};
&blsp1_uart2 {
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C
2023-06-17 17:15 ` [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C Krzysztof Kozlowski
@ 2023-06-19 13:13 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> I2C controller bindings do not allow label property:
>
> msm8996-xiaomi-gemini.dtb: i2c@75b6000: Unevaluated properties are not allowed ('label' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 47f55c7311e9..8c2d6e9e851b 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -187,7 +187,6 @@ &adsp_pil {
>
> &blsp2_i2c2 {
> status = "okay";
> - label = "NFC_I2C";
> clock-frequency = <400000>;
>
> nfc: pn548@28 {
> @@ -208,7 +207,6 @@ nfc: pn548@28 {
>
> &blsp2_i2c3 {
> status = "okay";
> - label = "TYPEC_I2C";
>
> typec: tusb320l@47 {
> compatible = "ti,tusb320l";
> @@ -220,7 +218,7 @@ typec: tusb320l@47 {
>
> &blsp2_i2c6 {
> status = "okay";
> - label = "MSM_TS_I2C";
> + /* MSM_TS */
> };
>
> &blsp1_uart2 {
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (4 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:13 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel " Krzysztof Kozlowski
` (9 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Use generic node names for I2C devices.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 8c2d6e9e851b..bcd2397eb373 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -189,7 +189,7 @@ &blsp2_i2c2 {
status = "okay";
clock-frequency = <400000>;
- nfc: pn548@28 {
+ nfc: nfc@28 {
compatible = "nxp,nxp-nci-i2c";
reg = <0x28>;
@@ -208,7 +208,7 @@ nfc: pn548@28 {
&blsp2_i2c3 {
status = "okay";
- typec: tusb320l@47 {
+ typec: typec@47 {
compatible = "ti,tusb320l";
reg = <0x47>;
interrupt-parent = <&tlmm>;
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names
2023-06-17 17:15 ` [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names Krzysztof Kozlowski
@ 2023-06-19 13:13 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Use generic node names for I2C devices.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 8c2d6e9e851b..bcd2397eb373 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -189,7 +189,7 @@ &blsp2_i2c2 {
> status = "okay";
> clock-frequency = <400000>;
>
> - nfc: pn548@28 {
> + nfc: nfc@28 {
> compatible = "nxp,nxp-nci-i2c";
>
> reg = <0x28>;
> @@ -208,7 +208,7 @@ nfc: pn548@28 {
> &blsp2_i2c3 {
> status = "okay";
>
> - typec: tusb320l@47 {
> + typec: typec@47 {
> compatible = "ti,tusb320l";
> reg = <0x47>;
> interrupt-parent = <&tlmm>;
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (5 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-17 18:11 ` Nikita Travkin
2023-06-19 13:13 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply Krzysztof Kozlowski
` (8 subsequent siblings)
15 siblings, 2 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
ADC channel node names were changed to require generic 'channel'. The
user-visible part is defined via label.
sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
index b637b4270f88..dbb48934d499 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
@@ -314,16 +314,18 @@ &mdss_dsi0_phy {
};
&pm6150_adc {
- thermistor@4e {
+ channel@4e {
reg = <ADC5_AMUX_THM2_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
+ label = "thermistor";
};
- charger-thermistor@4f {
+ channel@4f {
reg = <ADC5_AMUX_THM3_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
+ label = "charger_thermistor";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names
2023-06-17 17:15 ` [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel " Krzysztof Kozlowski
@ 2023-06-17 18:11 ` Nikita Travkin
2023-06-19 13:13 ` Konrad Dybcio
1 sibling, 0 replies; 34+ messages in thread
From: Nikita Travkin @ 2023-06-17 18:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Stephan Gerhold, linux-arm-msm, devicetree, linux-kernel
Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> ADC channel node names were changed to require generic 'channel'. The
> user-visible part is defined via label.
>
> sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks for fixing this up!
Reviewed-by: Nikita Travkin <nikita@trvn.ru>
> ---
> arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index b637b4270f88..dbb48934d499 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -314,16 +314,18 @@ &mdss_dsi0_phy {
> };
>
> &pm6150_adc {
> - thermistor@4e {
> + channel@4e {
> reg = <ADC5_AMUX_THM2_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "thermistor";
> };
>
> - charger-thermistor@4f {
> + channel@4f {
> reg = <ADC5_AMUX_THM3_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "charger_thermistor";
> };
> };
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names
2023-06-17 17:15 ` [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel " Krzysztof Kozlowski
2023-06-17 18:11 ` Nikita Travkin
@ 2023-06-19 13:13 ` Konrad Dybcio
1 sibling, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> ADC channel node names were changed to require generic 'channel'. The
> user-visible part is defined via label.
>
> sc7180-acer-aspire1.dtb: adc@3100: 'charger-thermistor@4f', 'thermistor@4e' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index b637b4270f88..dbb48934d499 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -314,16 +314,18 @@ &mdss_dsi0_phy {
> };
>
> &pm6150_adc {
> - thermistor@4e {
> + channel@4e {
> reg = <ADC5_AMUX_THM2_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "thermistor";
> };
>
> - charger-thermistor@4f {
> + channel@4f {
> reg = <ADC5_AMUX_THM3_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> + label = "charger_thermistor";
> };
> };
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (6 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel " Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:14 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names Krzysztof Kozlowski
` (7 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Bluetooth requires VDDIO supply. Due to lack of schematics provide
something dummy to satisfy `dtbs_check`:
sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
index afae7f46b050..b1aa5b0ee95c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
@@ -24,6 +24,13 @@ aliases {
chosen {
stdout-path = "serial0:115200n8";
};
+
+ bt_vddio: regulator-bt-vddio {
+ compatible = "regulator-fixed";
+ regulator-name = "bt-vddio";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
};
&apps_rsc {
@@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 {
};
};
+&bluetooth {
+ vddio-supply = <&bt_vddio>;
+};
+
ap_tp_i2c: &i2c0 {
status = "okay";
clock-frequency = <400000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply
2023-06-17 17:15 ` [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply Krzysztof Kozlowski
@ 2023-06-19 13:14 ` Konrad Dybcio
2023-06-23 18:34 ` Doug Anderson
0 siblings, 1 reply; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel, Douglas Anderson
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Bluetooth requires VDDIO supply. Due to lack of schematics provide
> something dummy to satisfy `dtbs_check`:
>
> sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
For this:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
+CC Doug to perhaps fix this properly (though I think we should have got
it through the cros list anyway)
Konrad
> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> index afae7f46b050..b1aa5b0ee95c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> @@ -24,6 +24,13 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + bt_vddio: regulator-bt-vddio {
> + compatible = "regulator-fixed";
> + regulator-name = "bt-vddio";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> };
>
> &apps_rsc {
> @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 {
> };
> };
>
> +&bluetooth {
> + vddio-supply = <&bt_vddio>;
> +};
> +
> ap_tp_i2c: &i2c0 {
> status = "okay";
> clock-frequency = <400000>;
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply
2023-06-19 13:14 ` Konrad Dybcio
@ 2023-06-23 18:34 ` Doug Anderson
2023-06-24 7:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 34+ messages in thread
From: Doug Anderson @ 2023-06-23 18:34 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Hi,
On Mon, Jun 19, 2023 at 6:14 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> > Bluetooth requires VDDIO supply. Due to lack of schematics provide
> > something dummy to satisfy `dtbs_check`:
> >
> > sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> For this:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> +CC Doug to perhaps fix this properly (though I think we should have got
> it through the cros list anyway)
>
> Konrad
> > arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> > index afae7f46b050..b1aa5b0ee95c 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
> > @@ -24,6 +24,13 @@ aliases {
> > chosen {
> > stdout-path = "serial0:115200n8";
> > };
> > +
> > + bt_vddio: regulator-bt-vddio {
> > + compatible = "regulator-fixed";
> > + regulator-name = "bt-vddio";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + };
> > };
> >
> > &apps_rsc {
> > @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 {
> > };
> > };
> >
> > +&bluetooth {
> > + vddio-supply = <&bt_vddio>;
> > +};
> > +
I would have a hard time believing that the more correct fix wouldn't be:
vddio-supply = <&vreg_l18b_1p8>;
Specifically L18B is what we have on the newer CRD (the one that is
considered a "herobrine" and includes Qcard) and also IDP2. In terms
of timeline / similarities, CRD-rev3 falls in between IDP2 and newer
CRD. These both agree on L18B. The only board that uses something
different (L19B) is the very old IDP1.
That being said, Qualcomm has never provided (at least to me)
schematics for any given reference board. Whenever asked, I was always
pointed at schematics that were said to be "close enough". Thus, I
can't really give a definitive answer here. Even so, pointing at L18B
seems to me to be 99% likely to be correct.
If anyone reading actually has schematics, I think you can just look
at what goes to the pad labelled "VDDPX_3". The datasheet I have shows
that as "Pad group 3 (most peripherals)". If nothing else, that powers
the pins connected to the UART that Bluetooth uses (along with a whole
pile of other things in the system).
-Doug
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply
2023-06-23 18:34 ` Doug Anderson
@ 2023-06-24 7:39 ` Krzysztof Kozlowski
0 siblings, 0 replies; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-24 7:39 UTC (permalink / raw)
To: Doug Anderson, Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, cros-qcom-dts-watchers, Nikita Travkin,
Stephan Gerhold, linux-arm-msm, devicetree, linux-kernel
On 23/06/2023 20:34, Doug Anderson wrote:
> Hi,
>
> On Mon, Jun 19, 2023 at 6:14 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
>>> Bluetooth requires VDDIO supply. Due to lack of schematics provide
>>> something dummy to satisfy `dtbs_check`:
>>>
>>> sc7280-crd-r3.dtb: bluetooth: 'vddio-supply' is a required property
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>> For this:
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> +CC Doug to perhaps fix this properly (though I think we should have got
>> it through the cros list anyway)
>>
>> Konrad
>>> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts | 11 +++++++++++
>>> 1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
>>> index afae7f46b050..b1aa5b0ee95c 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts
>>> @@ -24,6 +24,13 @@ aliases {
>>> chosen {
>>> stdout-path = "serial0:115200n8";
>>> };
>>> +
>>> + bt_vddio: regulator-bt-vddio {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "bt-vddio";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + };
>>> };
>>>
>>> &apps_rsc {
>>> @@ -38,6 +45,10 @@ vreg_s1k_1p0: smps1 {
>>> };
>>> };
>>>
>>> +&bluetooth {
>>> + vddio-supply = <&bt_vddio>;
>>> +};
>>> +
>
> I would have a hard time believing that the more correct fix wouldn't be:
>
> vddio-supply = <&vreg_l18b_1p8>;
>
> Specifically L18B is what we have on the newer CRD (the one that is
> considered a "herobrine" and includes Qcard) and also IDP2. In terms
> of timeline / similarities, CRD-rev3 falls in between IDP2 and newer
> CRD. These both agree on L18B. The only board that uses something
> different (L19B) is the very old IDP1.
>
> That being said, Qualcomm has never provided (at least to me)
> schematics for any given reference board. Whenever asked, I was always
> pointed at schematics that were said to be "close enough". Thus, I
> can't really give a definitive answer here. Even so, pointing at L18B
> seems to me to be 99% likely to be correct.
99% is good enough for me. Thanks, I will send a v2 after the merge window.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (7 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 09/15] arm64: dts: qcom: sc7280-crd: add dummy Bluetooth VDDIO supply Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:14 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings Krzysztof Kozlowski
` (6 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
ADC channel node names were changed to require generic 'channel'. The
user-visible part is defined via label.
sc8180x-lenovo-flex-5g.dtb: adc@3100: 'die-temp@6', 'ref-gnd@0', 'vref-1p25@1' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 24 ++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index 8247af01c84a..4556af6cd103 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -105,19 +105,19 @@ pmc8180_adc: adc@3100 {
#io-channel-cells = <1>;
interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
- ref-gnd@0 {
+ channel@0 {
reg = <ADC5_REF_GND>;
qcom,pre-scaling = <1 1>;
label = "ref_gnd";
};
- vref-1p25@1 {
+ channel@1 {
reg = <ADC5_1P25VREF>;
qcom,pre-scaling = <1 1>;
label = "vref_1p25";
};
- die-temp@6 {
+ channel@6 {
reg = <ADC5_DIE_TEMP>;
qcom,pre-scaling = <1 1>;
label = "die_temp";
@@ -172,19 +172,19 @@ adc@3100 {
#io-channel-cells = <1>;
interrupts = <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
- ref-gnd@0 {
+ channel@0 {
reg = <ADC5_REF_GND>;
qcom,pre-scaling = <1 1>;
label = "ref_gnd";
};
- vref-1p25@1 {
+ channel@1 {
reg = <ADC5_1P25VREF>;
qcom,pre-scaling = <1 1>;
label = "vref_1p25";
};
- vcoin@85 {
+ channel@85 {
reg = <0x85>;
qcom,pre-scaling = <1 1>;
label = "vcoin2";
@@ -220,19 +220,19 @@ adc@3100 {
#io-channel-cells = <1>;
interrupts = <0xa 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
- ref-gnd@0 {
+ channel@0 {
reg = <ADC5_REF_GND>;
qcom,pre-scaling = <1 1>;
label = "ref_gnd";
};
- vref-1p25@1 {
+ channel@1 {
reg = <ADC5_1P25VREF>;
qcom,pre-scaling = <1 1>;
label = "vref_1p25";
};
- vcoin@85 {
+ channel@85 {
reg = <0x85>;
qcom,pre-scaling = <1 1>;
label = "vcoin";
@@ -270,19 +270,19 @@ pmc8180c_adc: adc@3100 {
#io-channel-cells = <1>;
interrupts = <0x4 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
- ref-gnd@0 {
+ channel@0 {
reg = <ADC5_REF_GND>;
qcom,pre-scaling = <1 1>;
label = "ref_gnd";
};
- vref-1p25@1 {
+ channel@1 {
reg = <ADC5_1P25VREF>;
qcom,pre-scaling = <1 1>;
label = "vref_1p25";
};
- die-temp@6 {
+ channel@6 {
reg = <ADC5_DIE_TEMP>;
qcom,pre-scaling = <1 1>;
label = "die_temp";
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names
2023-06-17 17:15 ` [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names Krzysztof Kozlowski
@ 2023-06-19 13:14 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> ADC channel node names were changed to require generic 'channel'. The
> user-visible part is defined via label.
>
> sc8180x-lenovo-flex-5g.dtb: adc@3100: 'die-temp@6', 'ref-gnd@0', 'vref-1p25@1' do not match any of the regexes: '^channel@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 24 ++++++++++-----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> index 8247af01c84a..4556af6cd103 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
> @@ -105,19 +105,19 @@ pmc8180_adc: adc@3100 {
> #io-channel-cells = <1>;
> interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>
> - ref-gnd@0 {
> + channel@0 {
> reg = <ADC5_REF_GND>;
> qcom,pre-scaling = <1 1>;
> label = "ref_gnd";
> };
>
> - vref-1p25@1 {
> + channel@1 {
> reg = <ADC5_1P25VREF>;
> qcom,pre-scaling = <1 1>;
> label = "vref_1p25";
> };
>
> - die-temp@6 {
> + channel@6 {
> reg = <ADC5_DIE_TEMP>;
> qcom,pre-scaling = <1 1>;
> label = "die_temp";
> @@ -172,19 +172,19 @@ adc@3100 {
> #io-channel-cells = <1>;
> interrupts = <0x2 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>
> - ref-gnd@0 {
> + channel@0 {
> reg = <ADC5_REF_GND>;
> qcom,pre-scaling = <1 1>;
> label = "ref_gnd";
> };
>
> - vref-1p25@1 {
> + channel@1 {
> reg = <ADC5_1P25VREF>;
> qcom,pre-scaling = <1 1>;
> label = "vref_1p25";
> };
>
> - vcoin@85 {
> + channel@85 {
> reg = <0x85>;
> qcom,pre-scaling = <1 1>;
> label = "vcoin2";
> @@ -220,19 +220,19 @@ adc@3100 {
> #io-channel-cells = <1>;
> interrupts = <0xa 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>
> - ref-gnd@0 {
> + channel@0 {
> reg = <ADC5_REF_GND>;
> qcom,pre-scaling = <1 1>;
> label = "ref_gnd";
> };
>
> - vref-1p25@1 {
> + channel@1 {
> reg = <ADC5_1P25VREF>;
> qcom,pre-scaling = <1 1>;
> label = "vref_1p25";
> };
>
> - vcoin@85 {
> + channel@85 {
> reg = <0x85>;
> qcom,pre-scaling = <1 1>;
> label = "vcoin";
> @@ -270,19 +270,19 @@ pmc8180c_adc: adc@3100 {
> #io-channel-cells = <1>;
> interrupts = <0x4 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>
> - ref-gnd@0 {
> + channel@0 {
> reg = <ADC5_REF_GND>;
> qcom,pre-scaling = <1 1>;
> label = "ref_gnd";
> };
>
> - vref-1p25@1 {
> + channel@1 {
> reg = <ADC5_1P25VREF>;
> qcom,pre-scaling = <1 1>;
> label = "vref_1p25";
> };
>
> - die-temp@6 {
> + channel@6 {
> reg = <ADC5_DIE_TEMP>;
> qcom,pre-scaling = <1 1>;
> label = "die_temp";
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (8 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:14 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports Krzysztof Kozlowski
` (5 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Bindings expect thermal node names to end with 'thermal':
sc8180x-lenovo-flex-5g.dtb: thermal-zones: 'gpu-thermal-bottom', 'gpu-thermal-top' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index d3ae18535636..576180451491 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -3856,7 +3856,7 @@ cluster-crit {
};
};
- gpu-thermal-top {
+ gpu-top-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
@@ -4006,7 +4006,7 @@ trip-point0 {
};
};
- gpu-thermal-bottom {
+ gpu-bottom-thermal {
polling-delay-passive = <250>;
polling-delay = <1000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings
2023-06-17 17:15 ` [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings Krzysztof Kozlowski
@ 2023-06-19 13:14 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Bindings expect thermal node names to end with 'thermal':
>
> sc8180x-lenovo-flex-5g.dtb: thermal-zones: 'gpu-thermal-bottom', 'gpu-thermal-top' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> index d3ae18535636..576180451491 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> @@ -3856,7 +3856,7 @@ cluster-crit {
> };
> };
>
> - gpu-thermal-top {
> + gpu-top-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
> @@ -4006,7 +4006,7 @@ trip-point0 {
> };
> };
>
> - gpu-thermal-bottom {
> + gpu-bottom-thermal {
> polling-delay-passive = <250>;
> polling-delay = <1000>;
>
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (9 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: " Krzysztof Kozlowski
` (4 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Panel takes only one port:
sc8180x-lenovo-flex-5g.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index b12e0a61b3c0..39c6ef0802aa 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -298,11 +298,9 @@ panel {
backlight = <&backlight>;
- ports {
- port {
- auo_b140han06_in: endpoint {
- remote-endpoint = <&mdss_edp_out>;
- };
+ port {
+ auo_b140han06_in: endpoint {
+ remote-endpoint = <&mdss_edp_out>;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports
2023-06-17 17:15 ` [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports Krzysztof Kozlowski
@ 2023-06-19 13:15 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Panel takes only one port:
>
> sc8180x-lenovo-flex-5g.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index b12e0a61b3c0..39c6ef0802aa 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -298,11 +298,9 @@ panel {
>
> backlight = <&backlight>;
>
> - ports {
> - port {
> - auo_b140han06_in: endpoint {
> - remote-endpoint = <&mdss_edp_out>;
> - };
> + port {
> + auo_b140han06_in: endpoint {
> + remote-endpoint = <&mdss_edp_out>;
> };
> };
> };
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (10 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings Krzysztof Kozlowski
` (3 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Panel takes only one port:
sc8180x-primus.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index fc038474cb71..9b8695b92c48 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -377,11 +377,9 @@ panel {
backlight = <&backlight>;
- ports {
- port {
- auo_b133han05_in: endpoint {
- remote-endpoint = <&mdss_edp_out>;
- };
+ port {
+ auo_b133han05_in: endpoint {
+ remote-endpoint = <&mdss_edp_out>;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports
2023-06-17 17:15 ` [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: " Krzysztof Kozlowski
@ 2023-06-19 13:15 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Panel takes only one port:
>
> sc8180x-primus.dtb: panel: 'ports' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> index fc038474cb71..9b8695b92c48 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
> @@ -377,11 +377,9 @@ panel {
>
> backlight = <&backlight>;
>
> - ports {
> - port {
> - auo_b133han05_in: endpoint {
> - remote-endpoint = <&mdss_edp_out>;
> - };
> + port {
> + auo_b133han05_in: endpoint {
> + remote-endpoint = <&mdss_edp_out>;
> };
> };
> };
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (11 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 13/15] arm64: dts: qcom: sc8180x-primus: " Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 17:15 ` [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup Krzysztof Kozlowski
` (2 subsequent siblings)
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Bindings except certain pattern for gpio-keys children:
sc8180x-lenovo-flex-5g.dtb: gpio-keys: 'lid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index 39c6ef0802aa..fca08db89769 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -36,7 +36,7 @@ gpio-keys {
pinctrl-0 = <&hall_int_active_state>;
pinctrl-names = "default";
- lid {
+ lid-switch {
gpios = <&tlmm 121 GPIO_ACTIVE_LOW>;
linux,input-type = <EV_SW>;
linux,code = <SW_LID>;
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings
2023-06-17 17:15 ` [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings Krzysztof Kozlowski
@ 2023-06-19 13:15 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Bindings except certain pattern for gpio-keys children:
>
> sc8180x-lenovo-flex-5g.dtb: gpio-keys: 'lid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index 39c6ef0802aa..fca08db89769 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -36,7 +36,7 @@ gpio-keys {
> pinctrl-0 = <&hall_int_active_state>;
> pinctrl-names = "default";
>
> - lid {
> + lid-switch {
> gpios = <&tlmm 121 GPIO_ACTIVE_LOW>;
> linux,input-type = <EV_SW>;
> linux,code = <SW_LID>;
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (12 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings Krzysztof Kozlowski
@ 2023-06-17 17:15 ` Krzysztof Kozlowski
2023-06-19 13:15 ` Konrad Dybcio
2023-06-17 18:25 ` [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Nikita Travkin
2023-07-10 5:07 ` (subset) " Bjorn Andersson
15 siblings, 1 reply; 34+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-17 17:15 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
Use 'wakeup-source' instead of 'gpio-key,wakeup' to indicate key can
wake-up the device:
sm6115-fxtec-pro1x.dtb: gpio-keys: key-volume-up: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
index 3ce9875e932c..9b70a87906dc 100644
--- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
@@ -44,7 +44,7 @@ key-volume-up {
gpios = <&pm6125_gpios 5 GPIO_ACTIVE_LOW>;
debounce-interval = <15>;
linux,can-disable;
- gpio-key,wakeup;
+ wakeup-source;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 34+ messages in thread* Re: [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup
2023-06-17 17:15 ` [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup Krzysztof Kozlowski
@ 2023-06-19 13:15 ` Konrad Dybcio
0 siblings, 0 replies; 34+ messages in thread
From: Konrad Dybcio @ 2023-06-19 13:15 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Nikita Travkin, Stephan Gerhold, linux-arm-msm, devicetree,
linux-kernel
On 17.06.2023 19:15, Krzysztof Kozlowski wrote:
> Use 'wakeup-source' instead of 'gpio-key,wakeup' to indicate key can
> wake-up the device:
>
> sm6115-fxtec-pro1x.dtb: gpio-keys: key-volume-up: Unevaluated properties are not allowed ('gpio-key,wakeup' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> index 3ce9875e932c..9b70a87906dc 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts
> @@ -44,7 +44,7 @@ key-volume-up {
> gpios = <&pm6125_gpios 5 GPIO_ACTIVE_LOW>;
> debounce-interval = <15>;
> linux,can-disable;
> - gpio-key,wakeup;
> + wakeup-source;
> };
> };
> };
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (13 preceding siblings ...)
2023-06-17 17:15 ` [PATCH 15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup Krzysztof Kozlowski
@ 2023-06-17 18:25 ` Nikita Travkin
2023-07-10 5:07 ` (subset) " Bjorn Andersson
15 siblings, 0 replies; 34+ messages in thread
From: Nikita Travkin @ 2023-06-17 18:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, cros-qcom-dts-watchers,
Stephan Gerhold, linux-arm-msm, devicetree, linux-kernel
Krzysztof Kozlowski писал(а) 17.06.2023 22:15:
> st,lis2hh12 accelerometer binding does not allow interrupt-names:
>
> msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This indeed seems redundant... Thanks!
Reviewed-by: Nikita Travkin <nikita@trvn.ru>
> ---
> arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> index 7943bb619116..54d648972d35 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
> @@ -101,7 +101,6 @@ accelerometer@1d {
>
> interrupt-parent = <&tlmm>;
> interrupts = <115 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "INT1";
>
> st,drdy-int-pin = <1>;
> mount-matrix = "0", "1", "0",
^ permalink raw reply [flat|nested] 34+ messages in thread* Re: (subset) [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names
2023-06-17 17:15 [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Krzysztof Kozlowski
` (14 preceding siblings ...)
2023-06-17 18:25 ` [PATCH 01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names Nikita Travkin
@ 2023-07-10 5:07 ` Bjorn Andersson
15 siblings, 0 replies; 34+ messages in thread
From: Bjorn Andersson @ 2023-07-10 5:07 UTC (permalink / raw)
To: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, cros-qcom-dts-watchers, Nikita Travkin,
Stephan Gerhold, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski
On Sat, 17 Jun 2023 19:15:27 +0200, Krzysztof Kozlowski wrote:
> st,lis2hh12 accelerometer binding does not allow interrupt-names:
>
> msm8916-samsung-gt58.dtb: accelerometer@1d: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>
>
Applied, thanks!
[01/15] arm64: dts: qcom: msm8916-gt5: drop incorrect accelerometer interrupt-names
commit: c756d233715a899dd1cce4b1db4cbd50b0f55a9e
[02/15] arm64: dts: qcom: msm8916-l8150: correct light sensor VDDIO supply
commit: 6a541eaa6e8e5283efb993ae7a947bede8d01fa5
[03/15] arm64: dts: qcom: apq8016-sbc: drop label from I2C and SPI
commit: 031df8e650a8584d24c91fa64465e0660accd339
[04/15] arm64: dts: qcom: apq8096-db820c: drop label from I2C
commit: d4bbcf50baa9d7f70e97a3fd3b0d5e4f599a6217
[05/15] arm64: dts: qcom: msm8939: drop incorrect smp2p Hexagon properties
commit: 35cda57217adceee2f6bc738a1d98a2cccab709e
[06/15] arm64: dts: qcom: msm8996-xiaomi: drop label from I2C
commit: 368f8d196976e691af9cb8e61c9c852d574759fb
[07/15] arm64: dts: qcom: msm8996-xiaomi: use generic node names
commit: f7eb45427af670e48a9d28e6bbe7c6b8f68c3bfe
[08/15] arm64: dts: qcom: sc7180-aspire1: use generic ADC channel node names
commit: 0ec3a3e1b84bc27d482a6cab4e7ab7e2dd26ecf6
[10/15] arm64: dts: qcom: sc8180x: use generic ADC channel node names
commit: 978869867216e669b6bed11aa669317a11e0dc7a
[11/15] arm64: dts: qcom: sc8180x: align thermal node name with bindings
commit: 9ca4673201cc08df152a4ec054d81ae6a6895938
[12/15] arm64: dts: qcom: sc8180x-flex-5g: correct panel ports
commit: bee2dea5be813eafc7979c09854b447abd75dfd0
[13/15] arm64: dts: qcom: sc8180x-primus: correct panel ports
commit: 0f06e8cbd18e7f0e016f21c870f7d7af20ffd47e
[14/15] arm64: dts: qcom: sc8180x-flex-5g: align gpio-keys node name with bindings
commit: adc2ee325806e805f9d729f28dd1ac77dd82932a
[15/15] arm64: dts: qcom: sm6115-pro1x: fix incorrect gpio-key,wakeup
commit: c8df0c62cb6a21b98845c44c3539aa727874cd08
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 34+ messages in thread