From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E2BC433B4 for ; Thu, 29 Apr 2021 14:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A49886144E for ; Thu, 29 Apr 2021 14:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239032AbhD2Of2 (ORCPT ); Thu, 29 Apr 2021 10:35:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237406AbhD2Of0 (ORCPT ); Thu, 29 Apr 2021 10:35:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D1AC06138B for ; Thu, 29 Apr 2021 07:34:39 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lc7kO-0003XE-T9; Thu, 29 Apr 2021 16:34:32 +0200 Message-ID: Subject: Re: [PATCH 16/16] soc: imx: gpcv2: remove waiting handshake in power up From: Lucas Stach To: "Peng Fan (OSS)" , robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, p.zabel@pengutronix.de, krzk@kernel.org, agx@sigxcpu.org, marex@denx.de, andrew.smirnov@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ping.bai@nxp.com, frieder.schrempf@kontron.de, aford173@gmail.com, abel.vesa@nxp.com, Peng Fan Date: Thu, 29 Apr 2021 16:34:31 +0200 In-Reply-To: <20210429073050.21039-17-peng.fan@oss.nxp.com> References: <20210429073050.21039-1-peng.fan@oss.nxp.com> <20210429073050.21039-17-peng.fan@oss.nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Donnerstag, dem 29.04.2021 um 15:30 +0800 schrieb Peng Fan (OSS): > From: Peng Fan > > i.MX8MM has blk ctl module, the handshake can only finish after setting > blk ctl. The blk ctl driver will set the bus clk bit and the handshake > will finish there. we just add a delay and suppose the handshake will > finish after that. Instead of this patch, just drop patch 05/16 from this series. I think we should leave a comment in the code on why we aren't waiting for the handshake ack, as this is non-obvious from looking at the driver code.  Basically add a polished version of the commit log from this patch into the driver code. Regards, Lucas > Signed-off-by: Peng Fan > --- >  drivers/soc/imx/gpcv2.c | 8 -------- >  1 file changed, 8 deletions(-) > > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index 49dd137f6b94..04564017bfe9 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -251,14 +251,6 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) >   regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, >   domain->bits.hskreq, domain->bits.hskreq); >   > > > > - ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, > - reg_val, > - (reg_val & domain->bits.hskack), > - 0, USEC_PER_MSEC); > - if (ret) { > - dev_err(domain->dev, "failed to power up ADB400\n"); > - goto out_clk_disable; > - } >   } >   > > > >   /* Disable reset clocks for all devices in the domain */