Re: [PATCH 1/2] dt: bindings: leds: Add NCP5623 multi-LED Controller

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 03/02/2024 18:58, Abdel Alkuor wrote:
> NCP5623 is DC-DC multi-LED controller which can be used for
> RGB illumination or backlight LCD display. NCP5623
> provides 94% peak efficiency.

Drop marketing.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

It's dt-bindings.

> 
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
> ---
>  .../bindings/leds/onnn,ncp5623.yaml           | 98 +++++++++++++++++++
>  1 file changed, 98 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml b/Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml
> new file mode 100644
> index 000000000000..696bc7d8c8f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/onnn,ncp5623.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/onnn,ncp5623.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ON Semiconductor NCP5623 multi-LED Driver
> +
> +maintainers:
> +  - Abdel Alkuor <alkuor@gmail.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  NCP5623 Triple Output I2C Controlled LED Driver.
> +  https://www.onsemi.com/pdf/datasheet/ncp5623-d.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - onnn,ncp5623
> +
> +  reg:
> +    enum:

Instead "const", or just maxItems: 1


> +      - 0x38
> +
> +  multi-led:
> +    type: object
> +    $ref: leds-class-multicolor.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
> +    patternProperties:
> +      "^led@[0-2]$":
> +        type: object
> +        $ref: common.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          reg:
> +            description: Index of the LED.

Drop description, it is obvious.

> +            minimum: 0
> +            maximum: 2
> +
> +        required:
> +          - reg
> +          - color
> +
> +    required:
> +      - "#address-cells"
> +      - "#size-cells"



Best regards,
Krzysztof