From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2A9F477E20 for ; Tue, 1 Sep 2026 11:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788261201; cv=none; b=YZO3r4ACRBcxthPTslivWtrQJEd/bN+faR09VZ7cVgnXvvv5QUey8AXTC7d9at7wsHR/wgkS91nb86NuNVr3nTG4G6Usi7NcY4F1m+KRGG6UvXn5bJKHw/vPdklNj4mhPT1CLe73m+ktGMpU6tb2X2lKCPEaB8PkLQNoz4ctzdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788261201; c=relaxed/simple; bh=AaNe9MZxIXYGjk5dI2N/PB1VsZK8MLeqo4GjD+3C6zQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=huv6Bl7JVYlO7aSIP0WYodR9CoAYgOfLEkD4OZHVbhgw/FhTue8f68fU/97O986qpThXRdSbHVEg2UrNJigfhSDMF0SAAibqYSHzdMkziVS6JAC7BzjeiZaIh37vIOddJxNmBksoS04ZVZ98VpLOvuK7GqD4bAlzRJutUV5YBVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jx4l6QhH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UyiXSM7g; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jx4l6QhH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UyiXSM7g" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 681AJcIt2406425 for ; Tue, 1 Sep 2026 11:13:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cFbUjQY2bH6iNRxhmkr0nuklvoLwMw+Tg0iNHcY5+yQ=; b=jx4l6QhHhLbxYgAf 6XtVh53cT9TJsLneRXO5vUc86AD85+D27LVpMw0+fwLH/C5L/hBw24lsZWdvhs5x cyPH1xtHq8F1cIJma/61wA9QNXRd/KflxXPIiuD1989lTmjf2lEb9xWJCrtAkQwv MAjcwtK9oVs7FhRs02fCfnrgZYEBEOir7n1wbMRls7ZiyHhT9pvuBF4WefjGXF4L W8m3e/471Gc6tdhCm+N4m3JRW0QvIQqmRUJARhoqDDu2Gt1SaZvWlMuRc4HsZ9qk TWQUprJBuSquq2xL/8cs3f04+W6BS08/8e9CdNxF/gYguOBb6fk7kWfI/5VjzeVJ ObXp0g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gdp7r2022-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 01 Sep 2026 11:13:18 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-934a8cd3a8bso87902585a.3 for ; Tue, 01 Sep 2026 04:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788261198; x=1788865998; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cFbUjQY2bH6iNRxhmkr0nuklvoLwMw+Tg0iNHcY5+yQ=; b=UyiXSM7gtMpSSR8EU+F7TKJIu58o0+p5xy9qCOoL2DQFcFmp4I5EKrgzAlfprBLu+1 A2mMf/GzRVubgEC5NAfXL3S1Vt72hljjIK7g1x4KQ6JR1Yv5R9Qs1MhQhQbu5ohQJzIa Oy/5Vzl1vK6lb67TIHwSiOgoMTTIgmTiP6a6YESROxaf3/Q8cX4a9TMWYiOE56eQHZFP CGx3oxtPZN1C/cCZL1kC7UyeuyY9UIeYz94wZ7JdkC3KwLwZJHxKhr2Is1lCLTOg+jCT LuWagsp5AOYzBj8wxIvFJX6+JwVODOynYzmGbJuwPzqK3zM2gmQpw4Qe/6qW3m3TrCeo uzxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788261198; x=1788865998; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cFbUjQY2bH6iNRxhmkr0nuklvoLwMw+Tg0iNHcY5+yQ=; b=jOnxxyVkgF9u/tkfQBC2/16oO5DIuVuwSjy/Ei398gVHIi77Izg0H7fY3s1150IDjl MxBHklysAEOYI8xs6EmNuOBTAjJtw0vTRyxj9kVADMSHBnfSqKpqVFLn1y8q+7JI7Rqf CJ0qQOD4W2AG2XlKU341PaEz+yWYsD4o6TDWFMcZ4nCjeqLYui+7I6uq05X8GnJaB6Zk hap9Qpwp4Gt4kQtq6ZeuxtAfHO7n5tYTR6/mx9llCKlssHcAoUlCCp1oHPAqI8/D0NeL JfjsxVZX3P8/KCCKIy9EhYaKK49NlCvN2UVIVZSzq5uJfH01+baICvKZsI0WkMwk4h6y WwxQ== X-Forwarded-Encrypted: i=1; AHgh+Rp3PhlnNLEJmyIam07rL63sIkTStRh2Y9BC/yAI/YZtixtt716sBeUAlWZnutu4Zddk4flw0lWNg/5Y@vger.kernel.org X-Gm-Message-State: AFuF++kCee++byeh9i7L+//X1xmtubl808GCvRjoNdKauHPuZ01eDTxl zKfbSqehBE1Rk8vfbUgKYZ55Fhvwp7UeKabeTI0Capsij6M1ZRlZ7PMduURymooRL+Dx0FGmibE wcC6vS+By2b7XGyaWe8Gw78vaQvL71X71q7/ZfDLZl93W68lys8RXPdx75HR90yJi X-Gm-Gg: AR+sD10DLA/Z0h612q9iHYftXIdYUYrikE8nXUATBnMRV1KWfUsJxWg8FVDzsovLgnu mR6Xe4OMJtrcscVqyZj0gpy+dFuBTfZ1rfDfjS3h3ZseBJnO3PFimnRXlSi009eoOnys2Ivn5Z6 bSLuF6u6WoJzQnf8GE4YXxZnIXp/GJe+bXeoj1f/u2F32MCBXqNyAndBmovYBlJR1nJe5euutCL XBWPkPOYPc5+6/5DZaGACqabs8HRbm5T1k8q2VPh3b390z2b0N3iQk/eGhahv2ImjkxaDGda1rd wav2RL5jD0ucKhy6JYt8GH4qY1CU0t1Jy9Xt/axzWBOAMod8dJZ5eTKb58+sck4O15iIFIp4jl8 /cIQdCg1P4TmZD/Fxkhbo6A== X-Received: by 2002:a05:620a:462b:b0:937:6f83:e80f with SMTP id af79cd13be357-9392868735cmr1512935585a.1.1788261198139; Tue, 01 Sep 2026 04:13:18 -0700 (PDT) X-Received: by 2002:a05:620a:462b:b0:937:6f83:e80f with SMTP id af79cd13be357-9392868735cmr1512928885a.1.1788261197404; Tue, 01 Sep 2026 04:13:17 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c255f1b1443sm558216766b.41.2026.09.01.04.13.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2026 04:13:16 -0700 (PDT) Message-ID: Date: Tue, 1 Sep 2026 13:13:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: add HP OmniBook Ultra 14-kg0xxx To: Jason Pettit , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Qiang Yu , Nabige Aala , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260830-x2-hp-omnibook-ship-v1-0-9feada71dc79@oss.qualcomm.com> <20260830-x2-hp-omnibook-ship-v1-2-9feada71dc79@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260830-x2-hp-omnibook-ship-v1-2-9feada71dc79@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=beZbluPB c=1 sm=1 tr=0 ts=6a96b34e cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=fwwh0Dj8_06do4mu6XIA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAxMDA5OSBTYWx0ZWRfXwY2FbwpM+3go bA1/MRWug81ALHnUrV3XzAdzz61bY3XqLZxLxskSpTGZVPzfmbqVNEaj+EnKgsfshMIoLgJD4PX 5j5XVdTaVnPOFMa83vgDDandGThixZZW6HulyS2VHJ5HzYDJ9LFAivnW5MdnayfTzbpjkYcNu6z t4HdNXKm7MP/gBsggZggaRRoPk4Ivp9oqJNzqNpVNx3kJo03uvwYsJNVfOL4Sn5FRiGepLK2o3+ msy3VP7YyvsCpJdo0Rtv/vQsXrs+T73RBRSAtQhbdVN3UNq+apT0Ciu9Ve5WPFifHasAso2n/2d x05WDX8uB/EZnVNWqAMz9YmDT1/+JkSnrE8fjGAqnugFdSFuFD4K3aw8XFGgLG0ZQSli7J/VIKv tuop73vkjvzrw/8Qu/H+vKFvtYDu6NCrSsWUBXSr4mhZT3Yq7c0SgstYtClK/gc9wnByPW3a6M1 djXs9Clrn1wLRDWJwKw== X-Proofpoint-GUID: KqhJS4jKFIQaBj-rDDn6_w3gqhAAYlSK X-Proofpoint-ORIG-GUID: KqhJS4jKFIQaBj-rDDn6_w3gqhAAYlSK X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAxMDA5OSBTYWx0ZWRfXwVawDsSGCzDg Y4wIVzxPpgRTNZfa4LkgDLPohJ4UTACLjmQ2Alw1INb4ogsw7MtzdiyrvIF5ZJnsTR84dv1nLXq Ic6R0RWmVj9tRSIuQOU5xz+SnooIe+4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-01_03,2026-08-31_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609010099 On 8/30/26 11:56 PM, Jason Pettit wrote: > Add board support for HP OmniBook Ultra 14" Next Gen AI PC > (product SKU D29KLAS#ABA, board 8F03), a Snapdragon X2 Elite (Glymur) > laptop, using the "hp,omnibook-ultra-kg0xxx" / "qcom,glymur" compatible. [...] > + sound { > + compatible = "qcom,glymur-sndcard"; > + /* This board reuses GLYMUR-CRD-tplg.bin from linux-firmware */ > + model = "GLYMUR-CRD"; This should have its own model name, the topology repo has some existing infra to make reuse easy (aliases in the CMake file) [...] > +&gmu { > + status = "okay"; > +}; This is already enabled in glymur.dtsi > + > +&gpu { > + status = "okay"; > +}; > + > +/* keyboard: HID-over-I2C on i2c0 */ I think we can drop this comment (also a similar one near vreg_l2h_e0_0p88) [...] > +&tlmm { > + gpio-reserved-ranges = <4 4>, > + <10 2>, > + <44 4>, > + <65 1>, > + <90 1>; Do we know what these are used for? [...] > +/* usb_0: 2nd USB-C port (host + DP alt-mode) */ These comments I also find a little unnecesasry Konrad