* Re: [PATCH 2/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart [not found] ` <20260316-ultrarisc-serial-v1-2-c464f3e933a5@ultrarisc.com> @ 2026-03-16 4:39 ` Yao Zi 2026-03-16 11:20 ` Conor Dooley 1 sibling, 0 replies; 3+ messages in thread From: Yao Zi @ 2026-03-16 4:39 UTC (permalink / raw) To: Jia Wang, Ilpo Järvinen, Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-kernel, linux-serial, linux-riscv, devicetree On Mon, Mar 16, 2026 at 09:36:19AM +0800, Jia Wang wrote: > Add UltraRISC vendor-prefix information You don't add any new vendor prefixes in this patch. This commit message should probably be updated. > Add DP1000 UART compatible information > > Signed-off-by: Jia Wang <wangjia@ultrarisc.com> And the dt-bindings patch should go before the driver changes. > --- > Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 2 ++ > 1 file changed, 2 insertions(+) Best regards, Yao Zi ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart [not found] ` <20260316-ultrarisc-serial-v1-2-c464f3e933a5@ultrarisc.com> 2026-03-16 4:39 ` [PATCH 2/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart Yao Zi @ 2026-03-16 11:20 ` Conor Dooley 1 sibling, 0 replies; 3+ messages in thread From: Conor Dooley @ 2026-03-16 11:20 UTC (permalink / raw) To: Jia Wang Cc: Ilpo Järvinen, Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-serial, linux-riscv, devicetree [-- Attachment #1: Type: text/plain, Size: 1148 bytes --] On Mon, Mar 16, 2026 at 09:36:19AM +0800, Jia Wang wrote: > Add UltraRISC vendor-prefix information > Add DP1000 UART compatible information $subject: update bindings of ultrarisc dp1000 uart You're not updating, you're adding it. > > Signed-off-by: Jia Wang <wangjia@ultrarisc.com> > --- > Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > index 6efe43089a74..0040ed28e35b 100644 > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > @@ -78,6 +78,8 @@ properties: > - starfive,jh7100-uart > - starfive,jh7110-uart > - const: snps,dw-apb-uart > + - items: > + - const: ultrarisc,dp1000-uart > - const: snps,dw-apb-uart This doesn't look right to me. An items list with one const is just the same as having "const", like the snps,dw-apb-uart entry below it. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20260316-ultrarisc-serial-v1-1-c464f3e933a5@ultrarisc.com>]
* Re: [PATCH 1/2] riscv: ultrarisc: 8250_dw: support DP1000 uart [not found] ` <20260316-ultrarisc-serial-v1-1-c464f3e933a5@ultrarisc.com> @ 2026-03-16 11:22 ` Conor Dooley 0 siblings, 0 replies; 3+ messages in thread From: Conor Dooley @ 2026-03-16 11:22 UTC (permalink / raw) To: Jia Wang Cc: Ilpo Järvinen, Andy Shevchenko, Greg Kroah-Hartman, Jiri Slaby, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel, linux-serial, linux-riscv, devicetree, Zhang Xincheng [-- Attachment #1: Type: text/plain, Size: 2778 bytes --] On Mon, Mar 16, 2026 at 09:36:18AM +0800, Jia Wang wrote: > From: Zhang Xincheng <zhangxincheng@ultrarisc.com> > > The UART of DP1000 does not support automatic detection of > buffer size. skip_autocfg needs to be set to true > > Signed-off-by: Zhang Xincheng <zhangxincheng@ultrarisc.com> > Signed-off-by: Jia Wang <wangjia@ultrarisc.com> $subject: riscv: ultrarisc: 8250_dw: support DP1000 uart Please update this to match other modifications to this file. "riscv: ultrariscv" doesn't belong at the start. > --- > drivers/tty/serial/8250/8250_dw.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index db73b2ae17fa..6a2acf173331 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -56,6 +56,7 @@ > #define DW_UART_QUIRK_IS_DMA_FC BIT(3) > #define DW_UART_QUIRK_APMC0D08 BIT(4) > #define DW_UART_QUIRK_CPR_VALUE BIT(5) > +#define DW_UART_QUIRK_FIXED_TYPE BIT(6) > > struct dw8250_platform_data { > u8 usr_reg; > @@ -514,6 +515,11 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) > data->data.dma.prepare_tx_dma = dw8250_prepare_tx_dma; > data->data.dma.prepare_rx_dma = dw8250_prepare_rx_dma; > } > + if (quirks & DW_UART_QUIRK_FIXED_TYPE) { > + p->flags |= UPF_FIXED_TYPE; > + p->type = PORT_16550A; > + data->skip_autocfg = true; > + } > if (quirks & DW_UART_QUIRK_APMC0D08) { > p->iotype = UPIO_MEM32; > p->regshift = 2; > @@ -789,6 +795,11 @@ static const struct dw8250_platform_data dw8250_skip_set_rate_data = { > .quirks = DW_UART_QUIRK_SKIP_SET_RATE, > }; > > +static const struct dw8250_platform_data dw8250_ultrarisc_dp1000_data = { > + .usr_reg = DW_UART_USR, > + .quirks = DW_UART_QUIRK_FIXED_TYPE, > +}; > + > static const struct of_device_id dw8250_of_match[] = { > { .compatible = "snps,dw-apb-uart", .data = &dw8250_dw_apb }, > { .compatible = "cavium,octeon-3860-uart", .data = &dw8250_octeon_3860_data }, > @@ -796,6 +807,7 @@ static const struct of_device_id dw8250_of_match[] = { > { .compatible = "renesas,rzn1-uart", .data = &dw8250_renesas_rzn1_data }, > { .compatible = "sophgo,sg2044-uart", .data = &dw8250_skip_set_rate_data }, > { .compatible = "starfive,jh7100-uart", .data = &dw8250_skip_set_rate_data }, > + { .compatible = "ultrarisc,dp1000-uart", .data = &dw8250_ultrarisc_dp1000_data }, > { /* Sentinel */ } > }; > MODULE_DEVICE_TABLE(of, dw8250_of_match); > > -- > 2.34.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-16 11:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260316-ultrarisc-serial-v1-0-c464f3e933a5@ultrarisc.com>
[not found] ` <20260316-ultrarisc-serial-v1-2-c464f3e933a5@ultrarisc.com>
2026-03-16 4:39 ` [PATCH 2/2] dt-bindings: serial: update bindings of ultrarisc dp1000 uart Yao Zi
2026-03-16 11:20 ` Conor Dooley
[not found] ` <20260316-ultrarisc-serial-v1-1-c464f3e933a5@ultrarisc.com>
2026-03-16 11:22 ` [PATCH 1/2] riscv: ultrarisc: 8250_dw: support DP1000 uart Conor Dooley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox