From: Alex Elder <elder@riscstar.com>
To: Herve Codina <herve.codina@bootlin.com>
Cc: bhelgaas@google.com, robh@kernel.org, daniel@riscstar.com,
mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] PCI: of: make a flags argument optional
Date: Wed, 19 Aug 2026 09:22:54 -0500 [thread overview]
Message-ID: <abeaacbc-95eb-4465-85ef-4d88095138b4@riscstar.com> (raw)
In-Reply-To: <20260819122247.6ccfc7ff@bootlin.com>
On 8/19/26 5:22 AM, Herve Codina wrote:
> Hi Alex,
>
> On Wed, 12 Aug 2026 12:22:46 -0500
> Alex Elder <elder@riscstar.com> wrote:
>
>> The address of a u32 object is passed to of_pci_get_addr_flags() so
>> it can be filled with the computed flags value.
>>
>> Allow a null pointer to be passed, so that the validity of the
>> resource's flags can be checked without filling in the flags value.
>>
>> Signed-off-by: Alex Elder <elder@riscstar.com>
>> ---
>> drivers/pci/of_property.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>
> Ok but nothing in the series call of_pci_get_addr_flags() with a NULL flags
> argument.
You're right. This is needed for the dynamic range update series.
https://lore.kernel.org/lkml/20260813220717.1394644-1-elder@riscstar.com/
I'll move it out of this series and into that one.
-Alex
>
> Is this modification really needed in this series?
>
> Best regards
> Hervé
>
next prev parent reply other threads:[~2026-08-19 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 17:22 [PATCH v2 0/4] PCI: of: warn on bogus device_type property Alex Elder
2026-08-12 17:22 ` [PATCH v2 1/4] PCI: of: drop the reg_num argument to of_pci_set_address() Alex Elder
2026-08-12 17:28 ` sashiko-bot
2026-08-12 17:22 ` [PATCH v2 2/4] PCI: of: don't zero flags in of_pci_get_addr_flags() Alex Elder
2026-08-12 17:27 ` sashiko-bot
2026-08-12 17:22 ` [PATCH v2 3/4] PCI: of: make a flags argument optional Alex Elder
2026-08-12 17:29 ` sashiko-bot
2026-08-19 10:22 ` Herve Codina
2026-08-19 14:22 ` Alex Elder [this message]
2026-08-12 17:22 ` [PATCH v2 4/4] PCI: of: introduce of_pci_verify_node() Alex Elder
2026-08-12 17:28 ` sashiko-bot
2026-08-19 10:20 ` Herve Codina
2026-08-19 14:23 ` Alex Elder
2026-08-19 10:22 ` [PATCH v2 0/4] PCI: of: warn on bogus device_type property Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abeaacbc-95eb-4465-85ef-4d88095138b4@riscstar.com \
--to=elder@riscstar.com \
--cc=bhelgaas@google.com \
--cc=daniel@riscstar.com \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.bianconi@oss.qualcomm.com \
--cc=mohd.anwar@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox