From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D31C56201 for ; Tue, 27 Oct 2020 19:22:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1FFD2224E for ; Tue, 27 Oct 2020 19:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qijb1sXa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S371915AbgJ0TUr (ORCPT ); Tue, 27 Oct 2020 15:20:47 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42911 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1829597AbgJ0TRx (ORCPT ); Tue, 27 Oct 2020 15:17:53 -0400 Received: by mail-lj1-f195.google.com with SMTP id h20so3063242lji.9; Tue, 27 Oct 2020 12:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ifIWTd3Ns3z5oJhEjPKk2k9PCzO7a2NWGp66DijjkQk=; b=Qijb1sXa3G16lZSKA+nEkMxTIFLBrOUy5Rr9ZwMWzohV066o4tDSKTy574Ssd2HZZh E2Fya2EazJhBeeVSaKb/aoec4Xjb3Sg/S4tal9lKtluK/G1J06H5EFvkpePIUcIIQP2g 7U2rOnrH/qSw85t6v9OUvCjIUIQ04tUXCftdChd+osjOsMgsnvfxh4itMs3zC+xHgGvX gGzBF7NcJIdI8YEIfWlQDa//AsReWvaZGwbaNR+GAJoMmtu1Z14PmNoJrw8Oxw2vehJv M/QQl1LS3HTPuzC/JaB3lNxk9IX1y2oJeYxSq5skCG1eaUleaZv24CBcN51vTntgmiUu PvaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ifIWTd3Ns3z5oJhEjPKk2k9PCzO7a2NWGp66DijjkQk=; b=aCmUr2F2aLYFFKhR5if3uAZ2KQiJZ6WbOEPxSuxUzn7bfaFIBwEcWBy2IMbpJa6o1q /cN+WvfXQXxrr+5GM8YwwrUpzlgSif4pqxYeaPdMv8mlCNAfqV9cs2RCtAmU1xdPeBFG AA9+MzqbhR0SeeZw0bLvMoyhGSVMWIstqyrMhtEEJRQzHQyhyqZSl2rOUO0dDRnTfOWX 3KQwjg2ZmXi6J6EjM+BTsBbDxKC34FxVHaXCDTHDF2Dam8OX8ipA+rn2wsOfMEnG/gyJ hH96dsW9BoXqr/HmH3qx6ul/0GBwBazL7BRTADJNg4h0HhWyc2KAnGB+hzZ4hcgihONX HOuA== X-Gm-Message-State: AOAM530SIIGxJFvfCALY97PnHWCTaB/7blCWSnt3Hl98oDJgnv4P0Omk KST1e7noGTji3KawL8cypTSomxBN/ho= X-Google-Smtp-Source: ABdhPJyPI9JpflgVqg2iXiOFHiXQeJRvyXlDI/bHczUvMHXIiq4h5JDmIqgByTyJAgr+vMgcI23YaA== X-Received: by 2002:a2e:8985:: with SMTP id c5mr1866622lji.406.1603826269920; Tue, 27 Oct 2020 12:17:49 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id y7sm151668lff.153.2020.10.27.12.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 12:17:49 -0700 (PDT) Subject: Re: [PATCH v6 05/52] dt-bindings: memory: tegra20: mc: Document new interconnect property To: Krzysztof Kozlowski Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-6-digetx@gmail.com> <20201027085548.GE4244@kozik-lap> From: Dmitry Osipenko Message-ID: Date: Tue, 27 Oct 2020 22:17:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027085548.GE4244@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 27.10.2020 11:55, Krzysztof Kozlowski пишет: > On Mon, Oct 26, 2020 at 01:16:48AM +0300, Dmitry Osipenko wrote: >> Memory controller is interconnected with memory clients and with the >> External Memory Controller. Document new interconnect property which >> turns memory controller into interconnect provider. >> >> Acked-by: Rob Herring >> Signed-off-by: Dmitry Osipenko >> --- >> .../bindings/memory-controllers/nvidia,tegra20-mc.txt | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt >> index e55328237df4..739b7c6f2e26 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt >> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt >> @@ -16,6 +16,8 @@ Required properties: >> IOMMU specifier needed to encode an address. GART supports only a single >> address space that is shared by all devices, therefore no additional >> information needed for the address encoding. >> +- #interconnect-cells : Should be 1. This cell represents memory client. >> + The assignments may be found in header file . > > This is a list of required properties so you break the ABI. All existing > DTBs will be affected. This is optional property for the older DTBs, but for newer DTs it's mandatory. IIUC, it should be defined as a required property in the binding. Please see tegra_mc_interconnect_setup() in "memory: tegra-mc: Add interconnect framework", which check presence of the ICC DT property.