From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1281C13B288 for ; Thu, 14 Nov 2024 15:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731597934; cv=none; b=XslMGUzOuasJhHlPsQReDfMHFxhim2SXPDnHXYJ2H8dC7BJyPel0syFAuGq2+2SObdwhws7yUN9I8dviOE9jmPywCDlcrR4OLD6LSX1BHH92Md+OY1lWph80qSu/5z/OM7rmwsq7zbV8MGBbvTrYOQ8JNw5kGEdWfB3+ExBL/v4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731597934; c=relaxed/simple; bh=yCNfpNDzwbET0LEuXl0osl4EyrXHRcoLor+RqoNIT9M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lkjnWl5LFM50+q4e1JEKk2DNZeq05BSkIJas5Ny5/C3kTy6DRSQVK0t1KxXk3cMfO+lhi6gdBBuHKFA3spWtEywMe7pkTlKRh9tLkpMCA+Jd+NwqwOg+yMnkE4RC159pKbG97W8tNaBbVUMeHa4CAnMZxEOqVKn34444fTu2WWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=fail smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R7dZLa0b; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R7dZLa0b" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AE6l0uo028186 for ; Thu, 14 Nov 2024 15:25:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 77Uxb2WKa15F5RlNtYFFhLRjfJru9BUZrxBhSgyxq1Y=; b=R7dZLa0bxgFu8heQ hYjjlXMBKY6UuVf7g7G/pBjXtCgqHWhO4/EjJuViaogxOKU7+qb+dmFlbA/3rkY6 hmD6yVU55eLplKiOr4u3MCTslUkcOItfLEwO4Wlus6/XsKN0z52Ymd3sx0duef+h ZpMxNDMW+vdYi2oluKCYW/GSiJE44wVKe76rku89JCZC5ck5VHq4OBSZDk/a5yTm Tpiirxm/RjJCBbosbOMSMmfZTk1bjfkip9sX4YuzsQDB4NbaCizDt4aUPxv852c2 bSB9s8n+dwDEZGoEOfFI8H9KnBJXPp51v3IqGderpIqpRZIxtv8OsnLVnPGypB0B vqcFRw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42w10jv2fm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 14 Nov 2024 15:25:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4634796c2cbso1483771cf.1 for ; Thu, 14 Nov 2024 07:25:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731597931; x=1732202731; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=77Uxb2WKa15F5RlNtYFFhLRjfJru9BUZrxBhSgyxq1Y=; b=QYv2h8GP5mS3Ahc5bDOfxnpPyZknTz6fnTHkWyK7G1bKraqqxrYnYmzBzxujoVD+95 sa8/XJBOQVg2krFmp3gjJV2ZLR0AqXoDsPCm8gaj/vHztd25PcVAV845tdImWoX4y+Ws 7A2SR4+JqLsGkWSGXMwV7IpfAWYUOVeuyRzvS31USHNce3bcumb93blQXNjEsZLHWjS1 bFx5I7OyO3bwvYJfJO2v2Eeqa86sztvE+adxvOJd7fD+mY3S0+X9Vlx3Y9pMcHDNm2yA 4UB7p4UJZgGBlc1/waHHtAgr6MYqOO1yRZ8+kqOtCt3857B1XEsjHwcTrOpCr+IdDnpH Er4g== X-Forwarded-Encrypted: i=1; AJvYcCWZvpMgDUNoh8ftoUhLyY/wvayd5r7zK13z4XOGr1HxlAVvUOsIf2M3NbmM8tXTSqSsoeyc5iWTRcUU@vger.kernel.org X-Gm-Message-State: AOJu0YzInh6YkTDOXnwbFeR5cI1Az4SFA5HofHmKZg0RtqM0M8svNMrH F/foIY/QzZ6BBrJ0iF7Ty4JHmNJ9apW1653utZ5If2FLH1vkKe4cc2J9n9dSb4w1w1bLPTbLzq/ uTQr8dD92pO/P/mUcv7DBscKILrivdQvCif6chKwtdjJazHE6Pf9XHeqQAQrg X-Gm-Gg: ASbGnct/dujtRqiNLqLEn+NO6QkeKufsrh1nHBiy5QMOkufgakry1Dcshb4Jtttiboh Xxbg6cdW81kv8QTGspMyDaUAfRQ3jwaKmNgU1BEXSjbIj4UME9TG5ezh9TVtN8g/gqZhbRSFtRI TlBgw/3NvIItZ173PwTTne3kT+0IWf5FL+bMC0kEDugGmMCkb/HyCHpCAW9cVWKZ1vavxebqcou W8fdWNWQjY/YvKuZp/+DcnZan14Q0PKvUTjbLv+GSDbrtpKg1xO8S5mxvEgKV9xxJCgC2f0dLD9 NQ3rps7Fhu4ywk1K8pRRdUT+SlzaZ5o= X-Received: by 2002:ac8:5e4e:0:b0:463:5517:ffdf with SMTP id d75a77b69052e-46355180066mr29516301cf.16.1731597931063; Thu, 14 Nov 2024 07:25:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhRByPw5EKbcCygzJSeTHFTucdQZ7slWUPQDlZW+UZ6sjz9iRDzTlgGCHFVd6ZGQW1YCrwpw== X-Received: by 2002:ac8:5e4e:0:b0:463:5517:ffdf with SMTP id d75a77b69052e-46355180066mr29515961cf.16.1731597930690; Thu, 14 Nov 2024 07:25:30 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf79a44a9dsm700093a12.0.2024.11.14.07.25.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 07:25:30 -0800 (PST) Message-ID: Date: Thu, 14 Nov 2024 16:25:27 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 5/5] arm64: dts: qcom: x1e80100: Add support for PCIe3 on x1e80100 To: Qiang Yu , Johan Hovold Cc: manivannan.sadhasivam@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, andersson@kernel.org, konradybcio@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, abel.vesa@linaro.org, quic_msarkar@quicinc.com, quic_devipriy@quicinc.com, dmitry.baryshkov@linaro.org, kw@linux.com, lpieralisi@kernel.org, neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, johan+linaro@kernel.org References: <20241101030902.579789-1-quic_qianyu@quicinc.com> <20241101030902.579789-6-quic_qianyu@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: dR3J5FY7Ib1bxgPnQzgxG4XiPFo_AuSa X-Proofpoint-GUID: dR3J5FY7Ib1bxgPnQzgxG4XiPFo_AuSa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=911 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411140120 On 13.11.2024 4:15 AM, Qiang Yu wrote: > > On 11/13/2024 1:29 AM, Johan Hovold wrote: >> On Mon, Nov 11, 2024 at 11:44:17AM +0800, Qiang Yu wrote: >>> On 11/5/2024 1:28 PM, Qiang Yu wrote: >>>> On 11/4/2024 10:35 PM, Johan Hovold wrote: >>>>> On Thu, Oct 31, 2024 at 08:09:02PM -0700, Qiang Yu wrote: >>>>>> +            ranges = <0x01000000 0x0 0x00000000 0x0 0x78200000 0x0 >>>>>> 0x100000>, >>>>>> +                 <0x02000000 0x0 0x78300000 0x0 0x78300000 0x0 >>>>>> 0x3d00000>, >>>>> Can you double check the size here so that it is indeed correct and not >>>>> just copied from the other nodes which initially got it wrong: >>>>> >>>>>      https://lore.kernel.org/lkml/20240710-topic-barman-v1-1-5f63fca8d0fc@linaro.org/ >>> BTW, regions of PCIe6a, PCIe4, PCIe5 are 64MB, 32MB, 32MB, respectively. >>> Why range size is set to 0x1d00000 for PCIe6a, any issue is reported on >>> PCIe6a? >> Thanks for checking. It seems the patch linked to above was broken for >> PCIe6a then. >> >> We did see PCIe5 probe breaking due to the overlap with PCIe4 but the >> patch predates PCIe5 support being posted and merged so it was probably >> just based on inspection. >> >> Could you send a fix for PCIe6a? > Sure, will send the fix. So the patch I posted made it match the DSDT/Windows state. I assumed there must have been something wrong as docs suggested the value that you did. But both work. In case any issues pop up, we can revisit this. Konrad