From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Erikas Bitovtas <xerikasxx@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 6/7] iio: light: vcnl4000: use variables for I2C client and device instances
Date: Mon, 16 Mar 2026 22:03:33 +0200 [thread overview]
Message-ID: <abhiFdSAs2RbnGVT@ashevche-desk.local> (raw)
In-Reply-To: <20260316-vcnl4000-regulators-v4-6-854fc2eaf54b@gmail.com>
On Mon, Mar 16, 2026 at 07:19:50PM +0200, Erikas Bitovtas wrote:
> After moving data->client and client->dev into variables of their own,
> replace all instances of data->client and client->dev being used in
> vcnl4200_init and vcnl4000_probe by the said variables to reduce
vcnl4200_init()
vcnl4000_probe()
> clutter.
...
> - if (device_property_read_u32(&client->dev, "proximity-near-level",
> - &data->near_level))
> - data->near_level = 0;
> + device_property_read_u32(dev, "proximity-near-level", &data->near_level);
I meant to see this change in a separate patch after the current one.
This will be associated with a commit message explaining why it's okay
because it looks like a potential behaviour change (but actually not).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-16 20:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 17:19 [PATCH v4 0/7] iio: light: vcnl4000: add regulator support Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 1/7] dt-bindings: iio: light: vcnl4000: add regulators Erikas Bitovtas
2026-03-17 7:20 ` Krzysztof Kozlowski
2026-03-17 8:07 ` Erikas Bitovtas
2026-03-17 15:42 ` Krzysztof Kozlowski
2026-03-18 12:47 ` Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 2/7] iio: light: vcnl4000: sort includes by their name Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 3/7] iio: light: vcnl4000: move power enablement from init to probe Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 4/7] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 5/7] iio: light: vcnl4000: remove error messages for trigger and irq Erikas Bitovtas
2026-03-16 17:19 ` [PATCH v4 6/7] iio: light: vcnl4000: use variables for I2C client and device instances Erikas Bitovtas
2026-03-16 20:03 ` Andy Shevchenko [this message]
2026-03-16 17:19 ` [PATCH v4 7/7] iio: light: vcnl4000: add support for regulators Erikas Bitovtas
2026-03-16 20:05 ` Andy Shevchenko
2026-03-16 19:59 ` [PATCH v4 0/7] iio: light: vcnl4000: add regulator support Andy Shevchenko
2026-03-16 20:20 ` Erikas Bitovtas
2026-03-16 21:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abhiFdSAs2RbnGVT@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox