From: Bjorn Andersson <andersson@kernel.org>
To: Xin Liu <xin.liu@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com,
jie.gan@oss.qualcomm.com
Subject: Re: [PATCH v2] arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types
Date: Wed, 18 Mar 2026 08:42:24 -0500 [thread overview]
Message-ID: <abqrLY8mLiAGugPK@baldur> (raw)
In-Reply-To: <20260226054113.4156874-1-xin.liu@oss.qualcomm.com>
On Wed, Feb 25, 2026 at 09:41:13PM -0800, Xin Liu wrote:
> Add support for SYSTEM_RESET2 vendor-specific resets as
> reboot-modes in the psci node. Describe the resets: "bootloader"
> will cause device to reboot and stop in the bootloader's fastboot
> mode. "edl" will cause device to reboot into "emergency download
> mode", which permits loading images via the Firehose protocol.
>
> Signed-off-by: Xin Liu <xin.liu@oss.qualcomm.com>
How did you test this? I tried to apply this, but I'm getting 52 counts
of:
xyz.dtb: psci (arm,psci-1.0) 'reboot-mode' does not match any of the regexes: '^pinctrl-[0-9]+$', '^power-domain-'
Am I doing something wrong?
Regards,
Bjorn
> ---
> Changes in v2:
> - Fix mode-bootloader and mode-edl reset_type
> - Link to v1 : https://lore.kernel.org/all/20260209042700.1186392-1-xin.liu@oss.qualcomm.com/
>
> arch/arm64/boot/dts/qcom/hamoa.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> index db65c392e618..a1bd8c3e4061 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> @@ -450,6 +450,11 @@ system_pd: power-domain-system {
> #power-domain-cells = <0>;
> /* TODO: system-wide idle states */
> };
> +
> + reboot-mode {
> + mode-bootloader = <0x80010001 0x2>;
> + mode-edl = <0x80000000 0x1>;
> + };
> };
>
> reserved-memory {
> --
> 2.43.0
>
prev parent reply other threads:[~2026-03-18 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 5:41 [PATCH v2] arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types Xin Liu
2026-03-18 13:42 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abqrLY8mLiAGugPK@baldur \
--to=andersson@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=xin.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox