From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89E6D3D6674; Wed, 18 Mar 2026 13:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841347; cv=none; b=azI8uNa3ecO0GIJCDlJlL/7nAeNSTZdtxMsTslIL+TJIgFkkzUHfpriSZekmxr+QVvQjZq8baHiswZ2pR3o1T2leJ6H5vAjEttBDQLtfyzZAwFUya4kZx4w0isLJFDTkiZOVxaILDnXhPzedkcJrGc1zi0R1xOB9k6MZ7Ro7WE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773841347; c=relaxed/simple; bh=+E2Rot07NbcgB7zSsv56vz0z9u43QAN6vdk3enX4pBA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fkcxCNyv99lNpkcd/QVQy1BED3hv4Awgpm5MtM4Yv41UZNKspPlQoCTk0cJkBvuBYjR/xgnyVviYItX7wcthV64L5nnEkndkmESwRXNnT9ee/MxQiy/mwiM06GdfbqJoD4v170tgNYOeANy1u538Xl23L+FcPuJ3skJdWr8eYgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fms4/vDl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fms4/vDl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05C41C19421; Wed, 18 Mar 2026 13:42:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773841347; bh=+E2Rot07NbcgB7zSsv56vz0z9u43QAN6vdk3enX4pBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fms4/vDlN03vWoEms+p0AJN80vDgcXrAIMy6UV7pUNwX7G9W485He2/OklYtX7bWY dBGSvi1kowKe2k8TRLpg0VfzEle9TatY0p4KXtgLDWVlPMt9POQ9BI9l71nq+zx59T o/cUL8ImhZ7KFFX4lc4so4yqIVeFR6kqD3ZRjq4jboBEGJkdW30JAStwOh24uUJxu9 QQAXFy9nRbMnViWWU22uwIOxpvEqbxWbr7xaud4OQ6lE5UWbKiMCv16NYmNWYXAyBe iGXzvGHvAQMnIyx8K2WylPrFe1kIugBnbzObkWcsy3utIHO4OQFGLGsT1mWlCUMWRq ClUSZUcPdj9xw== Date: Wed, 18 Mar 2026 08:42:24 -0500 From: Bjorn Andersson To: Xin Liu Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v2] arm64: dts: qcom: hamoa: Add PSCI SYSTEM_RESET2 types Message-ID: References: <20260226054113.4156874-1-xin.liu@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226054113.4156874-1-xin.liu@oss.qualcomm.com> On Wed, Feb 25, 2026 at 09:41:13PM -0800, Xin Liu wrote: > Add support for SYSTEM_RESET2 vendor-specific resets as > reboot-modes in the psci node. Describe the resets: "bootloader" > will cause device to reboot and stop in the bootloader's fastboot > mode. "edl" will cause device to reboot into "emergency download > mode", which permits loading images via the Firehose protocol. > > Signed-off-by: Xin Liu How did you test this? I tried to apply this, but I'm getting 52 counts of: xyz.dtb: psci (arm,psci-1.0) 'reboot-mode' does not match any of the regexes: '^pinctrl-[0-9]+$', '^power-domain-' Am I doing something wrong? Regards, Bjorn > --- > Changes in v2: > - Fix mode-bootloader and mode-edl reset_type > - Link to v1 : https://lore.kernel.org/all/20260209042700.1186392-1-xin.liu@oss.qualcomm.com/ > > arch/arm64/boot/dts/qcom/hamoa.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi > index db65c392e618..a1bd8c3e4061 100644 > --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi > +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi > @@ -450,6 +450,11 @@ system_pd: power-domain-system { > #power-domain-cells = <0>; > /* TODO: system-wide idle states */ > }; > + > + reboot-mode { > + mode-bootloader = <0x80010001 0x2>; > + mode-edl = <0x80000000 0x1>; > + }; > }; > > reserved-memory { > -- > 2.43.0 >