Re: [PATCH v20 01/10] power: reset: reboot-mode: Remove devres based allocations

Shivendra Pratap
2026-03-12T08:54:38Z

On 11-03-2026 14:51, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Mar 04, 2026 at 11:33:01PM +0530, Shivendra Pratap wrote:
>> Devres APIs are intended for use in drivers, where the managed lifetime
>> of resources is tied directly to the driver attach/detach cycle. In
>> shared subsystem code, there is no guarantee that the subsystem
>> functions will only be called after a driver has been attached, nor that
>> they will not be referenced after the managed resources have been
>> released during driver detach.
>>
>> To ensure correct lifetime handling, avoid using devres-based
>> allocations in the reboot-mode and explicitly handle allocation and
>> cleanup of resources.
>>
>> Fixes: 4fcd504edbf7 ("power: reset: add reboot mode driver")
>> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
>> ---
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> The patch does not apply, though.

thanks. Will re-base it.

thanks,
Shivendra