devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Caleb Connolly <caleb.connolly@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qrb2210-rb1: use USB host mode
Date: Thu, 26 Oct 2023 21:05:13 +0200	[thread overview]
Message-ID: <ac0aea1f-5e4f-4611-951d-037a4370384c@linaro.org> (raw)
In-Reply-To: <d7fcb16d-1fe8-4be4-8f20-18ddcd2c2913@linaro.org>



On 10/26/23 21:04, Caleb Connolly wrote:
> 
> 
> On 26/10/2023 19:56, Konrad Dybcio wrote:
>>
>>
>> On 10/25/23 13:58, Caleb Connolly wrote:
>>> The default for the QCM2290 platform that this board is based on is OTG
>>> mode, however the role detection logic is not hooked up for this board
>>> and the dwc3 driver is configured to not allow role switching from
>>> userspace.
>>>
>>> Force this board to host mode as this is the preferred usecase until we
>>> get role switching hooked up.
>> Does that not kill usb internet and similar?
> 
> like rndis gadget? yes, it does kill that. But in return you get real
> ethernet ;P
> 
> This is the preferred default configuration for these boards (I sent a
> similar patch for rb2 before). The usb_role framework does have support
> for letting userspace change the role via sysfs, but it's disabled for
> dwc3. The plan is to enable role switching properly by reading the DIP
> switch state in the future.
Ok all that sounds reasonable

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

  reply	other threads:[~2023-10-26 19:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 11:58 [PATCH] arm64: dts: qcom: qrb2210-rb1: use USB host mode Caleb Connolly
2023-10-26 18:56 ` Konrad Dybcio
2023-10-26 19:04   ` Caleb Connolly
2023-10-26 19:05     ` Konrad Dybcio [this message]
2023-10-30 15:58 ` Dmitry Baryshkov
2023-12-08  2:57 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac0aea1f-5e4f-4611-951d-037a4370384c@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=caleb.connolly@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).