From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
linux-kernel@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
Stephan Gerhold <stephan@gerhold.net>,
Nikita Travkin <nikita@trvn.ru>,
soc@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht,
Joe Mason <buddyjojo06@outlook.com>,
Siddharth Manthan <siddharth.manthan@gmail.com>
Subject: Re: [PATCH 6/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add accelerometer/magnetometer
Date: Thu, 22 Jun 2023 17:17:59 +0200 [thread overview]
Message-ID: <ac12c499-a4d5-74c7-42ec-f9789253108e@linaro.org> (raw)
In-Reply-To: <20230622000418.48350-1-linmengbo0689@protonmail.com>
On 22/06/2023 02:05, Lin, Meng-Bo wrote:
> From: Joe Mason <buddyjojo06@outlook.com>
>
> gprimeltecan and grandprimelte use a Bosch BMC150, and fortuna3g has
> ST LSM303C accelerometer/magnetometer combo.
> fortunaltezt and rossa have only ST LIS2HH12 accelerometer.
>
> Add support for them.
>
> Signed-off-by: Joe Mason <buddyjojo06@outlook.com>
> [Add LSM303C]
> Signed-off-by: Siddharth Manthan <siddharth.manthan@gmail.com>
> [Move sensors to fortuna.dtsi. Disable them by default]
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> [Enable on grandprimelte. Add LIS2HH12]
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
> ---
> .../dts/qcom/msm8216-samsung-fortuna3g.dts | 8 ++
> .../qcom/msm8916-samsung-fortuna-common.dtsi | 80 +++++++++++++++++++
> .../dts/qcom/msm8916-samsung-fortunaltezt.dts | 8 ++
> .../dts/qcom/msm8916-samsung-gprimeltecan.dts | 8 ++
> .../qcom/msm8916-samsung-grandprimelte.dts | 8 ++
> .../qcom/msm8916-samsung-rossa-common.dtsi | 8 ++
Your split of patches is difficult to follow and understand. You bring
now, within your first submission, few boards. Then adding one feature
to this board is not a separate commit. Commit, so a logical change, is
adding a board. Please organize your patchset so it will be easier to
review. Now with such changes touching multiple files, seems not
organized correctly. Your previous patch added multiple boards in one
commit - also not easy to review.
One commit for the binding, one commit for each board. Optionally common
file could be a separate commit.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-22 15:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 0:00 [PATCH 0/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees Lin, Meng-Bo
2023-06-22 0:03 ` [PATCH 1/7] dt-bindings: qcom: Document new msm8916-samsung devices Lin, Meng-Bo
2023-06-22 0:03 ` [PATCH 2/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees Lin, Meng-Bo
2023-06-22 0:04 ` [PATCH 3/7] ARM: dts: qcom-msm8916-samsung-fortuna: Include dts from arm64 Lin, Meng-Bo
2023-06-22 0:04 ` [PATCH 4/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add rt5033 battery Lin, Meng-Bo
2023-06-22 0:04 ` [PATCH 5/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add touchscreen Lin, Meng-Bo
2023-06-22 0:05 ` [PATCH 6/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add accelerometer/magnetometer Lin, Meng-Bo
2023-06-22 15:17 ` Krzysztof Kozlowski [this message]
2023-06-22 0:05 ` [PATCH 7/7] arm64: dts: qcom: msm8916-samsung-fortuna: Add NFC Lin, Meng-Bo
2023-06-22 15:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac12c499-a4d5-74c7-42ec-f9789253108e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=buddyjojo06@outlook.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linmengbo0689@protonmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=siddharth.manthan@gmail.com \
--cc=soc@kernel.org \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).