From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: rob.clark@oss.qualcomm.com,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: arm: qcom: Add Lenovo Yoga Slim 7x Gen11
Date: Thu, 11 Jun 2026 15:48:15 +0200 [thread overview]
Message-ID: <ac191a18-bcb4-4fa5-a179-b72a6ac928cb@kernel.org> (raw)
In-Reply-To: <uieb6ukjokwnppc5zfr6bjychqsnpikwmiy7j7dmt2kgk7k4zi@2stv37ijv36o>
On 10/06/2026 15:31, Abel Vesa wrote:
>>>>>> @@ -68,6 +68,7 @@ properties:
>>>>>>
>>>>>> - items:
>>>>>> - enum:
>>>>>> + - lenovo,yoga-slim7x-gen11
>>>>>
>>>>> I imagine you might want different panel variants, just like T14s has
>>>>> LCD and OLED?
>>>>
>>>> I expect this will be the case.
>>>
>>> Then better to prepare for this now, otherwise later you need to change
>>> bindings. If unsure what other variants are, then at least make this
>>> compatible panel-specific, e.g. lenovo,yoga-slim7x-gen11-oled-foo-bar.
>>
>> I took another look at psref [1] and there's only OLED SKUs (today?).
>> There are however, two different resolutions available and both can be
>> touch/notouch.
>
> If the other SKU doesn't have touch, then you might as well mark now this
> one with touch suffix or something like that.
If you decide not to have any changes (new compatibles), then at least
please document the above reasoning in commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-11 13:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 8:06 [PATCH 0/4] X2 Elite Lenovo Yoga Slim 7x Gen11 support Konrad Dybcio
2026-06-04 8:06 ` [PATCH 1/4] dt-bindings: display: panel: samsung,atna33xc20: Add ATNA40HQ08-0 Konrad Dybcio
2026-06-04 15:05 ` Krzysztof Kozlowski
2026-06-04 21:23 ` Doug Anderson
2026-06-05 15:28 ` Rob Herring
2026-06-05 15:44 ` Doug Anderson
2026-06-05 17:14 ` Rob Herring
2026-06-05 22:41 ` Doug Anderson
2026-06-04 8:06 ` [PATCH 2/4] dt-bindings: arm: qcom: Add Lenovo Yoga Slim 7x Gen11 Konrad Dybcio
2026-06-04 15:09 ` Krzysztof Kozlowski
2026-06-04 15:13 ` Rob Clark
2026-06-04 15:18 ` Krzysztof Kozlowski
2026-06-10 12:12 ` Konrad Dybcio
2026-06-10 13:31 ` Abel Vesa
2026-06-11 13:48 ` Krzysztof Kozlowski [this message]
2026-06-12 16:05 ` Rob Herring
2026-06-04 8:06 ` [PATCH 3/4] arm64: dts: qcom: Add Glymur-based " Konrad Dybcio
2026-06-04 8:22 ` sashiko-bot
2026-06-04 9:59 ` Gopikrishna Garmidi
2026-06-08 9:05 ` Konrad Dybcio
2026-06-04 8:06 ` [PATCH 4/4] firmware: qcom: scm: Allow QSEECOM on " Konrad Dybcio
2026-06-04 13:40 ` Dmitry Baryshkov
2026-06-09 7:23 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac191a18-bcb4-4fa5-a179-b72a6ac928cb@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rob.clark@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox