From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jae Hyun Yoo Subject: Re: [PATCH 3/5] i2c: aspeed: fix master pending state handling Date: Tue, 8 Oct 2019 14:13:22 -0700 Message-ID: References: <20191007231313.4700-1-jae.hyun.yoo@linux.intel.com> <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com> <20191008203157.GA184092@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191008203157.GA184092@google.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Brendan Higgins Cc: Mark Rutland , devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Benjamin Herrenschmidt , openbmc@lists.ozlabs.org, Rob Herring , Joel Stanley , Tao Ren , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org List-Id: devicetree@vger.kernel.org On 10/8/2019 1:31 PM, Brendan Higgins wrote: > On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote: >> In case of master pending state, it should not trigger the master >> command because this H/W is sharing the same data buffer for slave >> and master operations, so this commit fixes the issue with making >> the master command triggering happen when the state goes to active >> state. > > nit: Makes sense, but can you explain what might happen without your > change? If we don't use this fix, a master command could corrupt data in the shared buffer if H/W is still on processing slave operation at the timing. >> Signed-off-by: Jae Hyun Yoo > > Reviewed-by: Brendan Higgins Thanks a lot for your review! -Jae