From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
bjorn.andersson@linaro.org, dianders@chromium.org,
jinghung.chen3@hotmail.com
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
konrad.dybcio@somainline.org
Subject: Re: [PATCH V2 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE
Date: Tue, 8 Nov 2022 11:53:06 +0100 [thread overview]
Message-ID: <ac2e80d9-0abf-a5ef-d425-559a2125af33@linaro.org> (raw)
In-Reply-To: <e5b529c7-865c-b5d1-c3bf-dc6b162431d7@quicinc.com>
On 08/11/2022 11:10, Sibi Sankar wrote:
> Krzysztof,
> Thanks for taking time to review the series.
>
>
> On 11/8/22 15:04, Krzysztof Kozlowski wrote:
>> On 08/11/2022 10:22, Sibi Sankar wrote:
>>> When the modem node was re-located to a separate LTE source file
>>> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
>>> weren't marked appropriately. Fix this by marking all Qualcomm
>>> reference devices as LTE.
>>>
>>> Fix-suggested-by: Douglas Anderson <dianders@chromium.org>
>>
>> There is no such tag. If it is a fix, use Reported-by. If it is not, use
>> Suggested-by.
>
> lol I should have just stuck with S-b but found the tag being used a
> number of times. I'll fix this up if the series warrants a re-spin.
It indeed appears in the log. Once (since v5.15). So that's a mistake,
not practice. Common tags are described here:
- Documentation/process/submitting-patches.rst
- scripts/checkpatch.pl
Best regards,
Krzysztof
prev parent reply other threads:[~2022-11-08 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:22 [PATCH V2 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE Sibi Sankar
2022-11-08 9:22 ` [PATCH V2 2/2] arm64: dts: qcom: sc7280: Add Google Herobrine WIFI SKU dts fragment Sibi Sankar
2022-11-08 9:34 ` [PATCH V2 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE Krzysztof Kozlowski
2022-11-08 10:10 ` Sibi Sankar
2022-11-08 10:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2e80d9-0abf-a5ef-d425-559a2125af33@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jinghung.chen3@hotmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).