From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17A13563F6 for ; Thu, 2 Apr 2026 04:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775105265; cv=none; b=Kwu+UGP0GglhDVhVdz5caX6AN0VeAm+9ffldlhNjfpJu1rhpfzgHLW+TZWG0wpDdE1yT6LJU46JL9fNy/T8lkxIntGIFwEgDLxKxgZ36xruASyhqErtHrTs+vGvz/hHWCZpMr+SoPxq2vD4e+pVa1wZ+kTySsIr2lhccSqWQpZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775105265; c=relaxed/simple; bh=wk2CEsRe94TXY0TOzVrShJauVcawcTr12uXI7AppV/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UpV2YIbSjibIXU1cz2X6AlfX8gtPoLg3nUNfpypiXaIn7IBPeJxFDmqXxWOmSoZI9aHtGOMcjcL4orPAg1YhnOLVqzeHNWpOLsMfjMF0PaT85kJ/FhujVCBhC1qtNLjCKzmqv4XD5CK8e+nb8SW1fYNMSVQBL4K2WVpwLOfiXqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SEqhM3WP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A/zLNUCp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SEqhM3WP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A/zLNUCp" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 631M4LO94009752 for ; Thu, 2 Apr 2026 04:47:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=igGS0tjH9YzgaYiuHHy2F++w pOEywQ8Ju4ax1XR2ztU=; b=SEqhM3WPToVXRXdrnsJa5le8wU6bFb8I3c6lPXtS b+LzVnFe67tRzd/skIVSyuH9XK0bfuhWUySShUldL0molg8V5AwCYLML2Fjz6RRN d88JgVDjjdIRz8Q6njwCkaD2CYI1AUS2FDTTrmAY9jdBnLynsawtObJfN3TtZKqZ A4pA/MakLdXz5cbpQchrCSjSYB3GCFAiqjM2VwBwhw3QMSIFNKMwPbeHsiZh2xRT myP3vMK5yw1r0AEZeqGDudv5wRXxwB8ilSVJ0I5aROArtneYB67laeOVzBwh6en3 XdDvjJTGWCTWtnyM3uvJJdPIDBq/qKva8UQOPWiSKNiNYA== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d97e02308-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 04:47:42 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2c7130f88e3so4457980eec.0 for ; Wed, 01 Apr 2026 21:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775105261; x=1775710061; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=igGS0tjH9YzgaYiuHHy2F++wpOEywQ8Ju4ax1XR2ztU=; b=A/zLNUCp/xiTk1fxfGhmIhWVhcbrsnXr2eCEHuDRDCLic5GKWKGUS+59gxY7SoUYKL UEj3JwRgL27fKQr8xTm7/z08KIRgUAszyvSEL5kyNWdUUj9BSF+S/cJCZvphwkuuMHRT qV/WrrSG240aI+87yYs0wEVQyJwJ1EwC4AjeszGVDXBReDkW/Ml6uM0Tz+jZxlJg9shG lcMYrZbMVjJZuP+1t9/jpDETYYRlBG1nMpEDAvc4L3bcFojm8pgXrrYlUyOBOBP0kqea /R1+xIqG5IkaG/6uaIGVXWwj/6qa24M5CdOcY5TUdfwLGHTIbkLRIVXiPFUYiO5XGKYc ZhYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775105261; x=1775710061; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igGS0tjH9YzgaYiuHHy2F++wpOEywQ8Ju4ax1XR2ztU=; b=X7MiyqWjfg/ZVwMe+o6znDP5WHaHTq8VOLUsMxnImVoGcqGhhEvH8whsn8R0AeSLlc wyokdKQs8Hzz1tEEj5k1auAHSXDsjwCyj/h43GcBFT8l7t/7goa1yhtyQ35k8CC7a6md V7gj8KG7g6ClrT0fRqbDivalT5FTC05f/ufTuposfXgubJKaUohcnxLiev9kEn2gyqwb LalnyBqxIRUWtxV13ZQ1HUELl7/6Eu3UFA8pNIM7mi7bvNz8KVGeepYEp1iAf4WNLlAm umAZEZle/s6k8lo6Fxper9Fx16SYLhL+NwkT1QFERSRj69wfisZkvoGzcYKjhXsN6GuI b7iQ== X-Forwarded-Encrypted: i=1; AJvYcCUG2tkN4k8rbAIJQwxcD6E3+Q/1buaKq8gDQaswGSUs9Q1Z+MmVTjLmd9+fFP5tUdDERvUBVjO5kugM@vger.kernel.org X-Gm-Message-State: AOJu0Yw73GTXruGNHg6DO+oF2nkR1zdODJV4/06sxFQL1/4Li+dNEtM7 YhXI212cdZgr4cugeqfRhhixrxd2aL5s2nUVzYbsHdvXdKSLMG+x3W0bf5iifi+DYO9n7++nbgV 059ftYTPjqz6H5sOXA7xY1Kkvy1flHDpnh+oAxLXZ/wji4BavOi9AohMg7vz93SwQ X-Gm-Gg: ATEYQzwYUolsQcTVpQBq51hJ9rZkQfweJHpsd11ED6L1v7YO13iUNF8mNpiii7H5njd QxXzRBDA0oNr5F5Sb44cuHMcw12n3H/HghLM+I8zvHUmEkIjYpXkouDgoaEhfZJECkFkvYwEpqU x3YoDCzY8PS/jDxi9H84nwc7rJAIwXWydJH/OAT3BhL0ilX/b4rvpk/v6ndsufJnAAOHx10+PX6 /0ATT/MdG99XrOHR8arrlVaMZxSSlr12DAKwfNOepqu+XTgN5RFSaulB4EO+W7UdxNPbq476knr b1v2faHDxDWdIVmUXwQaz1fgcUcOYpLQHiVReuwjL9JI7PUdMvBcF7ME7wSsbDxu8EEio2yESOY 4JFsC0YVYsdXA3a0z5zRABFg2tGis5osgSmR6Wm1PxN3PQRh5qIx9K0AMe6bTZtbGiGMP X-Received: by 2002:a05:7300:2213:b0:2c5:b972:b436 with SMTP id 5a478bee46e88-2c9329a0e60mr3038430eec.23.1775105261425; Wed, 01 Apr 2026 21:47:41 -0700 (PDT) X-Received: by 2002:a05:7300:2213:b0:2c5:b972:b436 with SMTP id 5a478bee46e88-2c9329a0e60mr3038410eec.23.1775105260720; Wed, 01 Apr 2026 21:47:40 -0700 (PDT) Received: from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca78df5ec7sm1482412eec.3.2026.04.01.21.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 21:47:40 -0700 (PDT) Date: Wed, 1 Apr 2026 21:47:38 -0700 From: Qiang Yu To: Taniya Das Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , johan@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 3/4] clk: qcom: tcsrcc-glymur: Migrate tcsr_pcie_N_clkref_en to clk_ref common helper Message-ID: References: <20260331-qref_vote-v1-0-3fd7fbf87864@oss.qualcomm.com> <20260331-qref_vote-v1-3-3fd7fbf87864@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authority-Analysis: v=2.4 cv=fdGgCkQF c=1 sm=1 tr=0 ts=69cdf4ee cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=pj5R1tjK13g_stPiHOsA:9 a=CjuIK1q_8ugA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: Lyk_kME612RdOFUJD4gUbfPmnC5hxxc4 X-Proofpoint-GUID: Lyk_kME612RdOFUJD4gUbfPmnC5hxxc4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDAzOSBTYWx0ZWRfX1sTglbGNHehO 8i01AnULF9/Pdxe/eYNwXRs0MiiB/a4SXhbV7y9KJDiQpsUpjVd6TV3CnNbLOyBb7JN0BG7Wymm 7u38wWRfdaaXF4PvINnylgSAt8O8RipXu9kzbPgMpLgJJq+fx+GYXXrqMFJvegCksWz9r4ZXPhB Mjtazh1TSAnuyRiWdkGlZ93mzqGxyQcIhgd1M1DWp3lJ7aLIEO4E5wWuCln9ABGdwhz6Ld/NX9X EJ4PjUtdSDypE5i2hO/EBolW0SQXwSdB7GxpU+u4/YklwLN1gnW7ELsVDUogIxKanfaD9Wv1nzY yOkStsWHcuMDASZvQgfsN/SoPvqumpeSVdFYjMzjGb6OuB+Y7Cn1FWA8xeXYOpvU+X4sxdimf+P jb2IW1KGoABADQyFAhcMSQrw8dmYUdSCpavEzvSQGSToN1rp/cRl/5USWg4HVmo2Q+Buv3RefD1 wrXMU+e6vW6EEMc1cDA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020039 On Wed, Apr 01, 2026 at 10:05:12PM +0530, Taniya Das wrote: > > > On 4/1/2026 12:05 PM, Qiang Yu wrote: > > Replace local clk_branch-based clkref definitions with descriptor-based > > registration via qcom_clk_ref_probe(). > > > > This keeps the glymur driver focused on clock metadata and reuses common > > runtime logic for regulator handling, enable/disable sequencing, and OF > > provider wiring. > > > > Signed-off-by: Qiang Yu > > --- > > drivers/clk/qcom/tcsrcc-glymur.c | 340 +++++++++++---------------------------- > > 1 file changed, 93 insertions(+), 247 deletions(-) > > > > diff --git a/drivers/clk/qcom/tcsrcc-glymur.c b/drivers/clk/qcom/tcsrcc-glymur.c > > index 9c0edebcdbb12816d1be5249e4f04bcaf02048aa..585f87b23af2d92daef1787b2f38911681c0d8ee 100644 > > --- a/drivers/clk/qcom/tcsrcc-glymur.c > > +++ b/drivers/clk/qcom/tcsrcc-glymur.c > > @@ -4,265 +4,115 @@ > > */ > > > > #include > > +#include > > #include > > #include > > +#include > > #include > > #include > > > > #include > > > > -#include "clk-alpha-pll.h" > > -#include "clk-branch.h" > > -#include "clk-pll.h" > > -#include "clk-rcg.h" > > -#include "clk-regmap.h" > > -#include "clk-regmap-divider.h" > > -#include "clk-regmap-mux.h" > > -#include "common.h" > > -#include "gdsc.h" > > -#include "reset.h" > > - > > -enum { > > - DT_BI_TCXO_PAD, > > -}; > > - > > -static struct clk_branch tcsr_edp_clkref_en = { > > - .halt_reg = 0x60, > > - .halt_check = BRANCH_HALT_DELAY, > > - .clkr = { > > - .enable_reg = 0x60, > > - .enable_mask = BIT(0), > > - .hw.init = &(const struct clk_init_data) { > > - .name = "tcsr_edp_clkref_en", > > - .parent_data = &(const struct clk_parent_data){ > > - .index = DT_BI_TCXO_PAD, > > - }, > > - .num_parents = 1, > > - .ops = &clk_branch2_ops, > > - }, > > +static const char * const tcsr_pcie_1_regulators[] = { > > + "vdda-refgen-0p9", > > + "vdda-refgen-1p2", > > + "vdda-qrefrx5-0p9", > > + "vdda-qreftx0-0p9", > > + "vdda-qreftx0-1p2", > > +}; > > + > > +static const char * const tcsr_pcie_2_regulators[] = { > > + "vdda-refgen-0p9", > > + "vdda-refgen-1p2", > > + "vdda-qreftx1-0p9", > > + "vdda-qrefrpt0-0p9", > > + "vdda-qrefrpt1-0p9", > > + "vdda-qrefrpt2-0p9", > > + "vdda-qrefrx2-0p9", > > +}; > > + > > +static const char * const tcsr_pcie_3_regulators[] = { > > + "vdda-refgen-0p9", > > + "vdda-refgen-1p2", > > + "vdda-qreftx1-0p9", > > + "vdda-qrefrpt0-0p9", > > + "vdda-qrefrpt1-0p9", > > + "vdda-qrefrx1-0p9", > > +}; > > + > > +static const char * const tcsr_pcie_4_regulators[] = { > > + "vdda-refgen-0p9", > > + "vdda-refgen-1p2", > > + "vdda-qreftx1-0p9", > > + "vdda-qrefrpt0-0p9", > > + "vdda-qrefrpt1-0p9", > > + "vdda-qrefrpt2-0p9", > > + "vdda-qrefrx2-0p9", > > +}; > > + > > TCSR clock refs are just not for PCIe alone, they would have supplies > for all the ref clocks. These supplies can also be shared across other > clock refs. I think it is not the correct way to handle the supplies, as > TCSR does not have the complete supplies map. > We have complete supplies map. You can get it on ipcatlog. Here is example for other instances eg USB and EDP: - Glymur (eDP): CXO PAD -> TX0 -> RPT0 -> RX0 -> eDP - Glymur (USB4_2): CXO PAD -> TX0 -> RPT0 -> RPT1 -> RX1 -> USB4_2 - Glymur (USB3): CXO PAD -> TX0 -> RPT3 -> RPT4 -> RX4 -> USB3_SS3 I only add supplies for PCIe in this series because USB and EDP vote these LDO in their PHY driver. They can remove them in PHY dts node and add same regulator list here. - Qiang Yu > > > +static const struct qcom_clk_ref_desc tcsr_cc_glymur_clk_descs[] = { > > + [TCSR_EDP_CLKREF_EN] = { > > + .name = "tcsr_edp_clkref_en", > > + .offset = 0x60, > > }, > > -}; > > > > > -- > Thanks, > Taniya Das >