From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD158C433E0 for ; Mon, 8 Mar 2021 05:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FF8B651F6 for ; Mon, 8 Mar 2021 05:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234352AbhCHFVW (ORCPT ); Mon, 8 Mar 2021 00:21:22 -0500 Received: from z11.mailgun.us ([104.130.96.11]:31351 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232491AbhCHFVW (ORCPT ); Mon, 8 Mar 2021 00:21:22 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615180882; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=On2mi/7W7Su/V+3JcCXfzENs8FDIIHK/FTwZ3xaUj+0=; b=UfAsM+AnRtI9KriMZe7bb9VRP9p7lc8meqv3zCZHkr6IdYms7WHoesuFMVY31Dk7+qtCNf3+ VJuTJRfU8U1TsY6O3FGS7cGfxnViiO9CgRl88lz+YofNw6bjbj37FDA7PG35BdCQbj+9q72W dKTju95A3njDUagcPusp5AubT7o= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 6045b4472a5e6d1bfab92a2e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 08 Mar 2021 05:21:11 GMT Sender: mkshah=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EE9DCC433C6; Mon, 8 Mar 2021 05:21:10 +0000 (UTC) Received: from [192.168.29.129] (unknown [49.36.79.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mkshah) by smtp.codeaurora.org (Postfix) with ESMTPSA id 83B81C433CA; Mon, 8 Mar 2021 05:21:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 83B81C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=mkshah@codeaurora.org Subject: Re: [PATCH v2 05/14] arm64: dts: qcom: sc7280: Add RSC and PDC devices To: Rajendra Nayak , Stephen Boyd , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1614773878-8058-1-git-send-email-rnayak@codeaurora.org> <1614773878-8058-6-git-send-email-rnayak@codeaurora.org> <161481625091.1478170.8810587061043612400@swboyd.mtv.corp.google.com> <31bf64c5-26a4-dc23-3769-df7a7559083b@codeaurora.org> From: Maulik Shah Message-ID: Date: Mon, 8 Mar 2021 10:51:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <31bf64c5-26a4-dc23-3769-df7a7559083b@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 3/5/2021 11:12 AM, Rajendra Nayak wrote: > > On 3/4/2021 5:34 AM, Stephen Boyd wrote: >> Quoting Rajendra Nayak (2021-03-03 04:17:49) >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> index 4a56d9c..21c2399 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >>> @@ -30,6 +31,18 @@ >>>                  }; >>>          }; >>>   +       reserved_memory: reserved-memory { >> >> Do we plan to use this label at any point? I'd prefer we remove this >> until it becomes useful. > > sure, i'll drop it > >> >>> +               #address-cells = <2>; >>> +               #size-cells = <2>; >>> +               ranges; >>> + >>> +               aop_cmd_db_mem: memory@80860000 { >>> +                       reg = <0x0 0x80860000 0x0 0x20000>; >>> +                       compatible = "qcom,cmd-db"; >>> +                       no-map; >>> +               }; >>> +       }; >>> + >>>          cpus { >>>                  #address-cells = <2>; >>>                  #size-cells = <0>; >>> @@ -203,6 +229,7 @@ >>>                          interrupt-controller; >>>                          #interrupt-cells = <2>; >>>                          gpio-ranges = <&tlmm 0 0 175>; >>> +                       wakeup-parent = <&pdc>; >>>                            qup_uart5_default: qup-uart5-default { >>>                                  pins = "gpio46", "gpio47"; >>> @@ -287,6 +314,23 @@ >>>                                  status = "disabled"; >>>                          }; >>>                  }; >>> + >>> +               apps_rsc: rsc@18200000 { >> >> Any better name than 'rsc'? Maybe 'power-controller'? > > hmm, Maulik, any thoughts? This would perhaps need the bindings docs > to be updated as well (and maybe the existing platform DTs using rsc too) I think we should be good with rsc (resource-state-coordinator). RSC itself don't do any resource power management. Thanks, Maulik > >> >>> +                       compatible = "qcom,rpmh-rsc"; >>> +                       reg = <0 0x18200000 0 0x10000>, >>> +                             <0 0x18210000 0 0x10000>, >>> +                             <0 0x18220000 0 0x10000>; >>> +                       reg-names = "drv-0", "drv-1", "drv-2"; >>> +                       interrupts = , >>> +                                    , >>> +                                    ; >>> +                       qcom,tcs-offset = <0xd00>; >>> +                       qcom,drv-id = <2>; >>> +                       qcom,tcs-config = , >>> +                                         , >>> +                                         , >>> +                                         ; >>> +               }; >>>          }; > -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation