devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties
@ 2022-11-04 16:24 Rob Herring
  2022-11-06 10:32 ` Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring @ 2022-11-04 16:24 UTC (permalink / raw)
  To: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
	Krzysztof Kozlowski
  Cc: linux-pm, devicetree, linux-kernel

The examples' cache nodes are incomplete as 'cache-unified' and
'cache-level' are required cache properties.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
index 850a9841b110..7bb9327caa13 100644
--- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
+++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
@@ -76,9 +76,13 @@ examples:
                     next-level-cache = <&L2_0>;
                     L2_0: l2-cache {
                             compatible = "cache";
+                            cache-unified;
+                            cache-level = <2>;
                             next-level-cache = <&L3_0>;
                             L3_0: l3-cache {
                                     compatible = "cache";
+                                    cache-unified;
+                                    cache-level = <3>;
                             };
                     };
           };
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties
  2022-11-04 16:24 [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties Rob Herring
@ 2022-11-06 10:32 ` Krzysztof Kozlowski
  2022-11-06 17:53 ` Amit Kucheria
  2022-12-06  1:34 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-06 10:32 UTC (permalink / raw)
  To: Rob Herring, Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria,
	Zhang Rui, Krzysztof Kozlowski
  Cc: linux-pm, devicetree, linux-kernel

On 04/11/2022 17:24, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties
  2022-11-04 16:24 [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties Rob Herring
  2022-11-06 10:32 ` Krzysztof Kozlowski
@ 2022-11-06 17:53 ` Amit Kucheria
  2022-12-06  1:34 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Amit Kucheria @ 2022-11-06 17:53 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Krzysztof Kozlowski,
	linux-pm, devicetree, linux-kernel

On Fri, Nov 4, 2022 at 9:55 PM Rob Herring <robh@kernel.org> wrote:
>
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Amit Kucheria <amitk@kernel.org>

> ---
>  .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> index 850a9841b110..7bb9327caa13 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> +++ b/Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> @@ -76,9 +76,13 @@ examples:
>                      next-level-cache = <&L2_0>;
>                      L2_0: l2-cache {
>                              compatible = "cache";
> +                            cache-unified;
> +                            cache-level = <2>;
>                              next-level-cache = <&L3_0>;
>                              L3_0: l3-cache {
>                                      compatible = "cache";
> +                                    cache-unified;
> +                                    cache-level = <3>;
>                              };
>                      };
>            };
> --
> 2.35.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties
  2022-11-04 16:24 [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties Rob Herring
  2022-11-06 10:32 ` Krzysztof Kozlowski
  2022-11-06 17:53 ` Amit Kucheria
@ 2022-12-06  1:34 ` Rob Herring
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-12-06  1:34 UTC (permalink / raw)
  To: Rob Herring
  Cc: Rafael J. Wysocki, Krzysztof Kozlowski, Zhang Rui, linux-pm,
	Daniel Lezcano, Amit Kucheria, devicetree, linux-kernel

On Fri, 04 Nov 2022 11:24:50 -0500, Rob Herring wrote:
> The examples' cache nodes are incomplete as 'cache-unified' and
> 'cache-level' are required cache properties.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/thermal/thermal-cooling-devices.yaml  | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-06  1:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-04 16:24 [PATCH] dt-bindings: thermal: cooling-devices: Add missing cache related properties Rob Herring
2022-11-06 10:32 ` Krzysztof Kozlowski
2022-11-06 17:53 ` Amit Kucheria
2022-12-06  1:34 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).