From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5154CECAAD1 for ; Wed, 31 Aug 2022 15:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbiHaPUT (ORCPT ); Wed, 31 Aug 2022 11:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbiHaPUM (ORCPT ); Wed, 31 Aug 2022 11:20:12 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3A1D20F71 for ; Wed, 31 Aug 2022 08:20:07 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id p7so9287525lfu.3 for ; Wed, 31 Aug 2022 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=20Vr5j6nd++c5ftjotZW+yVR5V1oPbMNKTijzFjKl40=; b=aFdbIJ1+Aq1TthvYLh/QfpRdG6+FgfQi2YYYS+K4e6JOV5wtYhP98ejYf6VDFji/OJ ICt084TZEi6kmkyiQibhsdEV6QVbDwt5WOHGW3v+GFYI6ihOKHiA9SKHiVk90iBP0ZqJ hJXJm9fPTxpCJEAwKaTQ+zNyqnbz108n7P8OLbkjtDoaZeeUQZcZV1bqAJSp3oWJHFI0 gFdbhrjNHn3Pd5WK3IIlvuJ8yhFVc5vKx0lfSQehyKfIno7o9IRfwCo9wRv3u8pB/ZLN 9+UMbFigaQ4POikSJCwK5AABjrB/1BOP6gTL9agtKRg3JRsomBQmNOIYg/lqhCUU7TMW aH/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=20Vr5j6nd++c5ftjotZW+yVR5V1oPbMNKTijzFjKl40=; b=gTbVqY5vYAxiqq9ZiTFHMr2+d6/Iboikhpin9sPfmAe/nqfc59tr9Ty2LhkDyeOxSJ WQy/v7vgOhXv+YXRlPjkBCJvvgv4Z+NFSrr1J2nL9zSnARdxSEKUCRNhjZqJUrAhKYc7 HcsrXDKJRhhcmvBzI5CTL90gtaIs1nyZu+e0bYL02Psd6XbJLrnw2pb9PIrKGRY9MB4W ITM01oKLomzxDdr6NfjyivtW/YNHKhQ5snOLmocTz/SYhVQhK99ZUGu56dwFQBBSjJr6 CHPdW2op+le1bN07uH++RoTBm1E4KLjuAsPlAYxX8pi3HQTfoIflCWRAsVipUpULgkeA vvRw== X-Gm-Message-State: ACgBeo0BQKBl1cyt0e0B7KV27FEUt209Le9qAJ//S5KZ+qRRelIa0g7d inMXmneu2rx6SCNPjpapd7ZLNA== X-Google-Smtp-Source: AA6agR6r4qgwUkkOS/Oe7+nmQM/2dnewUJ4KBVkWDdAxTuyTguGN+I9Dy6DNA4dStrUxkOrwELYsFw== X-Received: by 2002:ac2:4465:0:b0:493:b4:c4ac with SMTP id y5-20020ac24465000000b0049300b4c4acmr9046749lfl.446.1661959205933; Wed, 31 Aug 2022 08:20:05 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id y4-20020ac255a4000000b0048137a6486bsm1335295lfg.228.2022.08.31.08.20.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 08:20:05 -0700 (PDT) Message-ID: Date: Wed, 31 Aug 2022 18:20:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: renesas,fcp: Document RZ/{G2,V2}L FCPVD bindings Content-Language: en-US To: Biju Das , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski Cc: Laurent Pinchart , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20220831143722.2067457-1-biju.das.jz@bp.renesas.com> <20220831143722.2067457-2-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20220831143722.2067457-2-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2022 17:37, Biju Das wrote: > Document FCPVD found in RZ/G2L alike SoCs. FCPVD block is similar to > FCP for VSP found on R-Car SoC's . It has 3 clocks compared to 1 > clock on fcpv. Introduce new compatibles renesas,r9a07g044-fcpvd > for RZ/G2{L,LC} and renesas,r9a07g054-fcpvd for RZ/V2L to handle this > difference. > > The 3 clocks are shared between du, vspd and fcpvd. Update the bindings > to reflect this. > > No driver changes are required as generic compatible string > "renesas,fcpv" will be used as a fallback. > > Signed-off-by: Biju Das > --- > v1->v2: > * Documented RZ/{G2,V2}L FCPVD bindings > * Introduces new compatibles renesas,r9a07g0{44,54}-fcpvd > * Added clock-names property > * described clocks. > --- > .../bindings/media/renesas,fcp.yaml | 46 +++++++++++++++++-- > 1 file changed, 41 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > index 43f2fed8cd33..79a55694b2a2 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > @@ -21,15 +21,23 @@ description: | > > properties: > compatible: > - enum: > - - renesas,fcpv # FCP for VSP > - - renesas,fcpf # FCP for FDP > + oneOf: > + - items: No items here. You have just one item, so it is not a list. > + - enum: > + - renesas,fcpv # FCP for VSP > + - renesas,fcpf # FCP for FDP > + > + - items: > + - enum: > + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} > + - renesas,r9a07g054-fcpvd # RZ/V2L > + - const: renesas,fcpv # generic FCP for VSP fallback > > reg: > maxItems: 1 > > - clocks: > - maxItems: 1 > + clocks: true > + clock-names: true Both should have here the widest constraints: minItems:1 and maxItems:3. Best regards, Krzysztof