From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: "Frank Wunderlich" <linux@fw-web.de>,
linux-mediatek@lists.infradead.org,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Greg Ungerer" <gerg@kernel.org>,
"René van Dorst" <opensource@vdorst.com>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>
Subject: Re: Aw: Re: [RFC v2] dt-bindings: net: dsa: convert binding for mediatek switches
Date: Fri, 6 May 2022 09:15:12 +0200 [thread overview]
Message-ID: <ac70ae6d-7e1a-d6b9-e33e-793035d5606e@linaro.org> (raw)
In-Reply-To: <trinity-12061c77-38b6-4b56-bccd-3b54cf9dc0e8-1651819574078@3c-app-gmx-bs21>
On 06/05/2022 08:46, Frank Wunderlich wrote:
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 0
>>> +
>>> + core-supply:
>>> + description: |
>>
>> Drop | everywhere where it is not needed (so in all places, AFAICT)
>
> is it necessary for multiline-descriptions or is indentation enough?
It's necessary only when YAML syntax characters appear in description or
when you want specific formatting.
https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/example-schema.yaml#L97
https://yaml-multiline.info/
>>> +
>>> +patternProperties:
>>
>> patternProperties go before allOf, just after regular properties.
>
> after required, right?
properties do not go after required, so neither patternProperties
should. Something like: propertes -> patternProperties -> dependencies
-> required -> allOf -> additionalProperties -> examples
>
>>> + "^(ethernet-)?ports$":
>>> + type: object
>>
>> Also on this level:
>> unevaluatedProperties: false
>
> this is imho a bit redundant because in dsa.yaml (which is included now after patternProperties)
> it is already set on both levels.
dsa.yaml does not set it on ethernet-ports.
> Adding it here will fail in examples because of size/address-cells which are already defined in dsa.yaml...
> so i need to define them here again.
You're right, it cannot be set here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-06 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 15:00 [RFC v2] dt-bindings: net: dsa: convert binding for mediatek switches Frank Wunderlich
2022-05-05 20:29 ` Krzysztof Kozlowski
2022-05-06 6:46 ` Aw: " Frank Wunderlich
2022-05-06 7:15 ` Krzysztof Kozlowski [this message]
2022-05-06 14:08 ` Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac70ae6d-7e1a-d6b9-e33e-793035d5606e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=gerg@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).