From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FF8C433EF for ; Fri, 6 May 2022 07:15:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389438AbiEFHTA (ORCPT ); Fri, 6 May 2022 03:19:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231860AbiEFHS7 (ORCPT ); Fri, 6 May 2022 03:18:59 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F4040113 for ; Fri, 6 May 2022 00:15:15 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id ks9so6337049ejb.2 for ; Fri, 06 May 2022 00:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=BeRODHN5BKHdYqCpyT3vOELgLz8mBkeltgcKtiKMp4w=; b=g4TlTYxLR3HgIll7nXj0AF8/r89vyRr8TehXbuimjjfEYJccXGgABWYlPWVPZr3PYW g2VAiB6F3XUnbACivG4wyIHzNoFUNpjcaiA9kScMgL7fSMJzihnSNEqyOO88Apxph3/l G4URVFL2tqrQdjLTkPvZApvG0KAocTJPRzCwwj9ncv9ILchN5blI27jqGplvHCyVc/JH FbO529vOx597xt77lw6dgm5980DDVRJx2sLJcnexgLGqpMpEEZXImo9/n4+j2ZdTDIsX 9jDzhNjlO/o/QZlfMpBHPfEUDB9P0gpwBGGu1/xrrq2mUVVgfSHqz7RXsiPCwJc3vAPI HAHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BeRODHN5BKHdYqCpyT3vOELgLz8mBkeltgcKtiKMp4w=; b=QiAJ1QCKEd0w9MLPzm3OVGhwZJxrngolz672fMt9orC+X03U0l2Ud0z3DWS9su8G02 WgUvvQfh4i7lNh7jdHPO1kDKbiKCT4/4mMZMgNiHj4vfQ7AeKbrJ7DT4amNssSiK2CIW EilT3BM1lZEUbxQ+qqLR9vyMMAa8gAEiVSJlmXlNTl8prK8wubhUErc9XEj1qLv8ICnT A2jlmkK1YPgQZ7CXuW0DHw+4EayCzjCbdsjah3RPkPjRqWZpeL6D7pJxdLH3tfev00u/ XXPpn4w75CuIy+uEW5Sid452MqaSOaqvs3ebqrm12VFQwrfQho+b3g71W/3c2x6X6kG6 6O7w== X-Gm-Message-State: AOAM5330eQa8YcGRlVffYbVWnoc6brjXQTZV6aGTQrrgW2Iam6wa8238 01/3m0N0xXoREOum967YQJ/iGw== X-Google-Smtp-Source: ABdhPJw+9MHfJJlxEEjx+RbBnEi8cHVQYqz5vIyQL24y5z6dfIvIfMX1LfWdV4dF8kIRqorulfWLkw== X-Received: by 2002:a17:907:2da5:b0:6f4:7cd1:8cf5 with SMTP id gt37-20020a1709072da500b006f47cd18cf5mr1769503ejc.328.1651821314516; Fri, 06 May 2022 00:15:14 -0700 (PDT) Received: from [192.168.0.223] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id w16-20020a170907271000b006f3ef214e42sm1559641ejk.168.2022.05.06.00.15.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 May 2022 00:15:13 -0700 (PDT) Message-ID: Date: Fri, 6 May 2022 09:15:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: Aw: Re: [RFC v2] dt-bindings: net: dsa: convert binding for mediatek switches Content-Language: en-US To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Ungerer , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Mauro Carvalho Chehab References: <20220505150008.126627-1-linux@fw-web.de> <6d45f060-85e6-f3ff-ef00-6c68a2ada7a1@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/05/2022 08:46, Frank Wunderlich wrote: >>> + const: 1 >>> + >>> + "#size-cells": >>> + const: 0 >>> + >>> + core-supply: >>> + description: | >> >> Drop | everywhere where it is not needed (so in all places, AFAICT) > > is it necessary for multiline-descriptions or is indentation enough? It's necessary only when YAML syntax characters appear in description or when you want specific formatting. https://elixir.bootlin.com/linux/v5.18-rc5/source/Documentation/devicetree/bindings/example-schema.yaml#L97 https://yaml-multiline.info/ >>> + >>> +patternProperties: >> >> patternProperties go before allOf, just after regular properties. > > after required, right? properties do not go after required, so neither patternProperties should. Something like: propertes -> patternProperties -> dependencies -> required -> allOf -> additionalProperties -> examples > >>> + "^(ethernet-)?ports$": >>> + type: object >> >> Also on this level: >> unevaluatedProperties: false > > this is imho a bit redundant because in dsa.yaml (which is included now after patternProperties) > it is already set on both levels. dsa.yaml does not set it on ethernet-ports. > Adding it here will fail in examples because of size/address-cells which are already defined in dsa.yaml... > so i need to define them here again. You're right, it cannot be set here. Best regards, Krzysztof